]> git.madduck.net Git - etc/vim.git/commit

madduck's git repository

Every one of the projects in this repository is available at the canonical URL git://git.madduck.net/madduck/pub/<projectpath> — see each project's metadata for the exact URL.

All patches and comments are welcome. Please squash your changes to logical commits before using git-format-patch and git-send-email to patches@git.madduck.net. If you'd read over the Git project's submission guidelines and adhered to them, I'd be especially grateful.

SSH access, as well as push access can be individually arranged.

If you use my repositories frequently, consider adding the following snippet to ~/.gitconfig and using the third clone URL listed for each project:

[url "git://git.madduck.net/madduck/"]
  insteadOf = madduck:

Back out #850 (#1079)
authorJelle Zijlstra <jelle.zijlstra@gmail.com>
Sun, 20 Oct 2019 16:02:17 +0000 (09:02 -0700)
committerGitHub <noreply@github.com>
Sun, 20 Oct 2019 16:02:17 +0000 (09:02 -0700)
commit14b28c89c22659e1f935bc0ac22ee03d90bcc290
treed207c7001d3adea910f1e4b8c647f770313e386e
parenta73d25883aaaa3fa3a10ea2ddfcb70ac1efd448e
Back out #850 (#1079)

Fixes #1042 (and probably #1044 which looks like the same thing).

The issue with the "obviously unnecessary" parentheses that #850 removed is that sometimes they're necessary to help Black fit something in one line. I didn't see an obvious solution that still removes the parens #850 was intended to remove, so let's back out this change for now in the interest of unblocking a release.

This PR also adds a test adapted from the failing example in #1042, so that if we try to reapply the #850 change we don't break the same case again.
black.py
tests/data/expression.diff
tests/data/expression.py
tests/data/remove_parens.py