From: Mikhail Gusarov <dottedmag@dottedmag.net>
Date: Sat, 28 Dec 2013 16:31:42 +0000 (+0100)
Subject: Use sh 'default value' expansion more idiomatic construct
X-Git-Url: https://git.madduck.net/code/vcsh.git/commitdiff_plain/769375ca5fd910773362bdb45314b6cdfed9447b?ds=inline

Use sh 'default value' expansion more idiomatic construct
---

diff --git a/vcsh b/vcsh
index 60d0407..79ae0e0 100755
--- a/vcsh
+++ b/vcsh
@@ -360,9 +360,8 @@ write_gitignore() {
 
 	# Contrary to GNU mktemp, mktemp on BSD/OSX requires a template for temp files
 	# Use the template GNU mktemo defaults to
-	# The downside to this is that we need to set TMPDIR explicitly; this may or may not be empty, so...
-	[ -z "$TMPDIR" ] && TMPDIR='/tmp'
-	tempfile=$(mktemp ${TMPDIR}/tmp.XXXXXXXXXX) || fatal "could not create tempfile: '${tempfile}'" 51
+	# The downside to this is that we need to account for unset TMPDIR
+	tempfile=$(mktemp ${TMPDIR:-/tmp}/tmp.XXXXXXXXXX) || fatal "could not create tempfile: '${tempfile}'" 51
 
 	echo '*' > "$tempfile" || fatal "could not write to '$tempfile'" 57
 	for gitignore in $gitignores; do