X-Git-Url: https://git.madduck.net/etc/awesome.git/blobdiff_plain/35957f391460172500255ffe20cf1b34622d93f1..c8a5a8e50217cee17ce58b2946e8559638a8adfd:/widgets/maildir.lua

diff --git a/widgets/maildir.lua b/widgets/maildir.lua
index 2476601..bef09f4 100644
--- a/widgets/maildir.lua
+++ b/widgets/maildir.lua
@@ -7,24 +7,16 @@
                                                   
 --]]
 
-local newtimer        = require("lain.helpers").newtimer
-local read_pipe       = require("lain.helpers").read_pipe
-local spairs          = require("lain.helpers").spairs
-
-local wibox           = require("wibox")
-
-local awful           = require("awful")
-local util            = require("lain.util")
-
-local io              = { popen  = io.popen }
-local os              = { getenv = os.getenv }
-local pairs           = pairs
-local string          = { len    = string.len,
-                          match  = string.match }
-
-local setmetatable    = setmetatable
-
--- Maildir check
+local awful        = require("awful")
+local wibox        = require("wibox")
+local helpers      = require("lain.helpers")
+local io           = { popen  = io.popen }
+local os           = { getenv = os.getenv }
+local string       = { format = string.format,
+                       match  = string.match }
+local setmetatable = setmetatable
+
+-- Maildir check (synchronous)
 -- lain.widgets.maildir
 local maildir = {}
 
@@ -36,59 +28,46 @@ local function worker(args)
     local settings     = args.settings or function() end
     local ext_mail_cmd = args.external_mail_cmd
 
-    maildir.widget = wibox.widget.textbox('')
+    maildir.widget = wibox.widget.textbox()
 
     function update()
-        if ext_mail_cmd ~= nil
-        then
-            awful.util.spawn(ext_mail_cmd)
-        end
+        if ext_mail_cmd then awful.spawn(ext_mail_cmd) end
+
         -- Find pathes to mailboxes.
-        local p = io.popen("find " .. mailpath ..
-                           " -mindepth 1 -maxdepth 2 -type d" ..
-                           " -not -name .git")
+        local p = io.popen(string.format("find %s -mindepth 1 -maxdepth 2 -type d -not -name .git", mailpath))
         local boxes = {}
         repeat
             line = p:read("*l")
-            if line ~= nil
-            then
+            if line then
                 -- Find all files in the "new" subdirectory. For each
                 -- file, print a single character (no newline). Don't
                 -- match files that begin with a dot.
                 -- Afterwards the length of this string is the number of
                 -- new mails in that box.
-                local mailstring = read_pipe("find " .. line ..
-                                    "/new -mindepth 1 -type f " ..
-                                    "-not -name '.*' -printf a")
+                local mailstring = helpers.read_pipe(string.format("find %s /new -mindepth 1 -type f -not -name '.*' -printf a", line))
 
                 -- Strip off leading mailpath.
-                local box = string.match(line, mailpath .. "/(.*)")
-                local nummails = string.len(mailstring)
-                if nummails > 0
-                then
+                local box      = string.match(line, mailpath .. "/(.*)")
+                local nummails = #mailstring
+
+                if nummails > 0 then
                     boxes[box] = nummails
                 end
             end
-        until line == nil
-
+        until not line
         p:close()
 
-        newmail = "no mail"
-        -- Count the total number of mails irrespective of where it was found
-        total = 0
+        local newmail = "no mail"
+        local total = 0
 
-        for box, number in spairs(boxes)
-        do
+        for box, number in helpers.spairs(boxes) do
             -- Add this box only if it's not to be ignored.
-            if not util.element_in_table(box, ignore_boxes)
-            then
+            if not helpers.element_in_table(box, ignore_boxes) then
                 total = total + number
-                if newmail == "no mail"
-                then
-                    newmail = box .. "(" .. number .. ")"
+                if newmail == "no mail" then
+                    newmail = string.format("%s(%s)", box, number)
                 else
-                    newmail = newmail .. ", " ..
-                              box .. "(" .. number .. ")"
+                    newmail = string.format("%s, %s(%s)", newmail, box, number)
                 end
             end
         end
@@ -97,8 +76,9 @@ local function worker(args)
         settings()
     end
 
-    newtimer(mailpath, timeout, update, true)
-    return maildir.widget
+    helpers.newtimer(mailpath, timeout, update, true)
+
+    return setmetatable(maildir, { __index = maildir.widget })
 end
 
 return setmetatable(maildir, { __call = function(_, ...) return worker(...) end })