X-Git-Url: https://git.madduck.net/etc/awesome.git/blobdiff_plain/6603c641c6ce675b010ca1977423747ca55d8795..fc7403534f847a02e9f3862fbfec4335a46c1879:/widgets/weather.lua?ds=sidebyside
diff --git a/widgets/weather.lua b/widgets/weather.lua
index 8a0d751..3df309a 100644
--- a/widgets/weather.lua
+++ b/widgets/weather.lua
@@ -28,24 +28,36 @@ local setmetatable = setmetatable
-- lain.widgets.weather
local function worker(args)
- local weather = {}
- local args = args or {}
- local timeout = args.timeout or 900 -- 15 min
- local timeout_forecast = args.timeout or 86400 -- 24 hrs
- local current_call = "curl -s 'http://api.openweathermap.org/data/2.5/weather?id=%s&units=%s&lang=%s'"
- local forecast_call = "curl -s 'http://api.openweathermap.org/data/2.5/forecast/daily?id=%s&units=%s&lang=%s&cnt=%s'"
- local city_id = args.city_id or 0 -- placeholder
- local units = args.units or "metric"
- local lang = args.lang or "en"
- local cnt = args.cnt or 7
- local date_cmd = args.date_cmd or "date -u -d @%d +'%%a %%d'"
- local icons_path = args.icons_path or lain_icons .. "openweathermap/"
- local notification_preset = args.notification_preset or {}
- local followmouse = args.followmouse or false
- local settings = args.settings or function() end
-
- weather.widget = wibox.widget.textbox('')
- weather.icon = wibox.widget.imagebox()
+ local weather = {}
+ local args = args or {}
+ local APPID = args.APPID or "3e321f9414eaedbfab34983bda77a66e" -- lain default
+ local timeout = args.timeout or 900 -- 15 min
+ local timeout_forecast = args.timeout or 86400 -- 24 hrs
+ local current_call = "curl -s 'http://api.openweathermap.org/data/2.5/weather?id=%s&units=%s&lang=%s&APPID=%s'"
+ local forecast_call = "curl -s 'http://api.openweathermap.org/data/2.5/forecast/daily?id=%s&units=%s&lang=%s&cnt=%s&APPID=%s'"
+ local city_id = args.city_id or 0 -- placeholder
+ local units = args.units or "metric"
+ local lang = args.lang or "en"
+ local cnt = args.cnt or 7
+ local date_cmd = args.date_cmd or "date -u -d @%d +'%%a %%d'"
+ local icons_path = args.icons_path or lain_icons .. "openweathermap/"
+ local notification_preset = args.notification_preset or {}
+ local notification_text_fun = args.notification_text_fun or
+ function (wn)
+ local day = string.gsub(read_pipe(string.format(date_cmd, wn["dt"])), "\n", "")
+ local tmin = math.floor(wn["temp"]["min"])
+ local tmax = math.floor(wn["temp"]["max"])
+ local desc = wn["weather"][1]["description"]
+
+ return string.format("%s: %s, %d - %d ", day, desc, tmin, tmax)
+ end
+ local weather_na_markup = args.weather_na_markup or " N/A "
+ local followmouse = args.followmouse or false
+ local settings = args.settings or function() end
+
+ weather.widget = wibox.widget.textbox(weather_na_markup)
+ weather.icon_path = icons_path .. "na.png"
+ weather.icon = wibox.widget.imagebox(weather.icon_path)
function weather.show(t_out)
weather.hide()
@@ -63,7 +75,7 @@ local function worker(args)
end
function weather.hide()
- if weather.notification ~= nil then
+ if weather.notification then
naughty.destroy(weather.notification)
weather.notification = nil
end
@@ -79,54 +91,50 @@ local function worker(args)
end
function weather.forecast_update()
- local cmd = string.format(forecast_call, city_id, units, lang, cnt)
+ local cmd = string.format(forecast_call, city_id, units, lang, cnt, APPID)
async.request(cmd, function(f)
+ local pos, err
weather_now, pos, err = json.decode(f, 1, nil)
- if not err and weather_now ~= nil and tonumber(weather_now["cod"]) == 200 then
+ if not err and weather_now and tonumber(weather_now["cod"]) == 200 then
weather.notification_text = ''
for i = 1, weather_now["cnt"] do
- day = string.gsub(read_pipe(string.format(date_cmd, weather_now["list"][i]["dt"])), "\n", "")
-
- tmin = math.floor(weather_now["list"][i]["temp"]["min"])
- tmax = math.floor(weather_now["list"][i]["temp"]["max"])
- desc = weather_now["list"][i]["weather"][1]["description"]
-
weather.notification_text = weather.notification_text ..
- string.format("%s: %s, %d - %d ", day, desc, tmin, tmax)
+ notification_text_fun(weather_now["list"][i])
if i < weather_now["cnt"] then
weather.notification_text = weather.notification_text .. "\n"
end
end
else
- weather.icon_path = icons_path .. "na.png"
- weather.notification_text = "API/connection error or bad/not set city ID"
+ weather.notification_text = "API/connection error or invalid city ID"
end
end)
end
function weather.update()
- local cmd = string.format(current_call, city_id, units, lang)
+ local cmd = string.format(current_call, city_id, units, lang, APPID)
async.request(cmd, function(f)
+ local pos, err
weather_now, pos, err = json.decode(f, 1, nil)
if not err and weather_now ~= nil and tonumber(weather_now["cod"]) == 200 then
weather.icon_path = icons_path .. weather_now["weather"][1]["icon"] .. ".png"
- weather.icon:set_image(weather.icon_path)
widget = weather.widget
settings()
else
- weather.widget._layout.text = " N/A " -- tries to avoid textbox bugs
- weather.icon:set_image(icons_path .. "na.png")
+ weather.icon_path = icons_path .. "na.png"
+ weather.widget:set_markup(weather_na_markup)
end
+
+ weather.icon:set_image(weather.icon_path)
end)
end
weather.attach(weather.widget)
newtimer("weather-" .. city_id, timeout, weather.update)
- newtimer("weather_forecast" .. city_id, timeout, weather.forecast_update)
+ newtimer("weather_forecast-" .. city_id, timeout, weather.forecast_update, nil)
return setmetatable(weather, { __index = weather.widget })
end