From: copycat-killer <dada@archlinux.info>
Date: Thu, 12 Jan 2017 19:35:59 +0000 (+0100)
Subject: quake: skip_wibox -> overlap and default to false, followtag redefault to faluse... 
X-Git-Url: https://git.madduck.net/etc/awesome.git/commitdiff_plain/741b65d5eac36c8800610c2bad62ebd621998cc8?ds=sidebyside;hp=03cd1abf3c61ccd8a3cbfe40317d8112eea8413e

quake: skip_wibox -> overlap and default to false, followtag redefault to faluse; closes #264 #265
---

diff --git a/README.rst b/README.rst
index e37d210..4072d35 100644
--- a/README.rst
+++ b/README.rst
@@ -31,7 +31,7 @@ Just make sure that:
 
 - Your code fits with the general style of the module. In particular, you should use the same indentation pattern that the code uses, and also avoid adding space at the ends of lines.
 
-- Your code its easy to understand, maintainable, and modularized. You should also avoid code duplication wherever possible by adding functions or using ``lain.helpers``. If something is unclear, and you can't write it in such a way that it will be clear, explain it with a comment.
+- Your code its easy to understand, maintainable, and modularized. You should also avoid code duplication wherever possible by adding functions or using lain.helpers_. If something is unclear, and you can't write it in such a way that it will be clear, explain it with a comment.
 
 - You test your changes before submitting to make sure that not only your code works, but did not break other parts of the module too!
 
@@ -51,3 +51,4 @@ Screenshots
 .. _awesome-vain: https://github.com/vain/awesome-vain
 .. _Awesome: https://github.com/awesomeWM/awesome
 .. _wiki: https://github.com/copycat-killer/lain/wiki
+.. _lain.helpers: https://github.com/copycat-killer/lain/blob/master/helpers.lua
diff --git a/util/quake.lua b/util/quake.lua
index 9f548a8..6e520b5 100644
--- a/util/quake.lua
+++ b/util/quake.lua
@@ -98,7 +98,7 @@ end
 
 function quake:compute_size()
     local geom
-    if self.skip_wibox then
+    if not self.overlap then
         geom = screen[self.screen].workarea
     else
         geom = screen[self.screen].geometry
@@ -119,15 +119,15 @@ end
 function quake:new(config)
     local conf = config or {}
 
-    conf.app        = conf.app        or "xterm"    -- application to spawn
-    conf.name       = conf.name       or "QuakeDD"  -- window name
-    conf.argname    = conf.argname    or "-name %s" -- how to specify window name
-    conf.extra      = conf.extra      or ""         -- extra arguments
-    conf.visible    = conf.visible    or false      -- initially not visible
-    conf.border     = conf.border     or 1          -- client border width
-    conf.followtag  = conf.followtag  or true       -- spawn on currently focused screen
-    conf.skip_wibox = conf.skip_wibox or true       -- skip the wibox (defaut) or overlap it
-    conf.screen     = conf.screen     or awful.screen.focused()
+    conf.app        = conf.app       or "xterm"    -- application to spawn
+    conf.name       = conf.name      or "QuakeDD"  -- window name
+    conf.argname    = conf.argname   or "-name %s" -- how to specify window name
+    conf.extra      = conf.extra     or ""         -- extra arguments
+    conf.border     = conf.border    or 1          -- client border width
+    conf.visible    = conf.visible   or false      -- initially not visible
+    conf.followtag  = conf.followtag or false      -- spawn on currently focused screen
+    conf.overlap    = conf.overlap   or false      -- overlap wibox
+    conf.screen     = conf.screen    or awful.screen.focused()
 
     -- If width or height <= 1 this is a proportion of the workspace
     conf.height       = conf.height       or 0.25     -- height
diff --git a/wiki b/wiki
index b0e838a..006cb79 160000
--- a/wiki
+++ b/wiki
@@ -1 +1 @@
-Subproject commit b0e838ade84ae851bceb2479bb16c1447057abb7
+Subproject commit 006cb79c302aef03dd064430dd2ceba2689dacc7