From: Luca Capezzuto <luca.capezzuto@soton.ac.uk>
Date: Mon, 8 Apr 2019 10:37:38 +0000 (+0100)
Subject: #424: assert that timeout seconds in every naughty notification are numbers
X-Git-Url: https://git.madduck.net/etc/awesome.git/commitdiff_plain/fd2e616097ac4cb072957b3f0b8134ac1970f831?ds=inline;pf=etc

#424: assert that timeout seconds in every naughty notification are numbers
---

diff --git a/widget/cal.lua b/widget/cal.lua
index 9b613bf..2482ccb 100644
--- a/widget/cal.lua
+++ b/widget/cal.lua
@@ -14,6 +14,7 @@ local os       = os
 local pairs    = pairs
 local string   = string
 local tconcat  = table.concat
+local type     = type
 local tonumber = tonumber
 local tostring = tostring
 
@@ -80,7 +81,7 @@ local function factory(args)
         cal.notification = nil
     end
 
-    function cal.show(timeout, month, year, scr)
+    function cal.show(seconds, month, year, scr)
         cal.notification_preset.text = tconcat(cal.build(month, year))
 
         if cal.three then
@@ -98,7 +99,7 @@ local function factory(args)
             preset  = cal.notification_preset,
             screen  = cal.followtag and awful.screen.focused() or scr or 1,
             icon    = cal.icon,
-            timeout = timeout or cal.notification_preset.timeout or 5
+            timeout = type(seconds) == "number" and seconds or cal.notification_preset.timeout or 5
         }
     end
 
diff --git a/widget/contrib/tp_smapi.lua b/widget/contrib/tp_smapi.lua
index 4f43e44..b8acbe2 100644
--- a/widget/contrib/tp_smapi.lua
+++ b/widget/contrib/tp_smapi.lua
@@ -12,6 +12,7 @@ local gears   = require("gears")
 local naughty = require("naughty")
 local wibox   = require("wibox")
 local string  = string
+local type    = type
 
 -- ThinkPad battery infos and widget creator
 -- http://www.thinkwiki.org/wiki/Tp_smapi
@@ -73,7 +74,7 @@ local function factory(apipath)
         tp_smapi.notification = naughty.notify {
             title   = string.format("%s: %s %s (%s)", batid, mfgr, model, chem),
             text    = msg,
-            timeout = seconds or 0,
+            timeout = type(seconds) == "number" and seconds or 0,
             screen  = scr or focused()
         }
     end
diff --git a/widget/fs.lua b/widget/fs.lua
index d1b7a97..fcc6a26 100644
--- a/widget/fs.lua
+++ b/widget/fs.lua
@@ -15,6 +15,7 @@ local naughty    = require("naughty")
 local math       = math
 local string     = string
 local tconcat    = table.concat
+local type       = type
 local tonumber   = tonumber
 local query_size = Gio.FILE_ATTRIBUTE_FILESYSTEM_SIZE
 local query_free = Gio.FILE_ATTRIBUTE_FILESYSTEM_FREE
@@ -45,7 +46,7 @@ local function factory(args)
         fs.notification_preset.screen = fs.followtag and focused() or scr or 1
         fs.notification = naughty.notify {
             preset  = fs.notification_preset,
-            timeout = seconds or 5
+            timeout = type(seconds) == "number" and seconds or 5
         }
     end
 
diff --git a/widget/weather.lua b/widget/weather.lua
index f35ca68..c998ed9 100644
--- a/widget/weather.lua
+++ b/widget/weather.lua
@@ -13,6 +13,7 @@ local wibox    = require("wibox")
 local math     = math
 local os       = os
 local string   = string
+local type     = type
 local tonumber = tonumber
 
 -- OpenWeatherMap
@@ -51,7 +52,7 @@ local function factory(args)
     weather.icon_path = icons_path .. "na.png"
     weather.icon = wibox.widget.imagebox(weather.icon_path)
 
-    function weather.show(t_out)
+    function weather.show(seconds)
         weather.hide()
 
         if followtag then
@@ -63,12 +64,12 @@ local function factory(args)
             weather.forecast_update()
         end
 
-        weather.notification = naughty.notify({
+        weather.notification = naughty.notify {
+            preset  = notification_preset,
             text    = weather.notification_text,
             icon    = weather.icon_path,
-            timeout = t_out,
-            preset  = notification_preset
-        })
+            timeout = type(seconds == "number") and seconds or notification_preset.timeout
+        }
     end
 
     function weather.hide()
diff --git a/wiki b/wiki
index 7a99459..50fc0e4 160000
--- a/wiki
+++ b/wiki
@@ -1 +1 @@
-Subproject commit 7a994596603c2129ae18dd2de69f765e2838c2cd
+Subproject commit 50fc0e4d153f67f105633b5bf1bda232155d5140