X-Git-Url: https://git.madduck.net/etc/taskwarrior.git/blobdiff_plain/f2d008def446626c071a9ceb2c80acb74d477cd0..b460700187c52de135a5fb55a72cea0bd9faee67:/tasklib/backends.py?ds=sidebyside diff --git a/tasklib/backends.py b/tasklib/backends.py index fe24fd2..b15e8bd 100644 --- a/tasklib/backends.py +++ b/tasklib/backends.py @@ -1,28 +1,28 @@ import abc +import copy +import datetime import json +import logging import os import re +import six import subprocess -from tasklib.filters import TaskWarriorFilter -from tasklib.serializing import local_zone +from .task import Task, TaskQuerySet, ReadOnlyDictView +from .filters import TaskWarriorFilter +from .serializing import local_zone DATE_FORMAT_CALC = '%Y-%m-%dT%H:%M:%S' -VERSION_2_1_0 = six.u('2.1.0') -VERSION_2_2_0 = six.u('2.2.0') -VERSION_2_3_0 = six.u('2.3.0') -VERSION_2_4_0 = six.u('2.4.0') -VERSION_2_4_1 = six.u('2.4.1') -VERSION_2_4_2 = six.u('2.4.2') -VERSION_2_4_3 = six.u('2.4.3') -VERSION_2_4_4 = six.u('2.4.4') -VERSION_2_4_5 = six.u('2.4.5') +logger = logging.getLogger(__name__) class Backend(object): - filter_class = TaskWarriorFilter + @abc.abstractproperty + def filter_class(self): + """Returns the TaskFilter class used by this backend""" + pass @abc.abstractmethod def filter_tasks(self, filter_obj): @@ -82,7 +82,18 @@ class TaskWarriorException(Exception): pass -class TaskWarrior(object): +class TaskWarrior(Backend): + + VERSION_2_1_0 = six.u('2.1.0') + VERSION_2_2_0 = six.u('2.2.0') + VERSION_2_3_0 = six.u('2.3.0') + VERSION_2_4_0 = six.u('2.4.0') + VERSION_2_4_1 = six.u('2.4.1') + VERSION_2_4_2 = six.u('2.4.2') + VERSION_2_4_3 = six.u('2.4.3') + VERSION_2_4_4 = six.u('2.4.4') + VERSION_2_4_5 = six.u('2.4.5') + def __init__(self, data_location=None, create=True, taskrc_location='~/.taskrc'): self.taskrc_location = os.path.expanduser(taskrc_location) @@ -91,8 +102,9 @@ class TaskWarrior(object): if not os.path.exists(self.taskrc_location): self.taskrc_location = '/' + self._config = None self.version = self._get_version() - self.config = { + self.overrides = { 'confirmation': 'no', 'dependency.confirmation': 'no', # See TW-1483 or taskrc man page 'recurrence.confirmation': 'no', # Necessary for modifying R tasks @@ -102,7 +114,7 @@ class TaskWarrior(object): # 2.4.3 onwards supports 0 as infite bulk, otherwise set just # arbitrary big number which is likely to be large enough - 'bulk': 0 if self.version >= VERSION_2_4_3 else 100000, + 'bulk': 0 if self.version >= self.VERSION_2_4_3 else 100000, } # Set data.location override if passed via kwarg @@ -110,24 +122,24 @@ class TaskWarrior(object): data_location = os.path.expanduser(data_location) if create and not os.path.exists(data_location): os.makedirs(data_location) - self.config['data.location'] = data_location + self.overrides['data.location'] = data_location self.tasks = TaskQuerySet(self) def _get_command_args(self, args, config_override=None): command_args = ['task', 'rc:{0}'.format(self.taskrc_location)] - config = self.config.copy() - config.update(config_override or dict()) - for item in config.items(): + overrides = self.overrides.copy() + overrides.update(config_override or dict()) + for item in overrides.items(): command_args.append('rc.{0}={1}'.format(*item)) command_args.extend(map(six.text_type, args)) return command_args def _get_version(self): p = subprocess.Popen( - ['task', '--version'], - stdout=subprocess.PIPE, - stderr=subprocess.PIPE) + ['task', '--version'], + stdout=subprocess.PIPE, + stderr=subprocess.PIPE) stdout, stderr = [x.decode('utf-8') for x in p.communicate()] return stdout.strip('\n') @@ -144,10 +156,11 @@ class TaskWarrior(object): if serialized_value is '': escaped_serialized_value = '' else: - escaped_serialized_value = six.u("'{0}'").format(serialized_value) + escaped_serialized_value = six.u("'{0}'").format( + serialized_value) - format_default = lambda: six.u("{0}:{1}").format(field, - escaped_serialized_value) + format_default = lambda task: six.u("{0}:{1}").format( + field, escaped_serialized_value) format_func = getattr(self, 'format_{0}'.format(field), format_default) @@ -177,26 +190,26 @@ class TaskWarrior(object): old_dependencies = task._original_data.get('depends', set()) - added = self['depends'] - old_dependencies - removed = old_dependencies - self['depends'] + added = task['depends'] - old_dependencies + removed = old_dependencies - task['depends'] # Removed dependencies need to be prefixed with '-' return 'depends:' + ','.join( - [t['uuid'] for t in added] + - ['-' + t['uuid'] for t in removed] - ) + [t['uuid'] for t in added] + + ['-' + t['uuid'] for t in removed] + ) def format_description(self, task): # Task version older than 2.4.0 ignores first word of the # task description if description: prefix is used - if self.version < VERSION_2_4_0: + if self.version < self.VERSION_2_4_0: return task._data['description'] else: return six.u("description:'{0}'").format(task._data['description'] or '') def convert_datetime_string(self, value): - if self.version >= VERSION_2_4_0: + if self.version >= self.VERSION_2_4_0: # For strings, use 'task calc' to evaluate the string to datetime # available since TW 2.4.0 args = value.split() @@ -208,13 +221,25 @@ class TaskWarrior(object): "datetime, its type is not supported: {}" .format(type(value))) + return localized + + @property + def filter_class(self): + return TaskWarriorFilter + # Public interface - def get_config(self): + @property + def config(self): + # First, check if memoized information is available + if self._config: + return self._config + + # If not, fetch the config using the 'show' command raw_output = self.execute_command( - ['show'], - config_override={'verbose': 'nothing'} - ) + ['show'], + config_override={'verbose': 'nothing'} + ) config = dict() config_regex = re.compile(r'^(?P[^\s]+)\s+(?P[^\s].+$)') @@ -224,7 +249,10 @@ class TaskWarrior(object): if match: config[match.group('key')] = match.group('value').strip() - return config + # Memoize the config dict + self._config = ReadOnlyDictView(config) + + return self._config def execute_command(self, args, config_override=None, allow_failure=True, return_all=False): @@ -254,7 +282,7 @@ class TaskWarrior(object): # of recurrent tasks. # Only necessary for TW up to 2.4.1, fixed in 2.4.2. - if self.version < VERSION_2_4_2: + if self.version < self.VERSION_2_4_2: self.execute_command(['next'], allow_failure=False) def merge_with(self, path, push=False): @@ -270,7 +298,7 @@ class TaskWarrior(object): def filter_tasks(self, filter_obj): self.enforce_recurrence() - args = ['export', '--'] + filter_obj.get_filter_params() + args = ['export'] + filter_obj.get_filter_params() tasks = [] for line in self.execute_command(args): if line: @@ -325,7 +353,7 @@ class TaskWarrior(object): def complete_task(self, task): # Older versions of TW do not stop active task at completion - if self.version < VERSION_2_4_0 and task.active: + if self.version < self.VERSION_2_4_0 and task.active: task.stop() self.execute_command([task['uuid'], 'done']) @@ -351,7 +379,7 @@ class TaskWarrior(object): # For older TW versions attempt to uniquely locate the task # using the data we have if it has been just saved. # This can happen when adding a completed task on older TW versions. - if (not valid(output) and self.version < VERSION_2_4_5 + if (not valid(output) and self.version < self.VERSION_2_4_5 and after_save): # Make a copy, removing ID and UUID. It's most likely invalid @@ -364,15 +392,15 @@ class TaskWarrior(object): for key, value in data.items(): taskfilter.add_filter_param(key, value) - output = self.execute_command(['export', '--'] + - taskfilter.get_filter_params()) + output = self.execute_command(['export'] + + taskfilter.get_filter_params()) # If more than 1 task has been matched still, raise an exception if not valid(output): raise TaskWarriorException( "Unique identifiers {0} with description: {1} matches " "multiple tasks: {2}".format( - task['uuid'] or task['id'], task['description'], output) + task['uuid'] or task['id'], task['description'], output) ) return json.loads(output[0])