X-Git-Url: https://git.madduck.net/etc/vim.git/blobdiff_plain/fddf5d44d53fbb23b2632f66b7577649537d280f..d410763d8d4f5874113c9ad32edd9354c4e5589a:/CONTRIBUTING.md?ds=sidebyside diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 455a7c7..42db88f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,17 +1,18 @@ -# Contributing to Black +# Contributing to *Black* Welcome! Happy to see you willing to make the project better. Have you -read the entire [user documentation](http://black.readthedocs.io/en/latest/) +read the entire [user documentation](https://black.readthedocs.io/en/latest/) yet? ## Bird's eye view -In terms of inspiration, *Black* is about as configurable as *gofmt* and -*rustfmt* are. This is deliberate. +In terms of inspiration, *Black* is about as configurable as *gofmt*. +This is deliberate. -Bug reports and fixes are always welcome! Please follow the issue -template on GitHub for best results. +Bug reports and fixes are always welcome! Please follow the [issue +template on GitHub](https://github.com/python/black/issues/new) for best +results. Before you suggest a new feature or configuration knob, ask yourself why you want it. If it enables better integration with some workflow, fixes @@ -24,16 +25,18 @@ to get accepted. You can still try but prepare to be disappointed. ## Technicalities Development on the latest version of Python is preferred. As of this -writing it's 3.6.4. You can use any operating system. I am using macOS +writing it's 3.6.5. You can use any operating system. I am using macOS myself and CentOS at work. Install all development dependencies using: ``` $ pipenv install --dev +$ pipenv shell +$ pre-commit install ``` If you haven't used `pipenv` before but are comfortable with virtualenvs, just run `pip install pipenv` in the virtualenv you're already using and -invoke the command above from the cloned Black repo. It will do the +invoke the command above from the cloned *Black* repo. It will do the correct thing. Before submitting pull requests, run tests with: @@ -41,10 +44,6 @@ Before submitting pull requests, run tests with: $ python setup.py test ``` -Also run mypy and flake8 on `black.py` and `test_black.py`. Travis will -run all that for you but if you left any errors here, it will be quicker -and less embarrassing to fix them locally ;-) - ## Hygiene