From: Toby Fleming <2903454+tobywf@users.noreply.github.com> Date: Thu, 30 Apr 2020 07:47:52 +0000 (-0700) Subject: Change exit code to 2 when config file doesn't exist (#1361) X-Git-Url: https://git.madduck.net/etc/vim.git/commitdiff_plain/7a14a37981862ef418f3cdb4a7e2375856f97529?ds=sidebyside;hp=8126b4f6a9342290de4655e6a8a78cd288ce7daa Change exit code to 2 when config file doesn't exist (#1361) Fixes #1360, where an invalid config file causes a return/exit code of 1. This change means this case is caught earlier, treated like any other bad parameters, and results in an exit code of 2. Co-authored-by: Toby Fleming --- diff --git a/black.py b/black.py index d9348a3..26a2915 100644 --- a/black.py +++ b/black.py @@ -394,7 +394,7 @@ def target_version_option_callback( @click.option( "--config", type=click.Path( - exists=False, file_okay=True, dir_okay=False, readable=True, allow_dash=False + exists=True, file_okay=True, dir_okay=False, readable=True, allow_dash=False ), is_eager=True, callback=read_pyproject_toml, diff --git a/tests/test_black.py b/tests/test_black.py index acbaade..7a4a3bb 100644 --- a/tests/test_black.py +++ b/tests/test_black.py @@ -1645,6 +1645,16 @@ class BlackTestCase(unittest.TestCase): raise result.exception self.assertEqual(result.exit_code, 0) + def test_invalid_config_return_code(self) -> None: + tmp_file = Path(black.dump_to_file()) + try: + tmp_config = Path(black.dump_to_file()) + tmp_config.unlink() + args = ["--config", str(tmp_config), str(tmp_file)] + self.invokeBlack(args, exit_code=2, ignore_config=False) + finally: + tmp_file.unlink() + class BlackDTestCase(AioHTTPTestCase): async def get_application(self) -> web.Application: