From: Łukasz Langa Date: Sun, 25 Apr 2021 18:15:54 +0000 (+0200) Subject: Work around stability errors due to optional trailing commas (#2126) X-Git-Url: https://git.madduck.net/etc/vim.git/commitdiff_plain/8672af35f052a636545e38110f0419ea92aeca0f?hp=8672af35f052a636545e38110f0419ea92aeca0f Work around stability errors due to optional trailing commas (#2126) Optional trailing commas put by Black become magic trailing commas on another pass of the tool. Since they are influencing formatting around optional parentheses, on rare occasions the tool changes its mind in terms of putting parentheses or not. Ideally this would never be the case but sadly the decision to put optional parentheses or not (which looks at pre-existing "magic" trailing commas) is happening around the same time as the decision to put an optional trailing comma. Untangling the two proved to be impractically difficult. This shameful workaround uses the fact that the formatting instability introduced by magic trailing commas is deterministic: if the optional trailing comma becoming a pre-existing "magic" trailing comma changes formatting, the second pass becomes stable since there is no variable factor anymore on pass 3, 4, and so on. For most files, this will introduce no performance penalty since `--safe` is already re-formatting everything twice to ensure formatting stability. We're using this result and if all's good, the behavior is equivalent. If there is a difference, we treat the second result as the binding one, and check its sanity again. ---