From: James Addison <jay@jp-hosting.net>
Date: Mon, 1 Feb 2021 17:54:19 +0000 (+0000)
Subject: Remove placeholder exit code in unreachable 'black-primer' subprocess handler (#1952)
X-Git-Url: https://git.madduck.net/etc/vim.git/commitdiff_plain/988c686d312986760a42cc7edd9a79a8f31c4769

Remove placeholder exit code in unreachable 'black-primer' subprocess handler (#1952)
---

diff --git a/src/black_primer/lib.py b/src/black_primer/lib.py
index c306981..39ae93b 100644
--- a/src/black_primer/lib.py
+++ b/src/black_primer/lib.py
@@ -58,13 +58,16 @@ async def _gen_check_output(
         await process.wait()
         raise
 
-    if process.returncode != 0:
-        returncode = process.returncode
-        if returncode is None:
-            returncode = 69
+    # A non-optional timeout was supplied to asyncio.wait_for, guaranteeing
+    # a timeout or completed process.  A terminated Python process will have a
+    # non-empty returncode value.
+    assert process.returncode is not None
 
+    if process.returncode != 0:
         cmd_str = " ".join(cmd)
-        raise CalledProcessError(returncode, cmd_str, output=stdout, stderr=stderr)
+        raise CalledProcessError(
+            process.returncode, cmd_str, output=stdout, stderr=stderr
+        )
 
     return (stdout, stderr)