From 79575f3376f043186d8b8c4885ef51c6b3c36246 Mon Sep 17 00:00:00 2001
From: aru <genericusername414@gmail.com>
Date: Mon, 30 Aug 2021 13:26:21 -0400
Subject: [PATCH] fix: run pypi / docker upload from published draft releases
 (#2461)

Draft releases don't trigger the workflows (that's good!) but since they only

Commit history before merge:

* fix: run pypi upload from published draft releases
* Fix broken task list markup in PR template
* change docker workflow to build on release publish

Co-authored-by: Richard Si <63936253+ichard26@users.noreply.github.com>
---
 .github/PULL_REQUEST_TEMPLATE.md  | 6 +++---
 .github/workflows/docker.yml      | 2 +-
 .github/workflows/pypi_upload.yml | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 36f98c5..833cd16 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -18,9 +18,9 @@
     Tests are required for bugfixes and new features. Documentation changes
     are necessary for formatting and most enhancement changes. -->
 
-- [] Add a CHANGELOG entry if necessary?
-- [] Add / update tests if necessary?
-- [] Add new / update outdated documentation?
+- [ ] Add a CHANGELOG entry if necessary?
+- [ ] Add / update tests if necessary?
+- [ ] Add new / update outdated documentation?
 
 <!-- Just as a reminder, everyone in all psf/black spaces including PRs
      must follow the PSF Code of Conduct (link below).
diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
index 4bb41a1..1686c56 100644
--- a/.github/workflows/docker.yml
+++ b/.github/workflows/docker.yml
@@ -5,7 +5,7 @@ on:
     branches:
       - "main"
   release:
-    types: created
+    types: [published]
 
 jobs:
   docker:
diff --git a/.github/workflows/pypi_upload.yml b/.github/workflows/pypi_upload.yml
index 5df91d9..201d94f 100644
--- a/.github/workflows/pypi_upload.yml
+++ b/.github/workflows/pypi_upload.yml
@@ -2,7 +2,7 @@ name: pypi_upload
 
 on:
   release:
-    types: created
+    types: [published]
 
 jobs:
   build:
-- 
2.39.5