From a970a205bcea73672e85468836b477d3262ee75e Mon Sep 17 00:00:00 2001 From: =?utf8?q?=C5=81ukasz=20Langa?= Date: Thu, 22 Mar 2018 16:33:50 -0700 Subject: [PATCH 1/1] Don't remove the single trailing comma from square bracket indexing Fixes #59 --- black.py | 8 +++++++- tests/expression.py | 10 +++++++++- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/black.py b/black.py index d3e0761..877b632 100644 --- a/black.py +++ b/black.py @@ -510,10 +510,16 @@ class Line: ): return False - if closing.type == token.RSQB or closing.type == token.RBRACE: + if closing.type == token.RBRACE: self.leaves.pop() return True + if closing.type == token.RSQB: + comma = self.leaves[-1] + if comma.parent and comma.parent.type == syms.listmaker: + self.leaves.pop() + return True + # For parens let's check if it's safe to remove the comma. If the # trailing one is the only one, we might mistakenly change a tuple # into a different type by removing the comma. diff --git a/tests/expression.py b/tests/expression.py index 91e5465..79e7c7e 100644 --- a/tests/expression.py +++ b/tests/expression.py @@ -53,6 +53,7 @@ str or None if (1 if True else 2) else str or bytes or None (1, 2, 3) [] [1, 2, 3, 4, 5, 6, 7, 8, 9, (10 or A), (11 or B), (12 or C)] +[1, 2, 3,] {i for i in (1, 2, 3)} {(i ** 2) for i in (1, 2, 3)} {(i ** 2) for i, _ in ((1, 'a'), (2, 'b'), (3, 'c'))} @@ -84,7 +85,10 @@ call.me(maybe) list[str] dict[str, int] tuple[str, ...] -tuple[str, int, float, dict[str, int]] +tuple[str, int, float, dict[str, int],] +very_long_variable_name_filters: t.List[ + t.Tuple[str, t.Union[str, t.List[t.Optional[str]]]], +] slice[0] slice[0:1] slice[0:1:2] @@ -207,6 +211,7 @@ str or None if (1 if True else 2) else str or bytes or None (1, 2, 3) [] [1, 2, 3, 4, 5, 6, 7, 8, 9, (10 or A), (11 or B), (12 or C)] +[1, 2, 3] {i for i in (1, 2, 3)} {(i ** 2) for i in (1, 2, 3)} {(i ** 2) for i, _ in ((1, 'a'), (2, 'b'), (3, 'c'))} @@ -248,6 +253,9 @@ list[str] dict[str, int] tuple[str, ...] tuple[str, int, float, dict[str, int]] +very_long_variable_name_filters: t.List[ + t.Tuple[str, t.Union[str, t.List[t.Optional[str]]]], +] slice[0] slice[0:1] slice[0:1:2] -- 2.39.5