From ff6bbd5d960ef0053b20c9d9c621c8a348980833 Mon Sep 17 00:00:00 2001 From: Cooper Lees Date: Fri, 22 May 2020 12:16:31 -0700 Subject: [PATCH] Capture CalledProcessError for any postitive returncode (#1450) - Leave logic to still allow for formatting changes to be ignored - Now just capture the output of any other error that has a > 1 returncode - Raise on anything else Test: Add unit test to exercise this new logic --- src/black_primer/lib.py | 4 ++++ tests/test_primer.py | 13 +++++++++++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/src/black_primer/lib.py b/src/black_primer/lib.py index 913f9d5..afeb072 100644 --- a/src/black_primer/lib.py +++ b/src/black_primer/lib.py @@ -131,6 +131,10 @@ async def black_run( else: results.stats["success"] += 1 return + elif cpe.returncode > 1: + results.stats["failed"] += 1 + results.failed_projects[repo_path.name] = cpe + return LOG.error(f"Unknown error with {repo_path}") raise diff --git a/tests/test_primer.py b/tests/test_primer.py index 46ccfc1..a8ad8a7 100644 --- a/tests/test_primer.py +++ b/tests/test_primer.py @@ -67,10 +67,14 @@ def event_loop() -> Iterator[None]: loop.close() -async def raise_subprocess_error(*args: Any, **kwargs: Any) -> None: +async def raise_subprocess_error_1(*args: Any, **kwargs: Any) -> None: raise CalledProcessError(1, ["unittest", "error"], b"", b"") +async def raise_subprocess_error_123(*args: Any, **kwargs: Any) -> None: + raise CalledProcessError(123, ["unittest", "error"], b"", b"") + + async def return_false(*args: Any, **kwargs: Any) -> bool: return False @@ -123,11 +127,16 @@ class PrimerLibTests(unittest.TestCase): # Test a fail based on returning 1 and not expecting formatting changes project_config["expect_formatting_changes"] = False results = lib.Results({"failed": 0, "success": 0}, {}) - with patch("black_primer.lib._gen_check_output", raise_subprocess_error): + with patch("black_primer.lib._gen_check_output", raise_subprocess_error_1): loop.run_until_complete(lib.black_run(repo_path, project_config, results)) self.assertEqual(1, results.stats["failed"]) self.assertTrue(results.failed_projects) + # Test a formatting error based on returning 123 + with patch("black_primer.lib._gen_check_output", raise_subprocess_error_123): + loop.run_until_complete(lib.black_run(repo_path, project_config, results)) + self.assertEqual(2, results.stats["failed"]) + @event_loop() def test_gen_check_output(self) -> None: loop = asyncio.get_event_loop() -- 2.39.5