merge and resolve conflicts from #134; #114

[etc/awesome.git] / widgets / maildir.lua

diff --git a/widgets/maildir.lua b/widgets/maildir.lua
index d4608812e7c62e92e30cfced6eae628b747fc393..8cb821dde3633fba8120a8dce30e6a71a35f759e 100644 (file)
--- a/widgets/maildir.lua
+++ b/widgets/maildir.lua
@@ -8,10 +8,13 @@
 --]]
 
 local newtimer        = require("lain.helpers").newtimer
+local read_pipe       = require("lain.helpers").read_pipe
 
 local wibox           = require("wibox")
 
-local io              = io
+local util            = require("lain.util")
+
+local io              = { popen  = io.popen }
 local os              = { getenv = os.getenv }
 local pairs           = pairs
 local string          = { len    = string.len,
@@ -22,7 +25,7 @@ local setmetatable    = setmetatable
 
 -- Maildir check
 -- lain.widgets.maildir
-local maildir = {}
+local maildir = { total = 0 }
 
 local function worker(args)
     local args         = args or {}
@@ -48,10 +51,9 @@ local function worker(args)
                 -- match files that begin with a dot.
                 -- Afterwards the length of this string is the number of
                 -- new mails in that box.
-                local np = io.popen("find " .. line ..
+                local mailstring = read_pipe("find " .. line ..
                                     "/new -mindepth 1 -type f " ..
                                     "-not -name '.*' -printf a")
-                local mailstring = np:read("*all")
 
                 -- Strip off leading mailpath.
                 local box = string.match(line, mailpath .. "/*([^/]+)")
@@ -63,18 +65,20 @@ local function worker(args)
             end
         until line == nil
 
+        p:close()
         table.sort(boxes)
 
         newmail = "no mail"
+        -- Count the total number of mails irrespective of where it was found
+        total = 0
 
-        local count = 0
         for box, number in pairs(boxes)
         do
-            count = count + 1
             -- Add this box only if it's not to be ignored.
             if not util.element_in_table(box, ignore_boxes)
             then
-                if newmail == ""
+                total = total + number
+                if newmail == "no mail"
                 then
                     newmail = box .. "(" .. number .. ")"
                 else
@@ -84,8 +88,10 @@ local function worker(args)
             end
         end
 
-        widget = maildir.widget
-        settings()
+        if maildir.total ~= total then
+            widget = maildir.widget
+            settings()
+        end
     end
 
     newtimer(mailpath, timeout, update, true)