Some might have spaces in passwords (Like I do) and then curl fails.

[etc/awesome.git] / widgets / imap.lua

diff --git a/widgets/imap.lua b/widgets/imap.lua
index 605c1c482e24954a9592286412105ff8e196d6fa..1ebbb76da6af266608813aecd162fa976b4e2410 100644 (file)
--- a/widgets/imap.lua
+++ b/widgets/imap.lua
@@ -7,11 +7,11 @@
 --]]
 
 local helpers      = require("lain.helpers")
+local async        = require("lain.asyncshell")
 
 local naughty      = require("naughty")
 local wibox        = require("wibox")
 
-local io           = { popen  = io.popen }
 local string       = { format = string.format,
                        gsub   = string.gsub }
 local tonumber     = tonumber
@@ -20,9 +20,9 @@ local setmetatable = setmetatable
 
 -- Mail IMAP check
 -- lain.widgets.imap
-local imap = {}
 
 local function worker(args)
+    local imap     = {}
     local args     = args or {}
 
     local server   = args.server
@@ -34,7 +34,7 @@ local function worker(args)
     local is_plain = args.is_plain or false
     local settings = args.settings or function() end
 
-    local head_command  = "curl --connect-timeout 1 -fsm 3"
+    local head_command  = "curl --connect-timeout 3 -fsm 3"
     local request = "-X 'SEARCH (UNSEEN)'"
 
     helpers.set_map(mail, 0)
@@ -42,7 +42,7 @@ local function worker(args)
     if not is_plain
     then
         local f = io.popen(password)
-        password = f:read("*all"):gsub("\n", "")
+        password = f:read("*a"):gsub("\n", "")
         f:close()
     end
 
@@ -54,35 +54,40 @@ local function worker(args)
             position = "top_left"
         }
 
-        curl = string.format("%s --url imaps://%s:%s/INBOX -u %s:%s %s -k",
+        curl = string.format("%s --url imaps://%s:%s/INBOX -u %s:%q %s -k",
                head_command, server, port, mail, password, request)
 
-        f = io.popen(curl)
-        ws = f:read("*all")
-        f:close()
-
-        t, mailcount = string.gsub(ws, "%d", "")
-        t = nil -- because it's useless
-        mailcount = tonumber(mailcount)
-
-        widget = imap.widget
-        settings()
-
-        if mailcount > helpers.get_map(mail) and mailcount >= 1
-        then
-            if mailcount == 1 then
-                nt = mail .. " has one new message"
-            else
-                nt = mail .. " has <b>" .. mailcount .. "</b> new messages"
+        async.request(curl, function(f)
+            ws = f:read("*a")
+            f:close()
+
+            _, mailcount = string.gsub(ws, "%d+", "")
+            _ = nil
+
+            widget = imap.widget
+            settings()
+
+            if mailcount >= 1 and mailcount > helpers.get_map(mail)
+            then
+                if mailcount == 1 then
+                    nt = mail .. " has one new message"
+                else
+                    nt = mail .. " has <b>" .. mailcount .. "</b> new messages"
+                end
+                naughty.notify({
+                    preset = mail_notification_preset,
+                    text = nt,
+                })
             end
-            naughty.notify({ preset = mail_notification_preset, text = nt })
-        end
 
-        helpers.set_map(mail, mailcount)
+            helpers.set_map(mail, mailcount)
+        end)
+
     end
 
     helpers.newtimer(mail, timeout, update, true)
-    return imap.widget
+
+    return setmetatable(imap, { __index = imap.widget })
 end
 
-return setmetatable(imap, { __call = function(_, ...) return worker(...) end })
+return setmetatable({}, { __call = function(_, ...) return worker(...) end })