fix: better code

[etc/awesome.git] / widgets / yawn / init.lua

diff --git a/widgets/yawn/init.lua b/widgets/yawn/init.lua
index 9bed98334bf86b733ad0536f0b99713cadcd0bbc..a2f756ede41b3259680e388e0277147e834f9a91 100644 (file)
--- a/widgets/yawn/init.lua
+++ b/widgets/yawn/init.lua
@@ -1,4 +1,3 @@
-

 --[[
                                                   
      Licensed under GNU General Public License v2 
 --[[
                                                   
      Licensed under GNU General Public License v2 


@@ -27,52 +26,58 @@ local setmetatable = setmetatable
 -- lain.widgets.yawn
 local yawn =
 {
 -- lain.widgets.yawn
 local yawn =
 {

-    icon                = wibox.widget.imagebox(),
-    widget              = wibox.widget.textbox(''),
-    notification_preset = {}
+    icon   = wibox.widget.imagebox(),
+    widget = wibox.widget.textbox('')

 }
 
 }
 

-local project_path       = debug.getinfo(1, 'S').source:match[[^@(.*/).*$]]
-local localizations_path = project_path .. 'localizations/'
-local icon_path          = project_path .. 'icons/'
-local api_url            = 'http://weather.yahooapis.com/forecastrss'
-local units_set          = '?u=c&w=' -- Default is Celsius
-local language           = string.match(os.getenv("LANG"), "(%S*$*)[.]")
-local weather_data       = nil
-local notification       = nil
-local city_id            = nil
-local sky                = nil
-local settings           = function() end
+local project_path        = debug.getinfo(1, 'S').source:match[[^@(.*/).*$]]
+local localizations_path  = project_path .. 'localizations/'
+local icon_path           = project_path .. 'icons/'
+local api_url             = 'http://weather.yahooapis.com/forecastrss'
+local units_set           = '?u=c&w=' -- Default is Celsius
+local language            = string.match(os.getenv("LANG"), "(%S*$*)[.]")
+local weather_data        = nil
+local notification        = nil
+local city_id             = nil
+local sky                 = nil
+local settings            = function() end
+
+yawn_notification_preset = {}

 
 local function fetch_weather()
     local url = api_url .. units_set .. city_id
 
 local function fetch_weather()
     local url = api_url .. units_set .. city_id

-    local f = io.popen("curl --connect-timeout 1 -fsm 2 '"
-                       .. url .. "'" )
+    local f = io.popen("curl --connect-timeout 1 -fsm 1 '" .. url .. "'" )

     local text = f:read("*all")
     f:close()
 
     local text = f:read("*all")
     f:close()
 

-    -- handle no suitable icon found
-    yawn.icon:set_image(icon_path .. "na.png")
-

     -- In case of no connection or invalid city ID
     -- widgets won't display
     if text == "" or text:match("City not found")
     then
     -- In case of no connection or invalid city ID
     -- widgets won't display
     if text == "" or text:match("City not found")
     then

+        yawn.icon:set_image(icon_path .. "na.png")

         if text == "" then
             weather_data = "Service not available at the moment."
         if text == "" then
             weather_data = "Service not available at the moment."

-            yawn.widget:set_text("N/A")
+            yawn.widget:set_text(" N/A")

         else
             weather_data = "City not found!\n" ..
                            "Are you sure " .. city_id ..
                            " is your Yahoo city ID?"
         else
             weather_data = "City not found!\n" ..
                            "Are you sure " .. city_id ..
                            " is your Yahoo city ID?"

-            yawn.widget:set_text("?")
+            yawn.widget:set_text(" ?")

         end
         return
     end
 
     -- Processing raw data
     weather_data = text:gsub("<.->", "")
         end
         return
     end
 
     -- Processing raw data
     weather_data = text:gsub("<.->", "")

-    weather_data = weather_data:match("Current Conditions:.-Full")
+    weather_data = weather_data:match("Current Conditions:.-Full") or ""
+
+    -- may still happens in case of bad connectivity
+    if weather_data == "" then
+        yawn.icon:set_image(icon_path .. "na.png")
+        yawn.widget:set_text(" ?")
+        return
+    end
+

     weather_data = weather_data:gsub("Current Conditions:.-\n", "Now: ")
     weather_data = weather_data:gsub("Forecast:.-\n", "")
     weather_data = weather_data:gsub("\nFull", "")
     weather_data = weather_data:gsub("Current Conditions:.-\n", "Now: ")
     weather_data = weather_data:gsub("Forecast:.-\n", "")
     weather_data = weather_data:gsub("\nFull", "")


@@ -107,6 +112,11 @@ local function fetch_weather()
 
     sky = sky  .. forecast:gsub(" ", ""):gsub("/", "") .. ".png"
 
 
     sky = sky  .. forecast:gsub(" ", ""):gsub("/", "") .. ".png"
 

+    -- In case there's no defined icon for current forecast
+    if io.open(sky) == nil then
+        sky = icon_path .. "na.png"
+    end
+

     -- Localization
     local f = io.open(localizations_path .. language, "r")
     if language:find("en_") == nil and f ~= nil
     -- Localization
     local f = io.open(localizations_path .. language, "r")
     if language:find("en_") == nil and f ~= nil


@@ -122,17 +132,12 @@ local function fetch_weather()
 
     -- Finally setting infos
     yawn.icon:set_image(sky)
 
     -- Finally setting infos
     yawn.icon:set_image(sky)

-    widget = wibox.widget.textbox()
+    widget = yawn.widget

 
 

-    forecast = weather_data:match(": %S+.-,"):gsub(": ", ""):gsub(",", "\n")
+    forecast = weather_data:match(": %S.-,"):gsub(": ", ""):gsub(",", "")

     units = units:gsub(" ", "")
     units = units:gsub(" ", "")

-    notification_preset = {}
-    -- anche notification preset, con fg, bg e position

 
     settings()
 
     settings()

-
-    yawn.widget = widget
-    yawn.notification_preset = notification_preset 

 end
 
 function yawn.hide()
 end
 
 function yawn.hide()


@@ -143,7 +148,7 @@ function yawn.hide()
 end
 
 function yawn.show(t_out)
 end
 
 function yawn.show(t_out)

-    if yawn.widget._layout.text == "?"
+    if yawn.widget._layout.text:match("?")

     then
         fetch_weather(settings)
     end
     then
         fetch_weather(settings)
     end


@@ -151,7 +156,7 @@ function yawn.show(t_out)
     yawn.hide()
 
     notification = naughty.notify({
     yawn.hide()
 
     notification = naughty.notify({

-        preset = yawn.notification_preset,
+        preset = yawn_notification_preset,

         text = weather_data,
         icon = sky,
         timeout = t_out
         text = weather_data,
         icon = sky,
         timeout = t_out


@@ -176,7 +181,7 @@ function yawn.register(id, args)
         yawn.hide()
     end)
 
         yawn.hide()
     end)
 

-    return { icon = yawn.icon, widget = yawn.widget }
+    return yawn

 end
 
 function yawn.attach(widget, id, args)
 end
 
 function yawn.attach(widget, id, args)