abstract out reading full output of pipes

[etc/awesome.git] / widgets / maildir.lua

diff --git a/widgets/maildir.lua b/widgets/maildir.lua
index 315ae34a819d8f82011cb0821d1772199db8a979..cb96a3015107ff1b8bf0d3da985b81f62a88982d 100644 (file)
--- a/widgets/maildir.lua
+++ b/widgets/maildir.lua
@@ -8,12 +8,12 @@
 --]]
 
 local newtimer        = require("lain.helpers").newtimer
 --]]
 
 local newtimer        = require("lain.helpers").newtimer

+local read_pipe       = require("lain.helpers").read_pipe

 
 local wibox           = require("wibox")
 
 local util            = require("lain.util")
 
 
 local wibox           = require("wibox")
 
 local util            = require("lain.util")
 

-local io              = { popen  = io.popen }

 local os              = { getenv = os.getenv }
 local pairs           = pairs
 local string          = { len    = string.len,
 local os              = { getenv = os.getenv }
 local pairs           = pairs
 local string          = { len    = string.len,


@@ -50,10 +50,9 @@ local function worker(args)
                 -- match files that begin with a dot.
                 -- Afterwards the length of this string is the number of
                 -- new mails in that box.
                 -- match files that begin with a dot.
                 -- Afterwards the length of this string is the number of
                 -- new mails in that box.

-                local np = io.popen("find " .. line ..
+                local mailstring = read_pipe("find " .. line ..

                                     "/new -mindepth 1 -type f " ..
                                     "-not -name '.*' -printf a")
                                     "/new -mindepth 1 -type f " ..
                                     "-not -name '.*' -printf a")

-                local mailstring = np:read("*all")

 
                 -- Strip off leading mailpath.
                 local box = string.match(line, mailpath .. "/*([^/]+)")
 
                 -- Strip off leading mailpath.
                 local box = string.match(line, mailpath .. "/*([^/]+)")


@@ -65,10 +64,11 @@ local function worker(args)
             end
         until line == nil
 
             end
         until line == nil
 

+       p:close()

         table.sort(boxes)
 
         newmail = "no mail"
         table.sort(boxes)
 
         newmail = "no mail"

-        --Count the total number of mails irrespective of where it was found
+        -- Count the total number of mails irrespective of where it was found

         total = 0
 
         for box, number in pairs(boxes)
         total = 0
 
         for box, number in pairs(boxes)