calendar: fix async hanging notifications; closes #289

[etc/awesome.git] / widgets / fs.lua

diff --git a/widgets/fs.lua b/widgets/fs.lua
index b48fcd02506baf6aa6339bffa86aa0f3da279ad3..4e9f04b29268ba12bf3598d475a36fa346dd9c9c 100644 (file)
--- a/widgets/fs.lua
+++ b/widgets/fs.lua
@@ -9,7 +9,6 @@
 local helpers      = require("lain.helpers")
 
 local shell        = require("awful.util").shell
 local helpers      = require("lain.helpers")
 
 local shell        = require("awful.util").shell

-local beautiful    = require("beautiful")

 local focused      = require("awful.screen").focused
 local wibox        = require("wibox")
 local naughty      = require("naughty")
 local focused      = require("awful.screen").focused
 local wibox        = require("wibox")
 local naughty      = require("naughty")


@@ -21,7 +20,7 @@ local setmetatable = setmetatable
 
 -- File system disk space usage
 -- lain.widgets.fs
 
 -- File system disk space usage
 -- lain.widgets.fs

-local fs = {}
+local fs = helpers.make_widget_textbox()

 
 -- Unit definitions
 fs.unit = { ["mb"] = 1024, ["gb"] = 1024^2 }
 
 -- Unit definitions
 fs.unit = { ["mb"] = 1024, ["gb"] = 1024^2 }


@@ -33,23 +32,20 @@ function fs.hide()
 end
 
 function fs.show(seconds, scr)
 end
 
 function fs.show(seconds, scr)

+    fs.update()
+

     fs.hide()
 
     if fs.followtag then
         fs.notification_preset.screen = focused()
     elseif scr then
     fs.hide()
 
     if fs.followtag then
         fs.notification_preset.screen = focused()
     elseif scr then

-        fs.notification_preset.screen = scr
+        fs.notification_preset.screen = scr or 1

     end
 
     end
 

-    local cmd = (fs.options and string.format("dfs %s", fs.options)) or "dfs"
-
-    helpers.async(helpers.scripts_dir .. cmd, function(ws)
-        fs.notification = naughty.notify({
-            preset      = fs.notification_preset,
-            text        = ws:gsub("\n*$", ""),
-            timeout     = seconds or 5,
-        })
-    end)
+    fs.notification = naughty.notify({
+        preset      = fs.notification_preset,
+        timeout     = seconds or 5
+    })

 end
 
 local function worker(args)
 end
 
 local function worker(args)


@@ -62,16 +58,20 @@ local function worker(args)
 
     fs.options             = args.options
     fs.followtag           = args.followtag or false
 
     fs.options             = args.options
     fs.followtag           = args.followtag or false

-    fs.notification_preset = args.notification_preset or { fg = beautiful.fg_normal }
+    fs.notification_preset = args.notification_preset

 
 

-    fs.widget = wibox.widget.textbox()
+    if not fs.notification_preset then
+        fs.notification_preset      = naughty.config.defaults
+        fs.notification_preset.font = "Monospace 10"
+        fs.notification_preset.fg   = "#FFFFFF"
+        fs.notification_preset.bg   = "#000000"
+    end

 
     helpers.set_map(partition, false)
 
 
     helpers.set_map(partition, false)
 

-
-    function update()
+    function fs.update()

         fs_info, fs_now  = {}, {}
         fs_info, fs_now  = {}, {}

-        helpers.async(string.format("%s -c 'LC_ALL=C df -k --output=target,size,used,avail,pcent'", shell), function(f)
+        helpers.async({ shell, "-c", "LC_ALL=C df -k --output=target,size,used,avail,pcent" }, function(f)

             for line in string.gmatch(f, "\n[^\n]+") do
                 local m,s,u,a,p = string.match(line, "(/.-%s).-(%d+).-(%d+).-(%d+).-([%d]+)%%")
                 m = m:gsub(" ", "") -- clean target from any whitespace
             for line in string.gmatch(f, "\n[^\n]+") do
                 local m,s,u,a,p = string.match(line, "(/.-%s).-(%d+).-(%d+).-(%d+).-([%d]+)%%")
                 m = m:gsub(" ", "") -- clean target from any whitespace


@@ -101,17 +101,20 @@ local function worker(args)
 
             if notify == "on" and tonumber(fs_now.used) >= 99 and not helpers.get_map(partition) then
                 naughty.notify({
 
             if notify == "on" and tonumber(fs_now.used) >= 99 and not helpers.get_map(partition) then
                 naughty.notify({

-                    title   = "warning",
-                    text    = partition .. " is empty!",
-                    timeout = 8,
-                    fg      = "#000000",
-                    bg      = "#FFFFFF"
+                    preset = naughty.config.presets.critical,
+                    title  = "Warning",
+                    text   = partition .. " is empty",

                 })
                 helpers.set_map(partition, true)
             else
                 helpers.set_map(partition, false)
             end
         end)
                 })
                 helpers.set_map(partition, true)
             else
                 helpers.set_map(partition, false)
             end
         end)

+
+        local notifycmd = (fs.options and string.format("dfs %s", fs.options)) or "dfs"
+        helpers.async(helpers.scripts_dir .. notifycmd, function(ws)
+            fs.notification_preset.text = ws:gsub("\n*$", "")
+        end)

     end
 
     if showpopup == "on" then
     end
 
     if showpopup == "on" then


@@ -119,7 +122,7 @@ local function worker(args)
        fs.widget:connect_signal('mouse::leave', function () fs.hide() end)
     end
 
        fs.widget:connect_signal('mouse::leave', function () fs.hide() end)
     end
 

-    helpers.newtimer(partition, timeout, update)
+    helpers.newtimer(partition, timeout, fs.update)

 
     return setmetatable(fs, { __index = fs.widget })
 end
 
     return setmetatable(fs, { __index = fs.widget })
 end