fix: better code

[etc/awesome.git] / widgets / yawn / init.lua

diff --git a/widgets/yawn/init.lua b/widgets/yawn/init.lua
index e7953e1c209ed2b459126b82384a366294039700..a2f756ede41b3259680e388e0277147e834f9a91 100644 (file)
--- a/widgets/yawn/init.lua
+++ b/widgets/yawn/init.lua
@@ -46,8 +46,7 @@ yawn_notification_preset = {}
 
 local function fetch_weather()
     local url = api_url .. units_set .. city_id
 
 local function fetch_weather()
     local url = api_url .. units_set .. city_id

-    local f = io.popen("curl --connect-timeout 1 -fsm 1 '"
-                       .. url .. "'" )
+    local f = io.popen("curl --connect-timeout 1 -fsm 1 '" .. url .. "'" )

     local text = f:read("*all")
     f:close()
 
     local text = f:read("*all")
     f:close()
 


@@ -58,12 +57,12 @@ local function fetch_weather()
         yawn.icon:set_image(icon_path .. "na.png")
         if text == "" then
             weather_data = "Service not available at the moment."
         yawn.icon:set_image(icon_path .. "na.png")
         if text == "" then
             weather_data = "Service not available at the moment."

-            yawn.widget:set_text("N/A")
+            yawn.widget:set_text(" N/A")

         else
             weather_data = "City not found!\n" ..
                            "Are you sure " .. city_id ..
                            " is your Yahoo city ID?"
         else
             weather_data = "City not found!\n" ..
                            "Are you sure " .. city_id ..
                            " is your Yahoo city ID?"

-            yawn.widget:set_text("?")
+            yawn.widget:set_text(" ?")

         end
         return
     end
         end
         return
     end


@@ -75,7 +74,7 @@ local function fetch_weather()
     -- may still happens in case of bad connectivity
     if weather_data == "" then
         yawn.icon:set_image(icon_path .. "na.png")
     -- may still happens in case of bad connectivity
     if weather_data == "" then
         yawn.icon:set_image(icon_path .. "na.png")

-        yawn.widget:set_text("?")
+        yawn.widget:set_text(" ?")

         return
     end
 
         return
     end
 


@@ -116,8 +115,6 @@ local function fetch_weather()
     -- In case there's no defined icon for current forecast
     if io.open(sky) == nil then
         sky = icon_path .. "na.png"
     -- In case there's no defined icon for current forecast
     if io.open(sky) == nil then
         sky = icon_path .. "na.png"

-    else
-        io.close(f)

     end
 
     -- Localization
     end
 
     -- Localization


@@ -151,7 +148,7 @@ function yawn.hide()
 end
 
 function yawn.show(t_out)
 end
 
 function yawn.show(t_out)

-    if yawn.widget._layout.text == "?"
+    if yawn.widget._layout.text:match("?")

     then
         fetch_weather(settings)
     end
     then
         fetch_weather(settings)
     end