some cpu usage improvements

[etc/awesome.git] / widgets / base.lua

diff --git a/widgets/base.lua b/widgets/base.lua
index 3d4ce9e41436c5f25da049ee5f9efa621c48b0aa..272163c067f22d1e517a8ba27507a3cafb785b3a 100644 (file)
--- a/widgets/base.lua
+++ b/widgets/base.lua
@@ -7,16 +7,17 @@
 --]]
 
 local newtimer     = require("lain.helpers").newtimer
 --]]
 
 local newtimer     = require("lain.helpers").newtimer

+local read_pipe    = require("lain.helpers").read_pipe
+

 local wibox        = require("wibox")
 
 local wibox        = require("wibox")
 

-local io           = io

 local setmetatable = setmetatable
 
 local setmetatable = setmetatable
 

--- Basic template for custom widgets 
+-- Basic template for custom widgets

 -- lain.widgets.base
 -- lain.widgets.base

-local base = {}

 
 local function worker(args)
 
 local function worker(args)

+    local base     = {}

     local args     = args or {}
     local timeout  = args.timeout or 5
     local cmd      = args.cmd or ""
     local args     = args or {}
     local timeout  = args.timeout or 5
     local cmd      = args.cmd or ""


@@ -25,11 +26,12 @@ local function worker(args)
     base.widget = wibox.widget.textbox('')
 
     function base.update()
     base.widget = wibox.widget.textbox('')
 
     function base.update()

-        local f = assert(io.popen(cmd))
-        output = f:read("*all")
-        f:close()
-        widget = base.widget
-        settings()
+        if output ~= abase.prev then
+            output = read_pipe(cmd)
+            widget = base.widget
+            settings()
+            abase.prev = output
+        end

     end
 
     newtimer(cmd, timeout, base.update)
     end
 
     newtimer(cmd, timeout, base.update)


@@ -37,4 +39,4 @@ local function worker(args)
     return setmetatable(base, { __index = base.widget })
 end
 
     return setmetatable(base, { __index = base.widget })
 end
 

-return setmetatable(base, { __call = function(_, ...) return worker(...) end })
+return setmetatable({}, { __call = function(_, ...) return worker(...) end })