#293: eradicate proxy widget

[etc/awesome.git] / widgets / base.lua

diff --git a/widgets/base.lua b/widgets/base.lua
index 0431d03a8891f15696ff674aa47e501cf7a86b2a..2a8f507692f1c7daed7668037c31ed7e80e28b84 100644 (file)
--- a/widgets/base.lua
+++ b/widgets/base.lua
@@ -6,32 +6,34 @@
                                                   
 --]]
 
-local newtimer     = require("lain.helpers").newtimer
+local helpers      = require("lain.helpers")
 local wibox        = require("wibox")
-
-local io           = io
 local setmetatable = setmetatable
 
--- Basic template for simple widgets 
+-- Basic template for custom widgets
 -- lain.widgets.base
-local base = {}
 
 local function worker(args)
-    local args     = args or {}
-    local timeout  = args.timeout or 5
-    local cmd      = args.cmd or ""
-    local settings = args.settings or function() end
-
-    base.widget = wibox.widget.textbox('')
-
-    function update()
-        output = io.popen(cmd):read("*all")
-        widget = base.widget
-        settings()
+    local base      = { widget = wibox.widget.textbox() }
+    local args      = args or {}
+    local timeout   = args.timeout or 5
+    local nostart   = args.nostart or false
+    local stoppable = args.stoppable or false
+    local cmd       = args.cmd
+    local settings  = args.settings or function() end
+
+    function base.update()
+        output = helpers.read_pipe(cmd)
+        if output ~= base.prev then
+            widget = base.widget
+            settings()
+            base.prev = output
+        end
     end
 
-    newtimer(cmd, timeout, update)
-    return base.widget
+    base.timer = helpers.newtimer(cmd, timeout, base.update, nostart, stoppable)
+
+    return base
 end
 
-return setmetatable(base, { __call = function(_, ...) return worker(...) end })
+return setmetatable({}, { __call = function(_, ...) return worker(...) end })