#263: followtag default to true; changing quake definition

[etc/awesome.git] / util / quake.lua

diff --git a/util/quake.lua b/util/quake.lua
index 6023e3f26029c7e86e2baafd29d6a5c8989d1cc4..8a530f396a1bda08115955f0248b20831c2a85c1 100644 (file)
--- a/util/quake.lua
+++ b/util/quake.lua
@@ -54,15 +54,15 @@ function quake:display()
 
     if not client then
         -- The client does not exist, we spawn it
-        awful.util.spawn(string.format("%s %s %s", self.app,
-                         string.format(self.argname, self.name), self.extra),
-                         false, self.screen)
+        awful.spawn(string.format("%s %s %s", self.app,
+                    string.format(self.argname, self.name), self.extra),
+                    false, self.screen)
         self.notexist = true
         return
     end
 
     -- Resize
-    awful.client.floating.set(client, true)
+    client.floating = true
     client.border_width = self.border
     client.size_hints_honor = false
     if self.notexist then
@@ -81,8 +81,8 @@ function quake:display()
     if self.visible then
         client.hidden = false
         client:raise()
-        self.last_tag = awful.tag.selected(self.screen)
-        client:tags({awful.tag.selected(self.screen)})
+        self.last_tag = self.screen.selected_tag
+        client:tags({self.screen.selected_tag})
         capi.client.focus = client
    else
         client.hidden = true
@@ -98,16 +98,16 @@ end
 
 function quake:compute_size()
     local geom = screen[self.screen].workarea
-    local width, height
-    if self.width  <= 1 then width = math.floor(geom.width * self.width) - 2 * self.border end
-    if self.height <= 1 then height = math.floor(geom.height * self.height) end
+    local width, height = self.width, self.height
+    if width  <= 1 then width = math.floor(geom.width * width) - 2 * self.border end
+    if height <= 1 then height = math.floor(geom.height * height) end
     local x, y
     if     self.horiz == "left"  then x = geom.x
-    elseif self.horiz == "right" then x = geom.width + geom.x - self.width
-    else   x = geom.x + (geom.width - self.width)/2 end
+    elseif self.horiz == "right" then x = geom.width + geom.x - width
+    else   x = geom.x + (geom.width - width)/2 end
     if     self.vert == "top"    then y = geom.y
-    elseif self.vert == "bottom" then y = geom.height + geom.y - self.height
-    else   y = geom.y + (geom.height - self.height)/2 end
+    elseif self.vert == "bottom" then y = geom.height + geom.y - height
+    else   y = geom.y + (geom.height - height)/2 end
     self.geometry = { x = x, y = y, width = width, height = height }
 end
 
@@ -120,7 +120,7 @@ function quake:new(config)
     conf.extra     = conf.extra     or ""         -- extra arguments
     conf.visible   = conf.visible   or false      -- initially not visible
     conf.border    = conf.border    or 1          -- client border width
-    conf.followtag = conf.followtag or false      -- spawn on currently focused screen
+    conf.followtag = conf.followtag or true       -- spawn on currently focused screen
     conf.screen    = conf.screen    or awful.screen.focused()
 
     -- If width or height <= 1 this is a proportion of the workspace
@@ -155,15 +155,13 @@ end
 
 function quake:toggle()
      if self.followtag then self.screen = awful.screen.focused() end
-     local current_tag = awful.tag.selected(self.screen)
-     if self.last_tag ~= current_tag and self.visible then
-         awful.client.movetotag(current_tag, self:display())
+     local current_tag = self.screen.selected_tag
+     if current_tag and self.last_tag ~= current_tag and self.visible then
+         self:display():move_to_tag(current_tag)
      else
          self.visible = not self.visible
          self:display()
      end
 end
 
-setmetatable(quake, { __call = function(_, ...) return quake:new(...) end })
-
-return quake
+return setmetatable(quake, { __call = function(_, ...) return quake:new(...) end })