]> git.madduck.net Git - etc/vim.git/commit

madduck's git repository

Every one of the projects in this repository is available at the canonical URL git://git.madduck.net/madduck/pub/<projectpath> — see each project's metadata for the exact URL.

All patches and comments are welcome. Please squash your changes to logical commits before using git-format-patch and git-send-email to patches@git.madduck.net. If you'd read over the Git project's submission guidelines and adhered to them, I'd be especially grateful.

SSH access, as well as push access can be individually arranged.

If you use my repositories frequently, consider adding the following snippet to ~/.gitconfig and using the third clone URL listed for each project:

[url "git://git.madduck.net/madduck/"]
  insteadOf = madduck:

Fix fmt on/off when multiple exist in leaf prefix (#1086)
authorLawrence Chan <llchan@users.noreply.github.com>
Mon, 28 Oct 2019 19:51:45 +0000 (14:51 -0500)
committerŁukasz Langa <lukasz@langa.pl>
Mon, 28 Oct 2019 19:51:45 +0000 (20:51 +0100)
commit23fec8b0f73a142d1796c8ca958230ad52d83c24
tree6903afcf5658ef74ded49e20d11900aef6f65910
parentf99fad1b78a773f2a712b9ce21496e80cce6cf4f
Fix fmt on/off when multiple exist in leaf prefix (#1086)

The old behavior would detect the existence of a `# fmt: on` in a leaf
node's comment prefix and immediately mark the node as formatting-on,
even if a subsequent `# fmt: off` in the same comment prefix would turn
it back off. This change modifies that logic to track the state through
the entire prefix and take the final state.

Note that this does not fully solve on/off behavior, since any _comment_
lines between the off/on are still formatted. We may need to add
virtual leaf nodes to truly solve that. I will leave that for a separate
commit/PR.

Fixes #1005
black.py
tests/data/fmtonoff.py
tests/data/fmtonoff3.py [new file with mode: 0644]
tests/test_black.py