git.madduck.net Git - etc/vim.git/commit

Every one of the projects in this repository is available at the canonical URL git://git.madduck.net/madduck/pub/<projectpath> — see each project's metadata for the exact URL.

All patches and comments are welcome. Please squash your changes to logical commits before using git-format-patch and git-send-email to patches@git.madduck.net. If you'd read over the Git project's submission guidelines and adhered to them, I'd be especially grateful.

If you use my repositories frequently, consider adding the following snippet to ~/.gitconfig and using the third clone URL listed for each project:

author	Richard Si <63936253+ichard26@users.noreply.github.com>
	Thu, 14 Jul 2022 23:47:33 +0000 (19:47 -0400)
committer	GitHub <noreply@github.com>
	Thu, 14 Jul 2022 23:47:33 +0000 (19:47 -0400)
commit	ad5c315ddad26a3c41f22d3b73c493fb7d7b86b8
tree	3aa28dfd5e108d27bd7b220c9fe2126a9211785b	tree \| snapshot
parent	9aa33f467bafce081635ce88807d42b10b0a3105	commit \| diff

Actually disable docstring prefix normalization with -S + fix instability (#3168)

The former was a regression I introduced a long time ago. To avoid
changing the stable style too much, the regression is only fixed if
--preview is enabled

Annoyingly enough, as we currently always enforce a second format pass if
changes were made, there's no good way to prove the existence of the
docstring quote normalization instability issue. For posterity, here's
one failing example:

    --- source
    +++ first pass
    @@ -1,7 +1,7 @@
     def some_function(self):
    -    ''''<text here>
    +    """ '<text here>

         <text here, since without another non-empty line black is stable>

    -    '''
    +    """
         pass
    --- first pass
    +++ second pass
    @@ -1,7 +1,7 @@
     def some_function(self):
    -    """ '<text here>
    +    """'<text here>

         <text here, since without another non-empty line black is stable>

         """
         pass

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

CHANGES.md		diff \| blob \| history
src/black/linegen.py		diff \| blob \| history
src/black/mode.py		diff \| blob \| history
tests/data/miscellaneous/docstring_preview_no_string_normalization.py	[new file with mode: 0644]	blob
tests/data/simple_cases/docstring.py		diff \| blob \| history
tests/test_format.py		diff \| blob \| history

madduck's git repository

Legalese