Fix duplication of checks on internal PRs (#1986)

Internal PRs (that come from branches of psf/black) match both the push
and pull_request events. This leads to a duplication of test, lint, etc.
checks on such PRs. Not only is it a waste of resources, it makes the
Status Checks UI more frustrating to go through.

Patch taken from:
https://github.community/t/duplicate-checks-on-push-and-pull-request-simultaneous-event/18012

diff --git a/.github/workflows/doc.yml b/.github/workflows/doc.yml
index d266e55aa021ceb5dd7810a36c5817b2f8072a9c..930b6d440ff04fef065fd00cec2bc97f71146323 100644 (file)
--- a/.github/workflows/doc.yml
+++ b/.github/workflows/doc.yml
@@ -16,8 +16,14 @@ on:
 
 jobs:
   build:
 
 jobs:
   build:

-    runs-on: ubuntu-latest
+    # We want to run on external PRs, but not on our own internal PRs as they'll be run
+    # by the push to the branch. Without this if check, checks are duplicated since
+    # internal PRs match both the push and pull_request events.
+    if:
+      github.event_name == 'push' || github.event.pull_request.head.repo.full_name !=
+      github.repository

 
 

+    runs-on: ubuntu-latest

     steps:
       - uses: actions/checkout@v2
 
     steps:
       - uses: actions/checkout@v2
 

diff --git a/.github/workflows/fuzz.yml b/.github/workflows/fuzz.yml
index 0153767509a7ece2cbedb377b5e85151d8672826..f3b688f3ef69e7a5db5ef781f1eae62af230b43a 100644 (file)
--- a/.github/workflows/fuzz.yml
+++ b/.github/workflows/fuzz.yml
@@ -4,6 +4,13 @@ on: [push, pull_request]
 
 jobs:
   build:
 
 jobs:
   build:

+    # We want to run on external PRs, but not on our own internal PRs as they'll be run
+    # by the push to the branch. Without this if check, checks are duplicated since
+    # internal PRs match both the push and pull_request events.
+    if:
+      github.event_name == 'push' || github.event.pull_request.head.repo.full_name !=
+      github.repository
+

     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false

diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index fa7286eec1fb0415499aa6a945892679807eb404..e01e9ade5e20941c2cf832ac1e93dc65c97dfb81 100644 (file)
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -4,6 +4,13 @@ on: [push, pull_request]
 
 jobs:
   build:
 
 jobs:
   build:

+    # We want to run on external PRs, but not on our own internal PRs as they'll be run
+    # by the push to the branch. Without this if check, checks are duplicated since
+    # internal PRs match both the push and pull_request events.
+    if:
+      github.event_name == 'push' || github.event.pull_request.head.repo.full_name !=
+      github.repository
+

     runs-on: ubuntu-latest
     strategy:
       matrix:
     runs-on: ubuntu-latest
     strategy:
       matrix:

diff --git a/.github/workflows/primer.yml b/.github/workflows/primer.yml
index b623b9383451e72c59b1be2196c9d3ce09a27aa9..4c5751ae996e8834fe19623666f9a317ddcc15d1 100644 (file)
--- a/.github/workflows/primer.yml
+++ b/.github/workflows/primer.yml
@@ -4,6 +4,13 @@ on: [push, pull_request]
 
 jobs:
   build:
 
 jobs:
   build:

+    # We want to run on external PRs, but not on our own internal PRs as they'll be run
+    # by the push to the branch. Without this if check, checks are duplicated since
+    # internal PRs match both the push and pull_request events.
+    if:
+      github.event_name == 'push' || github.event.pull_request.head.repo.full_name !=
+      github.repository
+

     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 8dd4e4f59fd48b626715a9eaaca5a99327cf2ed8..bec769064c2c7e544b50c3cdfd109994a1012f0a 100644 (file)
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -4,6 +4,13 @@ on: [push, pull_request]
 
 jobs:
   build:
 
 jobs:
   build:

+    # We want to run on external PRs, but not on our own internal PRs as they'll be run
+    # by the push to the branch. Without this if check, checks are duplicated since
+    # internal PRs match both the push and pull_request events.
+    if:
+      github.event_name == 'push' || github.event.pull_request.head.repo.full_name !=
+      github.repository
+

     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false