Fix indent of "elif" after "else" (#128)

Fixes https://github.com/Vimjas/vim-python-pep8-indent/issues/125.

diff --git a/indent/python.vim b/indent/python.vim
index 532bab585521c0f4cbbe1a08ab928768a1c05249..3c86195606f68dfed29429151c8af5ceed6de8dc 100644 (file)
--- a/indent/python.vim
+++ b/indent/python.vim
@@ -48,13 +48,13 @@ if !exists('g:python_pep8_indent_searchpair_timeout')
 endif
 
 let s:block_rules = {
 endif
 
 let s:block_rules = {

-            \ '^\s*elif\>': ['if', 'elif'],
-            \ '^\s*except\>': ['try', 'except'],
-            \ '^\s*finally\>': ['try', 'except', 'else']
-            \ }
+      \ '^\s*elif\>': [['if', 'elif'], ['else']],
+      \ '^\s*except\>': [['try', 'except'], []],
+      \ '^\s*finally\>': [['try', 'except', 'else'], []]
+      \ }

 let s:block_rules_multiple = {
 let s:block_rules_multiple = {

-            \ '^\s*else\>': ['if', 'elif', 'for', 'try', 'except'],
-            \ }
+      \ '^\s*else\>': [['if', 'elif', 'for', 'try', 'except'], []]
+      \ }

 " Pairs to look for when searching for opening parenthesis.
 " The value is the maximum offset in lines.
 let s:paren_pairs = {'()': 50, '[]': 100, '{}': 1000}
 " Pairs to look for when searching for opening parenthesis.
 " The value is the maximum offset in lines.
 let s:paren_pairs = {'()': 50, '[]': 100, '{}': 1000}


@@ -150,15 +150,23 @@ function! s:find_start_of_multiline_statement(lnum)
 endfunction
 
 " Find possible indent(s) of the block starter that matches the current line.
 endfunction
 
 " Find possible indent(s) of the block starter that matches the current line.

-function! s:find_start_of_block(lnum, types, multiple)
+function! s:find_start_of_block(lnum, types, skip, multiple) abort

     let r = []
     let re = '\V\^\s\*\('.join(a:types, '\|').'\)\>'
     let r = []
     let re = '\V\^\s\*\('.join(a:types, '\|').'\)\>'

+    if !empty(a:skip)
+      let re_skip = '\V\^\s\*\('.join(a:skip, '\|').'\)\>'
+    else
+      let re_skip = ''
+    endif

     let lnum = a:lnum
     let last_indent = indent(lnum) + 1
     while lnum > 0 && last_indent > 0
         let indent = indent(lnum)
         if indent < last_indent
     let lnum = a:lnum
     let last_indent = indent(lnum) + 1
     while lnum > 0 && last_indent > 0
         let indent = indent(lnum)
         if indent < last_indent

-            if getline(lnum) =~# re
+            let line = getline(lnum)
+            if !empty(re_skip) && line =~# re_skip
+                let last_indent = indent
+            elseif line =~# re

                 if !a:multiple
                     return [indent]
                 endif
                 if !a:multiple
                     return [indent]
                 endif


@@ -239,14 +247,16 @@ function! s:indent_like_block(lnum)
     let text = getline(a:lnum)
     for [multiple, block_rules] in [
                 \ [0, s:block_rules],
     let text = getline(a:lnum)
     for [multiple, block_rules] in [
                 \ [0, s:block_rules],

-                \ [1, s:block_rules_multiple]]
-        for [line_re, blocks] in items(block_rules)
+                \ [1, s:block_rules_multiple],
+                \ ]
+        for [line_re, blocks_ignore] in items(block_rules)

             if text !~# line_re
                 continue
             endif
 
             if text !~# line_re
                 continue
             endif
 

-            let indents = s:find_start_of_block(a:lnum - 1, blocks, multiple)
-            if !len(indents)
+            let [blocks, skip] = blocks_ignore
+            let indents = s:find_start_of_block(a:lnum - 1, blocks, skip, multiple)
+            if empty(indents)

                 return -1
             endif
             if len(indents) == 1
                 return -1
             endif
             if len(indents) == 1

diff --git a/spec/indent/indent_spec.rb b/spec/indent/indent_spec.rb
index 641ad7e14145dee9d5b22ebb147f192a84022c03..2ff0cafc72a418a8006f3ad56447fe7b15ab839c 100644 (file)
--- a/spec/indent/indent_spec.rb
+++ b/spec/indent/indent_spec.rb
@@ -744,3 +744,18 @@ describe "o within TODO" do
     indent.should == shiftwidth
   end
 end
     indent.should == shiftwidth
   end
 end

+
+describe "elif after else" do
+  before {
+    vim.feedkeys '\<ESC>ggdG'
+  }
+
+  it "is indented to the outer if" do
+    vim.feedkeys 'iif 1:\<CR>if 2:\<CR>pass\<CR>else:\<CR>pass\<CR>elif 3:\<Esc>'
+    indent.should == 0
+
+    vim.feedkeys '\<ESC>ggdG'
+    vim.feedkeys 'i    if 1:\<CR>if 2:\<CR>pass\<CR>else:\<CR>pass\<CR>elif 3:\<Esc>'
+    indent.should == 4
+  end
+end