Fix multiline handling with blank lines (#111)

diff --git a/indent/python.vim b/indent/python.vim
index cd44fbacd35655aeaa6635e409cce74724d7054f..8444a226a57d06d63a6e452ae5098e907a2fae56 100644 (file)
--- a/indent/python.vim
+++ b/indent/python.vim
@@ -337,11 +337,11 @@ endfunction
 " Is the syntax at lnum (and optionally cnum) a python string?
 function! s:is_python_string(lnum, ...)
     let line = getline(a:lnum)
 " Is the syntax at lnum (and optionally cnum) a python string?
 function! s:is_python_string(lnum, ...)
     let line = getline(a:lnum)

-    let linelen = len(line)
-    if linelen < 1
-      let linelen = 1
+    if a:0
+      let cols = type(a:1) != type([]) ? [a:1] : a:1
+    else
+      let cols = range(1, max([1, len(line)]))

     endif
     endif

-    let cols = a:0 ? type(a:1) != type([]) ? [a:1] : a:1 : range(1, linelen)

     for cnum in cols
         if match(map(synstack(a:lnum, cnum),
                     \ "synIDattr(v:val, 'name')"), 'python\S*String') == -1
     for cnum in cols
         if match(map(synstack(a:lnum, cnum),
                     \ "synIDattr(v:val, 'name')"), 'python\S*String') == -1


@@ -361,7 +361,7 @@ function! GetPythonPEPIndent(lnum)
     let prevline = getline(a:lnum-1)
 
     " Multilinestrings: continous, docstring or starting.
     let prevline = getline(a:lnum-1)
 
     " Multilinestrings: continous, docstring or starting.

-    if s:is_python_string(a:lnum-1, len(prevline))
+    if s:is_python_string(a:lnum-1, max([1, len(prevline)]))

                 \ && (s:is_python_string(a:lnum, 1)
                 \     || match(line, '^\%("""\|''''''\)') != -1)
 
                 \ && (s:is_python_string(a:lnum, 1)
                 \     || match(line, '^\%("""\|''''''\)') != -1)
 


@@ -379,8 +379,8 @@ function! GetPythonPEPIndent(lnum)
         endif
 
         if s:is_python_string(a:lnum-1)
         endif
 
         if s:is_python_string(a:lnum-1)

-            " Previous line is (completely) a string.
-            return indent(a:lnum-1)
+            " Previous line is (completely) a string: keep current indent.
+            return -1

         endif
 
         if match(prevline, '^\s*\%("""\|''''''\)') != -1
         endif
 
         if match(prevline, '^\s*\%("""\|''''''\)') != -1

diff --git a/spec/indent/indent_spec.rb b/spec/indent/indent_spec.rb
index a85edcc97fea6605c56060b72d35d5e2870e6e3d..e60da6215e45e5e89c1e7cc59dccb4aa93dcbe0b 100644 (file)
--- a/spec/indent/indent_spec.rb
+++ b/spec/indent/indent_spec.rb
@@ -130,7 +130,7 @@ shared_examples_for "vim" do
       vim.echo('synIDattr(synID(line("."), col("."), 0), "name")'
               ).downcase.should include 'string'
       vim.feedkeys 'a\<CR>'
       vim.echo('synIDattr(synID(line("."), col("."), 0), "name")'
               ).downcase.should include 'string'
       vim.feedkeys 'a\<CR>'

-      proposed_indent.should == 0
+      proposed_indent.should == -1

       indent.should == 0
     end
 
       indent.should == 0
     end
 


@@ -464,7 +464,7 @@ shared_examples_for "multiline strings" do
     end
   end
 
     end
   end
 

-  describe "when after assigning an unfinished string" do
+  describe "when after assigning an indented unfinished string" do

     before { vim.feedkeys 'i    test = """' }
 
     it "it indents the next line" do
     before { vim.feedkeys 'i    test = """' }
 
     it "it indents the next line" do


@@ -475,7 +475,7 @@ shared_examples_for "multiline strings" do
     end
   end
 
     end
   end
 

-  describe "when after assigning a finished string" do
+  describe "when after assigning an indented finished string" do

     before { vim.feedkeys 'i    test = ""' }
 
     it "it does indent the next line" do
     before { vim.feedkeys 'i    test = ""' }
 
     it "it does indent the next line" do


@@ -508,12 +508,30 @@ shared_examples_for "multiline strings" do
   end
 
   describe "when breaking a string after opening parenthesis" do
   end
 
   describe "when breaking a string after opening parenthesis" do

-    before { vim.feedkeys 'i    foo("""bar<Left><Left><Left>' }
+    before { vim.feedkeys 'i    foo("""bar\<Left>\<Left>\<Left>' }

     it "it does indent the next line as after an opening multistring" do
       vim.feedkeys '\<CR>'
     it "it does indent the next line as after an opening multistring" do
       vim.feedkeys '\<CR>'

-      expected_proposed, expected_indent = multiline_indent(4, 4 + shiftwidth)
+      _, expected_indent = multiline_indent(4, 4 + shiftwidth)

       indent.should == expected_indent
       indent.should == expected_indent

-      proposed_indent.should == expected_proposed
+      proposed_indent.should == -1
+
+      # it keeps the indent after an empty line
+      vim.feedkeys '\<CR>'
+      proposed_indent, expected_indent = multiline_indent(4, 4 + shiftwidth)
+      indent.should == expected_indent
+      proposed_indent.should == proposed_indent
+
+      # it keeps the indent of nonblank above
+      vim.feedkeys '\<End>\<CR>'
+      proposed_indent, expected_indent = multiline_indent(4, 4 + shiftwidth)
+      indent.should == expected_indent
+      proposed_indent.should == proposed_indent
+
+      # it keeps the indent of nonblank above before an empty line
+      vim.feedkeys '\<CR>'
+      proposed_indent, expected_indent = multiline_indent(4, 4 + shiftwidth)
+      indent.should == expected_indent
+      proposed_indent.should == proposed_indent

     end
   end
 end
     end
   end
 end