Make `is_complex_subscript()` ignore list literals

This fixes catastrophically quadratic behavior on long lists.

diff --git a/README.md b/README.md
index 533a1f82f89e746b7b6540908e44de7215313e04..440f42b19b20c97e0e5b6ee3460b8ef65196c787 100644 (file)
--- a/README.md
+++ b/README.md
@@ -812,6 +812,9 @@ More details can be found in [CONTRIBUTING](CONTRIBUTING.md).
 * fixed improper formatting of f-strings with quotes inside interpolated
   expressions (#322)
 
 * fixed improper formatting of f-strings with quotes inside interpolated
   expressions (#322)
 

+* fixed unnecessary slowdown when long list literals where found in a file
+
+

 ### 18.6b2
 
 * added `--config` (#65)
 ### 18.6b2
 
 * added `--config` (#65)

diff --git a/black.py b/black.py
index 35daaa9d634fa0d0a278014df7277ef56d1af1fc..a405bada1358344db949664afd3e041432554b9f 100644 (file)
--- a/black.py
+++ b/black.py
@@ -1256,18 +1256,18 @@ class Line:
 
     def is_complex_subscript(self, leaf: Leaf) -> bool:
         """Return True iff `leaf` is part of a slice with non-trivial exprs."""
 
     def is_complex_subscript(self, leaf: Leaf) -> bool:
         """Return True iff `leaf` is part of a slice with non-trivial exprs."""

-        open_lsqb = (
-            leaf if leaf.type == token.LSQB else self.bracket_tracker.get_open_lsqb()
-        )
+        open_lsqb = self.bracket_tracker.get_open_lsqb()

         if open_lsqb is None:
             return False
 
         subscript_start = open_lsqb.next_sibling
         if open_lsqb is None:
             return False
 
         subscript_start = open_lsqb.next_sibling

-        if (
-            isinstance(subscript_start, Node)
-            and subscript_start.type == syms.subscriptlist
-        ):
-            subscript_start = child_towards(subscript_start, leaf)
+
+        if isinstance(subscript_start, Node):
+            if subscript_start.type == syms.listmaker:
+                return False
+
+            if subscript_start.type == syms.subscriptlist:
+                subscript_start = child_towards(subscript_start, leaf)

         return subscript_start is not None and any(
             n.type in TEST_DESCENDANTS for n in subscript_start.pre_order()
         )
         return subscript_start is not None and any(
             n.type in TEST_DESCENDANTS for n in subscript_start.pre_order()
         )