Add sanity check to executable CD + more (#3190)

Building executables without any testing is quite sketchy, let's at
least verify they won't crash on startup and format Black's own
codebase.

Also replaced "binaries" with "executables" since it's clearer and
won't be confused with mypyc.

Finally, I added colorama so all Windows users can get colour.

diff --git a/.github/workflows/upload_binary.yml b/.github/workflows/upload_binary.yml
index ed5ed961e672e84ff9f4f2e23b6fe54d3a06405e..22535a64c671aeeb6226311eab2a6b4e48ca3457 100644 (file)
--- a/.github/workflows/upload_binary.yml
+++ b/.github/workflows/upload_binary.yml
@@ -1,16 +1,14 @@
-name: Upload self-contained binaries
+name: Publish executables

 
 on:
   release:
     types: [published]
 
 permissions:
 
 on:
   release:
     types: [published]
 
 permissions:

-  contents: read
+  contents: write # actions/upload-release-asset needs this.

 
 jobs:
   build:
 
 jobs:
   build:

-    permissions:
-      contents: write # for actions/upload-release-asset to upload release asset

     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false


@@ -38,15 +36,21 @@ jobs:
         with:
           python-version: "*"
 
         with:
           python-version: "*"
 

-      - name: Install dependencies
+      - name: Install Black and PyInstaller

         run: |
         run: |

-          python -m pip install --upgrade pip wheel setuptools
-          python -m pip install .
+          python -m pip install --upgrade pip wheel
+          python -m pip install .[colorama]

           python -m pip install pyinstaller
 
           python -m pip install pyinstaller
 

-      - name: Build binary
+      - name: Build executable with PyInstaller
+        run: >
+          python -m PyInstaller -F --name ${{ matrix.asset_name }} --add-data
+          'src/blib2to3${{ matrix.pathsep }}blib2to3' src/black/__main__.py
+
+      - name: Quickly test executable

         run: |
         run: |

-          python -m PyInstaller -F --name ${{ matrix.asset_name }} --add-data 'src/blib2to3${{ matrix.pathsep }}blib2to3' src/black/__main__.py
+          ./dist/${{ matrix.asset_name }} --version
+          ./dist/${{ matrix.asset_name }} src --verbose

 
       - name: Upload binary as release asset
         uses: actions/upload-release-asset@v1
 
       - name: Upload binary as release asset
         uses: actions/upload-release-asset@v1