git.madduck.net Git - etc/vim.git/commit

Every one of the projects in this repository is available at the canonical URL git://git.madduck.net/madduck/pub/<projectpath> — see each project's metadata for the exact URL.

All patches and comments are welcome. Please squash your changes to logical commits before using git-format-patch and git-send-email to patches@git.madduck.net. If you'd read over the Git project's submission guidelines and adhered to them, I'd be especially grateful.

If you use my repositories frequently, consider adding the following snippet to ~/.gitconfig and using the third clone URL listed for each project:

author	Batuhan Taskaya <isidentical@gmail.com>
	Tue, 16 Nov 2021 02:38:40 +0000 (05:38 +0300)
committer	GitHub <noreply@github.com>
	Tue, 16 Nov 2021 02:38:40 +0000 (18:38 -0800)
commit	d7b091e762121ee38ca313ab25006abf4723d203
tree	c7eeeb6b686aef98b263c5bc7612a4f42987bb45	tree \| snapshot
parent	78317a4cfb2cc7958ebd553ff6d7cc1aff0d8296	commit \| diff

black/parser: optimize deepcopying nodes (#2611)

The implementation of the new backtracking logic depends heavily on deepcopying the current state of the parser before seeing one of the new keywords, which by default is an very expensive operations. On my system, formatting these 3 files takes 1.3 seconds.

```
$ touch tests/data/pattern_matching_*; time python -m black -tpy310 tests/data/pattern_matching_*             19ms
All done! ✨ 🍰 ✨
3 files left unchanged.
python -m black -tpy310 tests/data/pattern_matching_*  2,09s user 0,04s system 157% cpu 1,357 total
```

which can be optimized 3X if we integrate the existing copying logic (`clone`) to the deepcopy system;
```
$ touch tests/data/pattern_matching_*; time python -m black -tpy310 tests/data/pattern_matching_*              1ms
All done! ✨ 🍰 ✨
3 files left unchanged.
python -m black -tpy310 tests/data/pattern_matching_*  0,66s user 0,02s system 147% cpu 0,464 total
```

This still might have some potential, but that would be way trickier than this initial patch.

src/blib2to3/pytree.py		diff \| blob \| history
tests/data/pattern_matching_extras.py		diff \| blob \| history

madduck's git repository

Legalese