]> git.madduck.net Git - etc/vim.git/log

madduck's git repository

Every one of the projects in this repository is available at the canonical URL git://git.madduck.net/madduck/pub/<projectpath> — see each project's metadata for the exact URL.

All patches and comments are welcome. Please squash your changes to logical commits before using git-format-patch and git-send-email to patches@git.madduck.net. If you'd read over the Git project's submission guidelines and adhered to them, I'd be especially grateful.

SSH access, as well as push access can be individually arranged.

If you use my repositories frequently, consider adding the following snippet to ~/.gitconfig and using the third clone URL listed for each project:

[url "git://git.madduck.net/madduck/"]
  insteadOf = madduck:

etc/vim.git
8 years agoAdd tests for italic and bold syntax
Hiroshi Shirosaki [Mon, 21 Dec 2015 05:16:05 +0000 (14:16 +0900)]
Add tests for italic and bold syntax

Fix #137

8 years agoDon't interpret escaped _ chars in italics as the end of syntax match
Kevin MacMartin [Fri, 17 Oct 2014 05:57:41 +0000 (01:57 -0400)]
Don't interpret escaped _ chars in italics as the end of syntax match

8 years agoFix code format
Hiroshi Shirosaki [Mon, 21 Dec 2015 02:42:07 +0000 (11:42 +0900)]
Fix code format

8 years agoFix travis script for multiple commands
Hiroshi Shirosaki [Fri, 18 Dec 2015 02:06:59 +0000 (11:06 +0900)]
Fix travis script for multiple commands

8 years agoMerge pull request #237 from shirosaki/doc
Hiroshi Shirosaki [Fri, 18 Dec 2015 02:00:36 +0000 (11:00 +0900)]
Merge pull request #237 from shirosaki/doc

Generate vim help from README.md using vim-tools

8 years agoAdd `make doc` to travis
Hiroshi Shirosaki [Fri, 11 Dec 2015 01:25:03 +0000 (10:25 +0900)]
Add `make doc` to travis

8 years agoGenerate vim help from README.md using vim-tools
Hiroshi Shirosaki [Thu, 10 Dec 2015 08:16:22 +0000 (17:16 +0900)]
Generate vim help from README.md using vim-tools

Add a make rule to generate vim help file.
Tweak vim help using `sed`.
Add doc/vim-markdown.txt to `make install`.

8 years agoRemove spaces as coding style in README.md #213
Hiroshi Shirosaki [Mon, 14 Dec 2015 22:20:28 +0000 (07:20 +0900)]
Remove spaces as coding style in README.md #213

8 years agoAdd tests for preamble fold of python-mode style #213
Hiroshi Shirosaki [Mon, 14 Dec 2015 01:46:13 +0000 (10:46 +0900)]
Add tests for preamble fold of python-mode style #213

8 years agoAdd tests for fold text of python-mode style #213
Hiroshi Shirosaki [Mon, 14 Dec 2015 00:49:13 +0000 (09:49 +0900)]
Add tests for fold text of python-mode style #213

8 years agoMerge pull request #213 from wlonk/python-like
Hiroshi Shirosaki [Mon, 14 Dec 2015 00:47:02 +0000 (09:47 +0900)]
Merge pull request #213 from wlonk/python-like

Add support for python-mode style folding

8 years agoAdd support for python-mode style folding
Kit La Touche [Tue, 12 May 2015 17:17:15 +0000 (11:17 -0600)]
Add support for python-mode style folding

As a python-mode user in my day-to-day work, I would like the folding
styles of vim-markdown and python-mode to match, so that there's less
cognitive overhead in switching between my two most frequently-used
contexts.

To this end, I've made a distinct set of folding logic, keyed off of the
g:vim_markdown_folding_style_pythonic variable, so that using this style
is opt-in.

8 years agoMerge pull request #235 from jirislaby/patch-1
Hiroshi Shirosaki [Wed, 9 Dec 2015 06:47:02 +0000 (15:47 +0900)]
Merge pull request #235 from jirislaby/patch-1

Makefile: support DESTDIR

8 years agoFix directory on travis with TEST=latest
Hiroshi Shirosaki [Wed, 9 Dec 2015 06:18:52 +0000 (15:18 +0900)]
Fix directory on travis with TEST=latest

Fix #143

8 years agoAdd make rule to update dependencies
Hiroshi Shirosaki [Wed, 9 Dec 2015 05:59:33 +0000 (14:59 +0900)]
Add make rule to update dependencies

8 years agoFix travis script to work with make test
Hiroshi Shirosaki [Wed, 9 Dec 2015 05:57:49 +0000 (14:57 +0900)]
Fix travis script to work with make test

Fix #143

8 years agoAdd support for "make test", automatically installing deps
Daniel Hahler [Mon, 17 Nov 2014 13:11:43 +0000 (14:11 +0100)]
Add support for "make test", automatically installing deps

8 years agoMove test/folding.md to test/folding.vader
Hiroshi Shirosaki [Tue, 8 Dec 2015 06:36:34 +0000 (15:36 +0900)]
Move test/folding.md to test/folding.vader

Fix #73

8 years agoLines which start with '-' are needed in foldexpr
Hiroshi Shirosaki [Tue, 8 Dec 2015 05:05:43 +0000 (14:05 +0900)]
Lines which start with '-' are needed in foldexpr

8 years agoadd test file for folding
todesking [Fri, 11 Apr 2014 16:57:42 +0000 (01:57 +0900)]
add test file for folding

8 years agoFoldmethod: more performance
todesking [Mon, 7 Apr 2014 16:06:33 +0000 (01:06 +0900)]
Foldmethod: more performance

8 years agoFoldmethod: improve performance
todesking [Mon, 7 Apr 2014 16:02:51 +0000 (01:02 +0900)]
Foldmethod: improve performance

8 years agoFoldmethod: ignore title-like lines in code block
todesking [Mon, 7 Apr 2014 15:58:30 +0000 (00:58 +0900)]
Foldmethod: ignore title-like lines in code block

8 years agoMakefile: support DESTDIR
Jiri Slaby [Tue, 1 Dec 2015 09:58:00 +0000 (10:58 +0100)]
Makefile: support DESTDIR

DESTDIR is set by distributors when packaging. So to be
able to use make install there, put DESTDIR in from of
PREFIX.

9 years agoFix indent with syntax off
Hiroshi Shirosaki [Mon, 16 Nov 2015 06:43:39 +0000 (15:43 +0900)]
Fix indent with syntax off

Move indent related settings from syntax to index.
Fix #126

9 years agoMerge pull request #230 from cirosantilli/ft-markdown
Ciro Santilli 六四事件 法轮功 包卓轩 [Wed, 4 Nov 2015 13:55:36 +0000 (14:55 +0100)]
Merge pull request #230 from cirosantilli/ft-markdown

Use just markdown as filetype.

9 years agoUse just markdown as filetype.
Ciro Santilli [Tue, 6 Oct 2015 11:26:05 +0000 (13:26 +0200)]
Use just markdown as filetype.

. for multiple filetypes does not work with autocmd.

There seems to be no known workaround:
http://vi.stackexchange.com/questions/4893

This is a breaking change as it would break user scripts
who used autocmd, but we have already broken them
with this compound filetype, so let's just finish the job.

Semi-reverses: https://github.com/plasticboy/vim-markdown/pull/217

9 years agoMerge pull request #229 from yunake/master
Ciro Santilli 六四事件 法轮功 纳米比亚 威视 [Tue, 6 Oct 2015 11:38:04 +0000 (13:38 +0200)]
Merge pull request #229 from yunake/master

Add the indent part of the plugin to the registry

9 years agoadd new indent part of the plugin to the registry
Eugene Yunak [Sun, 4 Oct 2015 00:22:10 +0000 (03:22 +0300)]
add new indent part of the plugin to the registry

9 years agoMerge pull request #221 from yuex/feature/mkd2markdown
Ciro Santilli 六四事件 法轮功 纳米比亚 威视 [Wed, 9 Sep 2015 12:59:07 +0000 (14:59 +0200)]
Merge pull request #221 from yuex/feature/mkd2markdown

swap mkd to markdown

9 years agoswap out mkd, successfully...
Yue Xin [Sun, 16 Aug 2015 11:50:10 +0000 (19:50 +0800)]
swap out mkd, successfully...

Signed-off-by: yuexin <yuecn41@gmail.com>
9 years agoMerge pull request #217 from hori-ryota/feature/fixed-filetype
Ciro Santilli 六四事件 法轮功 纳米比亚 威视 [Sun, 16 Aug 2015 09:54:35 +0000 (11:54 +0200)]
Merge pull request #217 from hori-ryota/feature/fixed-filetype

Use compound filetype for plugins using "markdown"

9 years agoUse compound filetype for plugins using "markdown" filetype
hori-ryota [Wed, 17 Jun 2015 06:42:54 +0000 (15:42 +0900)]
Use compound filetype for plugins using "markdown" filetype

9 years agomailplate shortcuts updated
martin f. krafft [Fri, 5 Jun 2015 06:07:49 +0000 (08:07 +0200)]
mailplate shortcuts updated

9 years agoMerge pull request #191 from sruggier/master
Ciro Santilli 六四事件 法轮功 [Sun, 24 May 2015 21:56:32 +0000 (23:56 +0200)]
Merge pull request #191 from sruggier/master

README.md: add a section about issue reporting

9 years agoCONTRIBUTING.md: add a section about issue reporting
Simon Ruggier [Sun, 24 May 2015 21:37:22 +0000 (17:37 -0400)]
CONTRIBUTING.md: add a section about issue reporting

9 years agoMerge pull request #211 from starcraftman/latest_vim
Ciro Santilli 六四事件 法轮功 [Fri, 15 May 2015 07:06:47 +0000 (09:06 +0200)]
Merge pull request #211 from starcraftman/latest_vim

Build latest vim quickly from git mirror.

9 years agoBuild latest vim quickly from git mirror
Jeremy Pallats/starcraft.man [Mon, 11 May 2015 12:21:51 +0000 (08:21 -0400)]
Build latest vim quickly from git mirror

* Executes test against travis package vim & latest 7.4.x
* Fixes #201

9 years agoMerge pull request #209 from sim590/version-aware-netrw-browsex-call
Ciro Santilli 六四事件 法轮功 [Tue, 5 May 2015 08:40:39 +0000 (10:40 +0200)]
Merge pull request #209 from sim590/version-aware-netrw-browsex-call

Version aware netrw browseX call

9 years agoadding VersionAwareNetrwBrowseX() function for doing right call to netrw browsex
Simon Désaulniers [Mon, 4 May 2015 22:05:41 +0000 (18:05 -0400)]
adding VersionAwareNetrwBrowseX() function for doing right call to netrw browsex

9 years agoMerge pull request #208 from cirosantilli/typo-plugging
Ciro Santilli 六四事件 法轮功 [Mon, 4 May 2015 14:28:27 +0000 (16:28 +0200)]
Merge pull request #208 from cirosantilli/typo-plugging

Fix typo plugging

9 years agoFix typo plugging
Ciro Santilli 六四事件 法轮功 [Mon, 4 May 2015 14:28:03 +0000 (16:28 +0200)]
Fix typo plugging

9 years agoMerge pull request #205 from cirosantilli/readme-gx
Ciro Santilli 六四事件 法轮功 [Mon, 4 May 2015 14:25:43 +0000 (16:25 +0200)]
Merge pull request #205 from cirosantilli/readme-gx

Document <Plug>Markdown_OpenUrlUnderCursor

9 years agoMerge pull request #193 from cirosantilli/toc
Ciro Santilli 六四事件 法轮功 [Mon, 4 May 2015 14:24:39 +0000 (16:24 +0200)]
Merge pull request #193 from cirosantilli/toc

Add TOC to README

9 years agoMerge pull request #207 from cirosantilli/not-hasmapto
Ciro Santilli 六四事件 法轮功 [Mon, 4 May 2015 14:22:48 +0000 (16:22 +0200)]
Merge pull request #207 from cirosantilli/not-hasmapto

Allow users to disable individual maps with hasmapto checks

9 years agoAllow users to disable individual maps with hasmapto checks
Ciro Santilli 六四事件 法轮功 [Mon, 4 May 2015 14:14:30 +0000 (16:14 +0200)]
Allow users to disable individual maps with hasmapto checks

9 years agoDocument <Plug>Markdown_OpenUrlUnderCursor
Ciro Santilli 六四事件 法轮功 [Mon, 4 May 2015 13:35:20 +0000 (15:35 +0200)]
Document <Plug>Markdown_OpenUrlUnderCursor

9 years agoMerge pull request #199 from KazuakiM/master
Hiroshi Shirosaki [Fri, 24 Apr 2015 06:06:24 +0000 (15:06 +0900)]
Merge pull request #199 from KazuakiM/master

Update Markdown_GetUrlForPosition function b: to s:

9 years agoUpdate Markdown_GetUrlForPosition function b: to s:
KazuakiM [Thu, 23 Apr 2015 14:21:11 +0000 (23:21 +0900)]
Update Markdown_GetUrlForPosition function b: to s:

9 years agoAdd TOC to README
Ciro Santilli 六四事件 法轮功 [Fri, 17 Apr 2015 08:12:34 +0000 (10:12 +0200)]
Add TOC to README

9 years agoMerge pull request #184 from cirosantilli/ftplugin-style
Ciro Santilli 六四事件 法轮功 [Thu, 16 Apr 2015 11:59:22 +0000 (13:59 +0200)]
Merge pull request #184 from cirosantilli/ftplugin-style

Improve style of ftplugin/mkd.vim

9 years agoImprove style of ftplugin/mkd.vim
Ciro Santilli 六四事件 法轮功 [Thu, 16 Apr 2015 11:56:12 +0000 (13:56 +0200)]
Improve style of ftplugin/mkd.vim

- remove Markdown_ prefix from s: functions
- always add one empty line between commands and methods

9 years agoMerge pull request #185 from cirosantilli/rm-parenthesis-from-plug
Ciro Santilli 六四事件 法轮功 [Thu, 16 Apr 2015 09:23:02 +0000 (11:23 +0200)]
Merge pull request #185 from cirosantilli/rm-parenthesis-from-plug

Remove parenthesis from <Plug> maps

9 years agoRemove parenthesis from <Plug> maps
Ciro Santilli [Thu, 16 Apr 2015 09:09:58 +0000 (11:09 +0200)]
Remove parenthesis from <Plug> maps

9 years agoMerge pull request #183 from cirosantilli/gx
Ciro Santilli 六四事件 法轮功 [Thu, 16 Apr 2015 08:44:24 +0000 (10:44 +0200)]
Merge pull request #183 from cirosantilli/gx

gx works from anywhere inside Markdown links

9 years agogx works from anywhere inside Markdown links.
Ciro Santilli [Mon, 23 Feb 2015 07:05:46 +0000 (08:05 +0100)]
gx works from anywhere inside Markdown links.

Fix #99.

9 years agoMerge pull request #177 from cirosantilli/readme-h1
Ciro Santilli [Sat, 14 Mar 2015 09:12:55 +0000 (10:12 +0100)]
Merge pull request #177 from cirosantilli/readme-h1

Change the README h1 to "Vim Markdown"

9 years agoMerge pull request #178 from cirosantilli/readme-format
Ciro Santilli [Sat, 14 Mar 2015 09:12:08 +0000 (10:12 +0100)]
Merge pull request #178 from cirosantilli/readme-format

Improve README formatting

9 years agoMerge pull request #37 from dolph/master
Vincent Driessen [Thu, 12 Mar 2015 08:49:34 +0000 (09:49 +0100)]
Merge pull request #37 from dolph/master

Spelling correction

9 years agoSpelling correction
Dolph Mathews [Thu, 12 Mar 2015 04:42:24 +0000 (04:42 +0000)]
Spelling correction

http://english.stackexchange.com/questions/45295/why-is-there-confusion-between-depreciated-and-deprecated

9 years agoMerge pull request #179 from cirosantilli/toc-nomodifiable-test2
Ciro Santilli [Sat, 21 Feb 2015 14:52:02 +0000 (15:52 +0100)]
Merge pull request #179 from cirosantilli/toc-nomodifiable-test2

Add test for Toc nomodifiable #170

9 years agoAdd test for Toc nomodifiable #170
Ciro Santilli [Sat, 21 Feb 2015 10:22:22 +0000 (11:22 +0100)]
Add test for Toc nomodifiable #170

9 years agoChange the README h1 to "Vim Markdown"
Ciro Santilli [Sat, 21 Feb 2015 10:47:02 +0000 (11:47 +0100)]
Change the README h1 to "Vim Markdown"

9 years agoImprove README formatting
Ciro Santilli [Sat, 21 Feb 2015 10:45:50 +0000 (11:45 +0100)]
Improve README formatting

9 years agoMerge pull request #168 from cirosantilli/rm-smartindent
Ciro Santilli [Sat, 21 Feb 2015 10:31:02 +0000 (11:31 +0100)]
Merge pull request #168 from cirosantilli/rm-smartindent

Remove nosmartindent: indentexpr overrules it.

9 years agoMerge pull request #170 from sim590/fix-toc-nomodifiable
Ciro Santilli [Sat, 21 Feb 2015 10:24:22 +0000 (11:24 +0100)]
Merge pull request #170 from sim590/fix-toc-nomodifiable

Prevent setting other buffers to nomodifiable.

Fix #169

9 years agoprevent setting other buffers to nomodifiable
Simon Désaulniers [Mon, 2 Feb 2015 08:06:23 +0000 (03:06 -0500)]
prevent setting other buffers to nomodifiable

9 years agoRemove nosmartindent: indentexpr overrules it.
Ciro Santilli [Sun, 25 Jan 2015 22:38:57 +0000 (23:38 +0100)]
Remove nosmartindent: indentexpr overrules it.

9 years agoMerge pull request #158 from nybblr/nybblr/add-tilde-code-blocks
Ciro Santilli [Fri, 2 Jan 2015 21:26:47 +0000 (22:26 +0100)]
Merge pull request #158 from nybblr/nybblr/add-tilde-code-blocks

Add tilde-fenced code blocks.

9 years agoAdd tilde-fenced code blocks.
Jonathan Martin [Fri, 2 Jan 2015 21:14:06 +0000 (16:14 -0500)]
Add tilde-fenced code blocks.

9 years agoMerge pull request #151 from cirosantilli/use-default-foldelvel-mechanism
Ciro Santilli [Sun, 21 Dec 2014 09:38:06 +0000 (10:38 +0100)]
Merge pull request #151 from cirosantilli/use-default-foldelvel-mechanism

Remove automatic setting of foldlevel

9 years agoAdd explicit path, for clarity.
Vincent Driessen [Mon, 15 Dec 2014 08:34:22 +0000 (09:34 +0100)]
Add explicit path, for clarity.

9 years agoAdd more explicit log.
Vincent Driessen [Mon, 15 Dec 2014 08:31:29 +0000 (09:31 +0100)]
Add more explicit log.

9 years agoFix whitespacing.
Vincent Driessen [Mon, 15 Dec 2014 08:31:23 +0000 (09:31 +0100)]
Fix whitespacing.

9 years agoMerge branch 'master' into tabac-master
Vincent Driessen [Mon, 15 Dec 2014 08:26:41 +0000 (09:26 +0100)]
Merge branch 'master' into tabac-master

9 years agoAdd 1.6 release log.
Vincent Driessen [Mon, 15 Dec 2014 08:19:16 +0000 (09:19 +0100)]
Add 1.6 release log.

9 years agoUse HTTS URLs.
Vincent Driessen [Mon, 15 Dec 2014 08:19:01 +0000 (09:19 +0100)]
Use HTTS URLs.

9 years agoadd deprecation messages for flake8 settings
Nic West [Sun, 14 Dec 2014 13:30:59 +0000 (13:30 +0000)]
add deprecation messages for flake8 settings

9 years agoadd option for customizing quickfix window height
Tasos Bakogiannis [Sun, 14 Dec 2014 13:04:47 +0000 (15:04 +0200)]
add option for customizing quickfix window height

9 years agoremove commmand settings from config options
Nic West [Sat, 13 Dec 2014 11:00:40 +0000 (11:00 +0000)]
remove commmand settings from config options

9 years agoRemove automatic setting of foldlevel
Ciro Santilli [Sun, 7 Dec 2014 18:52:06 +0000 (19:52 +0100)]
Remove automatic setting of foldlevel

Vim already has a well known way of dealing with this:
let's not create another configuration which only raises
the entry barrier.

9 years agoMerge pull request #150 from cirosantilli/undo-nore
Ciro Santilli [Sun, 7 Dec 2014 17:52:29 +0000 (18:52 +0100)]
Merge pull request #150 from cirosantilli/undo-nore

Undo noremap, add header map tests

9 years agoUndo noremap, add header map tests
Ciro Santilli [Sun, 7 Dec 2014 17:44:59 +0000 (18:44 +0100)]
Undo noremap, add header map tests

Reverts #141 which @cirosantilli wrongfully merged.

Add regression tests that would have prevented that.

Correction pointed out by @shanesmith at #147.

9 years agoMerge pull request #31 from amacfie/patch-1
Vincent Driessen [Wed, 3 Dec 2014 18:07:56 +0000 (19:07 +0100)]
Merge pull request #31 from amacfie/patch-1

Correct minor typo: "highligth" -> "highlight"

9 years agoCorrect minor typo: "highligth" -> "highlight"
Andrew MacFie [Wed, 3 Dec 2014 16:25:31 +0000 (11:25 -0500)]
Correct minor typo: "highligth" -> "highlight"

9 years agoUse simplified BSD license.
Vincent Driessen [Sun, 30 Nov 2014 08:47:26 +0000 (09:47 +0100)]
Use simplified BSD license.

9 years agoAdd BSD license.
Vincent Driessen [Sun, 30 Nov 2014 07:16:12 +0000 (08:16 +0100)]
Add BSD license.

10 years agoMerge pull request #141 from blueyed/use-noremap
Ciro Santilli [Fri, 21 Nov 2014 08:25:04 +0000 (00:25 -0800)]
Merge pull request #141 from blueyed/use-noremap

Use `noremap` for mappings

10 years agoUse `noremap` for mappings
Daniel Hahler [Sun, 16 Nov 2014 17:27:10 +0000 (18:27 +0100)]
Use `noremap` for mappings

10 years agoMerge pull request #28 from eistaa/master
Vincent Driessen [Sat, 25 Oct 2014 18:02:22 +0000 (20:02 +0200)]
Merge pull request #28 from eistaa/master

Additions

10 years agochange F8 to mtfk identity
martin f. krafft [Fri, 17 Oct 2014 13:25:50 +0000 (15:25 +0200)]
change F8 to mtfk identity

10 years agoMerge pull request #135 from cirosantilli/paren2
Ciro Santilli [Mon, 6 Oct 2014 10:34:54 +0000 (12:34 +0200)]
Merge pull request #135 from cirosantilli/paren2

Fix () [] were rendered as links when not in link 2

10 years agoFix () [] were rendered as links when not in link
Ciro Santilli [Mon, 6 Oct 2014 10:27:28 +0000 (12:27 +0200)]
Fix () [] were rendered as links when not in link

10 years agoMerge pull request #121 from cirosantilli/autolink
Ciro Santilli [Mon, 6 Oct 2014 10:05:22 +0000 (12:05 +0200)]
Merge pull request #121 from cirosantilli/autolink

Highlight angle braced hyperlinks.

10 years agoMerge pull request #132 from cirosantilli/update-syn-header
Ciro Santilli [Mon, 6 Oct 2014 10:03:23 +0000 (12:03 +0200)]
Merge pull request #132 from cirosantilli/update-syn-header

Remove outdated fields from syntax header.

10 years agoMerge pull request #133 from cirosantilli/better-bold-italic-test
Ciro Santilli [Mon, 6 Oct 2014 10:02:52 +0000 (12:02 +0200)]
Merge pull request #133 from cirosantilli/better-bold-italic-test

Improve bold and italic tests.

10 years agoMerge pull request #134 from cirosantilli/readme-uniform-codeblocks
Ciro Santilli [Mon, 6 Oct 2014 10:02:20 +0000 (12:02 +0200)]
Merge pull request #134 from cirosantilli/readme-uniform-codeblocks

Use a single code block style on README.

10 years agoMerge pull request #131 from bjpbakker/master
Ciro Santilli [Fri, 3 Oct 2014 20:48:40 +0000 (22:48 +0200)]
Merge pull request #131 from bjpbakker/master

Respect global fold config

10 years agoRespect Vim's global fold config
Bart Bakker [Fri, 3 Oct 2014 14:44:34 +0000 (16:44 +0200)]
Respect Vim's global fold config

Deleted overriding global fold configuration for markdown buffers and
improved README on purpose of vim_markdown_folding_disabled.

10 years agoHighlight angle braced hyperlinks.
Ciro Santilli [Fri, 5 Sep 2014 23:17:14 +0000 (01:17 +0200)]
Highlight angle braced hyperlinks.

Also fix autolinks without angle braces which
were not being highlighted on top level.