]> git.madduck.net Git - etc/vim.git/log

madduck's git repository

Every one of the projects in this repository is available at the canonical URL git://git.madduck.net/madduck/pub/<projectpath> — see each project's metadata for the exact URL.

All patches and comments are welcome. Please squash your changes to logical commits before using git-format-patch and git-send-email to patches@git.madduck.net. If you'd read over the Git project's submission guidelines and adhered to them, I'd be especially grateful.

SSH access, as well as push access can be individually arranged.

If you use my repositories frequently, consider adding the following snippet to ~/.gitconfig and using the third clone URL listed for each project:

[url "git://git.madduck.net/madduck/"]
  insteadOf = madduck:

etc/vim.git
5 years agofix some out-of-date docstrings; other cleanup (#865)
Jelle Zijlstra [Sun, 26 May 2019 10:09:11 +0000 (03:09 -0700)]
fix some out-of-date docstrings; other cleanup (#865)

5 years agoDocument cache location configuration (#866)
Yngve Høiseth [Sun, 26 May 2019 10:08:22 +0000 (12:08 +0200)]
Document cache location configuration (#866)

5 years agoDocument the need to enter the virtual environment shell (#868)
Yngve Høiseth [Sun, 26 May 2019 09:58:29 +0000 (11:58 +0200)]
Document the need to enter the virtual environment shell (#868)

5 years agoDon't introduce quotes to f-string sub-expressions on string boundaries (#871)
Zsolt Dollenstein [Sun, 26 May 2019 09:58:00 +0000 (11:58 +0200)]
Don't introduce quotes to f-string sub-expressions on string boundaries (#871)

5 years agobump Pipfile.lock
Zsolt Dollenstein [Sun, 26 May 2019 09:45:47 +0000 (11:45 +0200)]
bump Pipfile.lock

5 years agominor performance improvement (~2% speedup in unit tests) (#858)
Michael Flaxman [Wed, 22 May 2019 03:02:17 +0000 (22:02 -0500)]
minor performance improvement (~2% speedup in unit tests) (#858)

5 years agoAdd doc clarifying that there is no blackd client (#859)
Stephen Rosen [Mon, 20 May 2019 17:57:09 +0000 (13:57 -0400)]
Add doc clarifying that there is no blackd client (#859)

Resolves #854

The first sentence of this is pretty uncontroversial. (Though I wasn't
sure exactly where in the text to put it.)
I thought it would also be nice to show the `curl` test with a tiny
statement that actually reformats.

5 years agoRemove happiness of error message (#852)
Katie McLaughlin [Thu, 16 May 2019 12:02:17 +0000 (22:02 +1000)]
Remove happiness of error message (#852)

5 years agoremove obviously unnecessary parentheses (#850)
Jelle Zijlstra [Thu, 16 May 2019 04:11:04 +0000 (21:11 -0700)]
remove obviously unnecessary parentheses (#850)

Fixes #548

5 years agoMention support for async generators
Łukasz Langa [Thu, 9 May 2019 16:19:33 +0000 (18:19 +0200)]
Mention support for async generators

5 years agoChange log wording and ordering
Łukasz Langa [Thu, 9 May 2019 16:18:10 +0000 (18:18 +0200)]
Change log wording and ordering

5 years agoacks += bgw
Łukasz Langa [Thu, 9 May 2019 16:04:09 +0000 (18:04 +0200)]
acks += bgw

5 years agoMove tokenizer config onto grammar, rename flag
Benjamin Woodruff [Wed, 8 May 2019 20:38:38 +0000 (16:38 -0400)]
Move tokenizer config onto grammar, rename flag

Based on the feedback in
https://github.com/python/black/pull/845#issuecomment-490622711

- Remove TokenizerConfig, and add a field to Grammar instead.
- Pass the Grammar to the tokenizer.
- Rename `ASYNC_IS_RESERVED_KEYWORD` to `ASYNC_KEYWORDS` and
  `ASYNC_IS_VALID_IDENTIFIER` to `ASYNC_IDENTIFIERS`.

5 years agoAdd support for always tokenizing async/await as keywords
Benjamin Woodruff [Wed, 8 May 2019 19:06:44 +0000 (15:06 -0400)]
Add support for always tokenizing async/await as keywords

Fixes #593

I looked into this bug with @ambv and @carljm, and we reached the
conclusion was that it's not possible for the tokenizer to determine if
async/await is a keyword inside all possible generators without breaking
the grammar for older versions of Python.

Instead, we introduce a new tokenizer mode for Python 3.7+ that will
cause all async/await instances to get parsed as a reserved keyword,
which should fix async/await inside generators.

5 years agoacks += revfried
Łukasz Langa [Thu, 9 May 2019 15:08:31 +0000 (17:08 +0200)]
acks += revfried

5 years agoMention fix for backslashes before standalone comments
Łukasz Langa [Thu, 9 May 2019 15:07:06 +0000 (17:07 +0200)]
Mention fix for backslashes before standalone comments

5 years agoRemove spurious prints
Łukasz Langa [Thu, 9 May 2019 02:49:48 +0000 (04:49 +0200)]
Remove spurious prints

5 years agoUse to handle legacy async/await handling in assert_equivalent
Łukasz Langa [Wed, 8 May 2019 21:33:39 +0000 (23:33 +0200)]
Use  to handle legacy async/await handling in assert_equivalent

5 years agoAdd PyCon talk link to README (#844)
Carol Willing [Wed, 8 May 2019 18:52:41 +0000 (11:52 -0700)]
Add PyCon talk link to README (#844)

5 years agoMake --safe work for Python2.7 syntax, by using typed_ast for safe validation (#840)
Jason Fried [Wed, 8 May 2019 14:45:59 +0000 (10:45 -0400)]
Make --safe work for Python2.7 syntax, by using typed_ast for safe validation (#840)

5 years agoAvoid unstable formatting when comment follows escaped newline. (#839). Fixes #767.
Carl Meyer [Wed, 8 May 2019 13:53:20 +0000 (09:53 -0400)]
Avoid unstable formatting when comment follows escaped newline. (#839). Fixes #767.

5 years agoMinor README updates (#842)
Hugo [Wed, 8 May 2019 13:06:19 +0000 (16:06 +0300)]
Minor README updates (#842)

* Header in sentence case, for consistency

* Black in italics

5 years agoMention Elpy
Łukasz Langa [Tue, 7 May 2019 20:16:29 +0000 (22:16 +0200)]
Mention Elpy

Fixes #689

5 years agohumility -= 1
Łukasz Langa [Tue, 7 May 2019 18:29:31 +0000 (20:29 +0200)]
humility -= 1

5 years agoUse g:pymode_python-defined interpreter if defined and exists, otherwise use existing...
pmacosta [Tue, 7 May 2019 17:28:56 +0000 (13:28 -0400)]
Use g:pymode_python-defined interpreter if defined and exists, otherwise use existing defaults (#666)

This is helpful when using custom-compiled interpreters, or alternative
Python interpreters in non-standard locations

5 years agodon't run more than 61 workers on Windows (#838)
Jelle Zijlstra [Tue, 7 May 2019 17:11:20 +0000 (13:11 -0400)]
don't run more than 61 workers on Windows (#838)

5 years agoDescribe how to add black to Wing IDE (#758)
Arjaan Buijk [Tue, 7 May 2019 14:17:00 +0000 (10:17 -0400)]
Describe how to add black to Wing IDE (#758)

5 years agoAdd `black -c "code"` (#761)
Jelle Zijlstra [Tue, 7 May 2019 13:58:59 +0000 (09:58 -0400)]
Add `black -c "code"` (#761)

5 years agoRemove deprecated license_file from setup.cfg (#825)
Jon Dufresne [Tue, 7 May 2019 13:57:44 +0000 (06:57 -0700)]
Remove deprecated license_file from setup.cfg (#825)

Starting with wheel 0.32.0 (2018-09-29), the "license_file" option is
deprecated.

https://wheel.readthedocs.io/en/stable/news.html

The wheel will continue to include LICENSE, it is now included
automatically:

https://wheel.readthedocs.io/en/stable/user_guide.html#including-license-files-in-the-generated-wheel-file

5 years agoadd to changelog
Jelle Zijlstra [Tue, 7 May 2019 13:52:41 +0000 (09:52 -0400)]
add to changelog

5 years agoAdd parentheses around tuple unpack assignment (#832)
Jelle Zijlstra [Tue, 7 May 2019 13:51:28 +0000 (09:51 -0400)]
Add parentheses around tuple unpack assignment (#832)

Fixes #656

5 years agoRemove unnecessary parens around yield (#834)
Jelle Zijlstra [Tue, 7 May 2019 13:49:50 +0000 (09:49 -0400)]
Remove unnecessary parens around yield (#834)

5 years agoUpdate calver version number (#835)
Hugo [Tue, 7 May 2019 02:02:09 +0000 (05:02 +0300)]
Update calver version number (#835)

If released this month, it will be 19.5b0.

5 years agoadd to CHANGELOG
Jelle Zijlstra [Mon, 6 May 2019 15:09:04 +0000 (11:09 -0400)]
add to CHANGELOG

5 years agofix handling of comments in from imports (#829)
Jelle Zijlstra [Mon, 6 May 2019 13:13:25 +0000 (09:13 -0400)]
fix handling of comments in from imports (#829)

Fixes #671

5 years agoWrap `loop.run_in_executor` up in `asyncio.ensure_future` for reliable cross-platform...
Tom Christie [Sun, 5 May 2019 18:58:26 +0000 (19:58 +0100)]
Wrap `loop.run_in_executor` up in `asyncio.ensure_future` for reliable cross-platform berhavior. (#679)

Closes #494

Task completion should also remove the task from `pending`.

Only replicates on some platforms. (eg. Can replicate on Python 3.7+, with either Windows or whatever default Linux distro Travis uses.)

5 years agoambv/black -> python/black (#819)
Hugo [Thu, 2 May 2019 19:19:52 +0000 (22:19 +0300)]
ambv/black -> python/black (#819)

5 years agoFix B011 (#820)
Hugo [Thu, 2 May 2019 19:09:49 +0000 (22:09 +0300)]
Fix B011 (#820)

Do not call assert False since python -O removes these calls. Instead callers should raise AssertionError().

5 years agominor: remove wrong comment in .flake8 (#788)
Daniel Hahler [Thu, 2 May 2019 17:03:02 +0000 (19:03 +0200)]
minor: remove wrong comment in .flake8 (#788)

This is there since the initial commit, which did not have a setup.cfg.

5 years agoSplit the TRAILING_COMMA feature (#763)
Jelle Zijlstra [Mon, 25 Mar 2019 15:22:02 +0000 (08:22 -0700)]
Split the TRAILING_COMMA feature (#763)

5 years agoTerget version option kebab-style (#770)
Daniele Esposti [Wed, 20 Mar 2019 15:40:01 +0000 (15:40 +0000)]
Terget version option kebab-style (#770)

5 years agofix vim plugin for 19.3b0 (#755) (#766)
Thom Lu [Sun, 17 Mar 2019 16:27:50 +0000 (11:27 -0500)]
fix vim plugin for 19.3b0 (#755) (#766)

5 years agoredo grammar selection, add test (#765)
Jelle Zijlstra [Sat, 16 Mar 2019 18:35:18 +0000 (11:35 -0700)]
redo grammar selection, add test (#765)

5 years agofix appveyor deploy section
Zsolt Dollenstein [Sat, 16 Mar 2019 16:26:50 +0000 (16:26 +0000)]
fix appveyor deploy section

5 years agoUse new github token for appveyor release
Zsolt Dollenstein [Sat, 16 Mar 2019 14:00:59 +0000 (14:00 +0000)]
Use new github token for appveyor release

5 years agoadd change log entry (#764)
Jelle Zijlstra [Fri, 15 Mar 2019 18:42:24 +0000 (11:42 -0700)]
add change log entry (#764)

5 years agofix incorrect call (#762)
Jelle Zijlstra [Fri, 15 Mar 2019 17:39:08 +0000 (10:39 -0700)]
fix incorrect call (#762)

5 years agoFix print() function on Python 2 (#754)
Andy Freeland [Thu, 14 Mar 2019 23:42:54 +0000 (16:42 -0700)]
Fix print() function on Python 2 (#754)

Fixes #752

5 years agov19.3b0
Łukasz Langa [Thu, 14 Mar 2019 17:09:10 +0000 (18:09 +0100)]
v19.3b0

5 years agoAdd back --py36 as a deprecated option (#750)
Jelle Zijlstra [Thu, 14 Mar 2019 16:31:27 +0000 (09:31 -0700)]
Add back --py36 as a deprecated option (#750)

This partially reverts commit 21ab37a5d92c866a289320cba7c4689df70b3342.

5 years agoMention tab comment fixes, extend tests
Łukasz Langa [Thu, 14 Mar 2019 16:08:45 +0000 (17:08 +0100)]
Mention tab comment fixes, extend tests

5 years agoMention atomic cache creation in the change log
Łukasz Langa [Thu, 14 Mar 2019 15:40:31 +0000 (16:40 +0100)]
Mention atomic cache creation in the change log

5 years agoIndicate that PyCharm instructions also work with IntelliJ (#681)
Greg Gandenberger [Thu, 14 Mar 2019 16:16:40 +0000 (11:16 -0500)]
Indicate that PyCharm instructions also work with IntelliJ (#681)

* Indicate that PyCharm instructions also work with IntelliJ

* Update README.md

5 years agoUpdate README.md - Pycharm instructions not working for files path containing white...
Heaford [Thu, 14 Mar 2019 16:10:49 +0000 (16:10 +0000)]
Update README.md - Pycharm instructions not working for files path containing white spaces (#659)

5 years agoMention fix for #632 in the change log
Łukasz Langa [Thu, 14 Mar 2019 15:34:40 +0000 (16:34 +0100)]
Mention fix for #632 in the change log

5 years agoEnhance the type comment patch
Łukasz Langa [Thu, 14 Mar 2019 15:26:06 +0000 (16:26 +0100)]
Enhance the type comment patch

5 years agoFix PyCharm instructions in README (#701)
Russell Davis [Thu, 14 Mar 2019 12:45:38 +0000 (05:45 -0700)]
Fix PyCharm instructions in README (#701)

Without this change, PyCharm won't refresh the file in the editor after Black runs.

5 years agoFix PendingDeprecationWarning: Task.all_tasks() is deprecated, use asyncio.all_tasks...
Hugo [Thu, 14 Mar 2019 12:41:42 +0000 (14:41 +0200)]
Fix PendingDeprecationWarning: Task.all_tasks() is deprecated, use asyncio.all_tasks() instead (#741)

5 years agoUpdates to the change log
Łukasz Langa [Thu, 14 Mar 2019 12:25:46 +0000 (13:25 +0100)]
Updates to the change log

5 years agoSimplify the #606 patch
Łukasz Langa [Thu, 14 Mar 2019 12:18:12 +0000 (13:18 +0100)]
Simplify the #606 patch

Thanks for the original patch to solve #509, @hauntsaninja.

5 years agoChanges default logger used by blib2to3 Driver (#732)
Anders-Petter Ljungquist [Thu, 14 Mar 2019 12:39:42 +0000 (13:39 +0100)]
Changes default logger used by blib2to3 Driver (#732)

... to stop it from spamming the log when black is used as a library in another
    python application.

When used indirectly by black the logger initiated in `driver.py` will emit
thousands of debug messages making the debug level of the root logger virtually
useless. By getting a named logger instead the verbosity of logging from this
module can easily be controlled by setting its log level.

Fixes #715

5 years agoUpdate Pipfile environment
Łukasz Langa [Thu, 14 Mar 2019 12:17:34 +0000 (13:17 +0100)]
Update Pipfile environment

5 years agoAdd pip-wheel-metadata/ to ignores
Łukasz Langa [Thu, 14 Mar 2019 12:16:36 +0000 (13:16 +0100)]
Add pip-wheel-metadata/ to ignores

5 years agoremove Python implementation-specific versions (#736)
Jelle Zijlstra [Fri, 8 Mar 2019 00:34:34 +0000 (16:34 -0800)]
remove Python implementation-specific versions (#736)

5 years agoPut cursor in last line if old position is invalid (#641)
Sami Salonen [Thu, 7 Mar 2019 03:34:17 +0000 (05:34 +0200)]
Put cursor in last line if old position is invalid (#641)

5 years agoremove --py36 (#724)
Jelle Zijlstra [Sun, 24 Feb 2019 17:15:03 +0000 (09:15 -0800)]
remove --py36 (#724)

Fixes #703.

5 years ago split long del statements into multiple lines (#698)
Jelle Zijlstra [Sat, 23 Feb 2019 06:00:40 +0000 (22:00 -0800)]
 split long del statements into multiple lines (#698)

Fixes #693

5 years agoFix example with well formated code (add missing comma) (#720)
programmer04 [Wed, 20 Feb 2019 19:11:14 +0000 (20:11 +0100)]
Fix example with well formated code (add missing comma) (#720)

5 years agoImprove examples to use 88 chars line length (#677) (#714)
sponsfreixes [Sat, 16 Feb 2019 06:18:58 +0000 (22:18 -0800)]
Improve examples to use 88 chars line length (#677) (#714)

The examples were wrapping at less than 88 characters, which is not the
default for black.

5 years agoadd missing aiohttp dep (#699)
Jelle Zijlstra [Thu, 14 Feb 2019 20:23:56 +0000 (12:23 -0800)]
add missing aiohttp dep (#699)

add missing aiohttp dep

Also mark 3.8 as allowed to fail for now; it will fail due to an aiohttp bug.

Fixes #690

5 years agoAdd PyCharm setup step (#680)
Greg Gandenberger [Thu, 14 Feb 2019 01:41:58 +0000 (19:41 -0600)]
Add PyCharm setup step (#680)

5 years agoRemove numeric underscore normalization (#696)
Zsolt Dollenstein [Thu, 7 Feb 2019 03:16:49 +0000 (03:16 +0000)]
Remove numeric underscore normalization (#696)

5 years agoAdd `--target-version` option to allow users to choose targeted Python versions ...
Jelle Zijlstra [Thu, 7 Feb 2019 02:43:50 +0000 (18:43 -0800)]
Add `--target-version` option to allow users to choose targeted Python versions (#618)

5 years ago'sudo: required' no longer required https://blog.travis-ci.com/2018-11-19-required...
Hugo [Wed, 6 Feb 2019 16:07:31 +0000 (18:07 +0200)]
'sudo: required' no longer required https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration (#694)

5 years agoProperly close the code block in README (#695)
Jakub Kadlubiec [Wed, 6 Feb 2019 16:05:40 +0000 (17:05 +0100)]
Properly close the code block in README (#695)

5 years agoshow how to exclude individual files in the exclude example (#663)
Nathan Goldbaum [Tue, 5 Feb 2019 18:50:59 +0000 (12:50 -0600)]
show how to exclude individual files in the exclude example (#663)

* show how to exclude individual files in the exclude example

* include comments in the regex

5 years agoUpdate readthedocs.yml (#611)
Kyle Sunden [Tue, 5 Feb 2019 03:12:51 +0000 (21:12 -0600)]
Update readthedocs.yml (#611)

I'm pretty sure the name shouldn't be 'jupyterhub'

5 years agoFormat pyi files correctly (#599)
Bryan Forbes [Tue, 5 Feb 2019 03:08:06 +0000 (21:08 -0600)]
Format pyi files correctly (#599)

5 years agoFix indent calculation with tabs when computing prefixes (#595)
Samuel Cormier-Iijima [Tue, 5 Feb 2019 02:55:01 +0000 (21:55 -0500)]
Fix indent calculation with tabs when computing prefixes (#595)

Closes #262

5 years agoFix location of expression.diff in the change notification message (#670)
Jan Hnátek [Tue, 5 Feb 2019 02:42:42 +0000 (03:42 +0100)]
Fix location of expression.diff in the change notification message (#670)

5 years agochore: Fix noqa comment (#684)
Jimmy Jia [Tue, 29 Jan 2019 21:46:19 +0000 (16:46 -0500)]
chore: Fix noqa comment (#684)

Omitting the colon makes Flake8 ignore all errors, rather than the specific code.

5 years agoAtomically write cache files (#674)
Anthony Sottile [Sat, 19 Jan 2019 04:59:17 +0000 (20:59 -0800)]
Atomically write cache files (#674)

5 years agoTurn off pre-commit's automatic parallelization for black (#675)
Anthony Sottile [Fri, 18 Jan 2019 20:52:56 +0000 (12:52 -0800)]
Turn off pre-commit's automatic parallelization for black (#675)

black internally uses multiprocessing for speed.  In pre-commit 1.13.0 this is automated by the framework itself however if both pre-commit and black are forking processes this is slower and hits race-conditions in `black`.

5 years agodelete some dead code (#669)
Anthony Sottile [Sat, 12 Jan 2019 17:23:20 +0000 (09:23 -0800)]
delete some dead code (#669)

dead code detected via [dead](https://github.com/asottile/dead)

- **`KEYWORDS`**: introduced (unreferenced) in e74117f172e29e8a980e2c9de929ad50d3769150
- **`FLOW_CONTROL`**: last referenced in e9a940d69e789ce8caf1f3c1ded786dc102df2fd

"clean" command:

```
dead --exclude '^(tests/data/|docs/conf.py|blib2to3/)' | grep -Ev '^(visit_.*|show|_stop_signal|lib2to3_unparse) '
```

5 years agoAdd support for special comments in multiline functions (#642)
Utsav Shah [Sat, 5 Jan 2019 19:20:12 +0000 (11:20 -0800)]
Add support for special comments in multiline functions (#642)

5 years agoREADME.md: fix mailto link (#660)
Kenyon Ralph [Sat, 5 Jan 2019 18:46:07 +0000 (10:46 -0800)]
README.md: fix mailto link (#660)

5 years agoImprove an error message when failed to load pyproject.toml (#653)
Tsuyoshi Hombashi [Mon, 31 Dec 2018 13:03:31 +0000 (22:03 +0900)]
Improve an error message when failed to load pyproject.toml (#653)

5 years agoFix multiprocessing support for Windows binary (#632)
Peter Stensmyr [Fri, 14 Dec 2018 15:01:50 +0000 (02:01 +1100)]
Fix multiprocessing support for Windows binary (#632)

* Fix multiprocessing support for Windows binary

The black and blackd binaries generated for Windows builds would fail on
reformatting multiple files due to a Windows-specific
multiprocessing issue. Fix by calling freeze_support() as
described in Python docs.

5 years agoAdd CORS support to blackd (#627)
Tushar Chandra [Mon, 10 Dec 2018 08:15:57 +0000 (02:15 -0600)]
Add CORS support to blackd (#627)

See issue #622. Use aiohttp-cors to allow cross-origin requests to blackd,
and add a dependency on it to the pipfile.

5 years agoAdd .eggs to default exclusions (#629)
Jim Brännlund [Thu, 29 Nov 2018 22:27:08 +0000 (23:27 +0100)]
Add .eggs to default exclusions (#629)

5 years agoSilence expected stderr (#621)
Jim Brännlund [Thu, 29 Nov 2018 21:43:22 +0000 (22:43 +0100)]
Silence expected stderr (#621)

* Silence expected stderr output during test

* Change based on PR comment

5 years agoReflect renaming of IPython notebook to Jupyter (#616)
Scott Stevenson [Fri, 23 Nov 2018 06:08:20 +0000 (06:08 +0000)]
Reflect renaming of IPython notebook to Jupyter (#616)

5 years agoAdd url to pep 257 in readme (#615)
Timo [Fri, 23 Nov 2018 06:07:08 +0000 (07:07 +0100)]
Add url to pep 257 in readme (#615)

5 years agoRefactor Travis (#614)
Jelle Zijlstra [Tue, 20 Nov 2018 16:42:43 +0000 (08:42 -0800)]
Refactor Travis (#614)

Fixes #305

- Run separate jobs for mypy, self-formatting, flake8, and test runs.
- Don't run flake8 in 3.8 because it is broken (and we can't really expect flake8 to always keep up with 3.8 development).
- Fix unused variable in test

5 years agoImproves performance on large commented logical lines (#606)
hauntsaninja [Tue, 13 Nov 2018 23:04:27 +0000 (15:04 -0800)]
Improves performance on large commented logical lines (#606)

Fixes #509

5 years agoFix two types to be Optional (#607)
hauntsaninja [Tue, 13 Nov 2018 23:02:27 +0000 (15:02 -0800)]
Fix two types to be Optional (#607)

5 years agoremove unused variable (#604)
Jelle Zijlstra [Tue, 13 Nov 2018 21:23:56 +0000 (13:23 -0800)]
remove unused variable (#604)

5 years agoUpdate isort config to use_parentheses instead of combine_as_imports (#547)
Calum Lind [Thu, 8 Nov 2018 10:54:05 +0000 (10:54 +0000)]
Update isort config to use_parentheses instead of combine_as_imports (#547)

The `combine_as_imports=True` modifies isort style as a side-effect and was not the intended purpose of the suggested change in #250. The problem was that isort was actually replacing the parens with backslash and using `combine_as_imports=True` happened to also produce the same result.

The actual setting should be `use_parentheses` as this tells isort to use parenthesis for line continuation instead of \ for lines over the allotted line length limit and matches precisely what black is outputting.

6 years agoset entry to black (#553)
jgirardet [Mon, 29 Oct 2018 10:17:37 +0000 (11:17 +0100)]
set entry to black (#553)

6 years agopatch main to ensure click_patch() gets called (#572)
Chuck Wooters [Mon, 29 Oct 2018 10:10:32 +0000 (03:10 -0700)]
patch main to ensure click_patch() gets called (#572)