All patches and comments are welcome. Please squash your changes to logical
commits before using git-format-patch and git-send-email to
patches@git.madduck.net.
If you'd read over the Git project's submission guidelines and adhered to them,
I'd be especially grateful.
madduck suggested that mr register should register to the closest
mrconfig file. This branch is a start at trying to do that, by redefining
MR_CONFIG to hold either the config file that registers the given repo,
or for unregistered repos, the closest mrconfig file
Current issues:
- absolute path is always passed in MR_CONFIG, which makes mr config
add new repos with absolute paths
- MR_CONFIG is not set to the closest mrconfig file for unregistered repos
yet. The problem is, if I do this, then it will override the setting
from -c, and so it won't be possible to use mr register to register in an
explicitly specified config file.
I think it also has some other bugs. For example, the current mapping
between directory and config file only allows for one config file in a given
directory. Which might not be true if you're using mr -c.
As far as I can take it for now, so stashing away in this branch.
"$@". The "checkout" command is run in the parent of the repository
directory, since the repository isn't checked out yet. All other commands
are run inside the repository, though not necessarily at the top of it.
"$@". The "checkout" command is run in the parent of the repository
directory, since the repository isn't checked out yet. All other commands
are run inside the repository, though not necessarily at the top of it.
The "MR_REPO" environment variable is set to the path to the top of the
The "MR_REPO" environment variable is set to the path to the top of the
-repository, and "MR_CONFIG" is set to the topmost .mrconfig file used.
+repository, and "MR_CONFIG" is set to the .mrconfig file that defines the
+repo being acted on, or, if the repo is not yet in a config file, the
+.mrconfig file that mr thinks it should be added to.
A few parameters have special meanings:
A few parameters have special meanings:
my $stats=0;
my $no_recurse=0;
my %config;
my $stats=0;
my $no_recurse=0;
my %config;
my %knownactions;
my %alias;
my %knownactions;
my %alias;
sub action { #{{{
my ($action, $dir, $topdir, $subdir) = @_;
sub action { #{{{
my ($action, $dir, $topdir, $subdir) = @_;
-
- my $lib= exists $config{$topdir}{$subdir}{lib} ?
- $config{$topdir}{$subdir}{lib}."\n" : "";
+
+ $ENV{MR_CONFIG}=$configfiles{$topdir};
+ my $lib=exists $config{$topdir}{$subdir}{lib} ?
+ $config{$topdir}{$subdir}{lib}."\n" : "";
if (exists $config{$topdir}{$subdir}{deleted}) {
my $test="set -e;".$lib.$config{$topdir}{$subdir}{deleted};
if (exists $config{$topdir}{$subdir}{deleted}) {
my $test="set -e;".$lib.$config{$topdir}{$subdir}{deleted};
else {
$config{$dir}{$section}{$parameter}=$value;
$knownactions{$parameter}=1;
else {
$config{$dir}{$section}{$parameter}=$value;
$knownactions{$parameter}=1;
+ if (! exists $configfiles{$dir}) {
+ $configfiles{$dir}=abs_path($f);
+ }
if ($parameter eq 'chain' &&
length $dir && $section ne "DEFAULT" &&
-e $dir.$section."/.mrconfig") {
if ($parameter eq 'chain' &&
length $dir && $section ne "DEFAULT" &&
-e $dir.$section."/.mrconfig") {
if [ -z "$url" ]; then
error "cannot determine svn url"
fi
if [ -z "$url" ]; then
error "cannot determine svn url"
fi
- echo "Registering svn url: $url"
+ echo "Registering svn url: $url in $MR_CONFIG"
mr -c "$MR_CONFIG" config "$(pwd)" checkout="svn co $url $basedir"
elif [ -d .git ]; then
url=$(LANG=C git-config --get remote.origin.url)
if [ -z "$url" ]; then
error "cannot determine git url"
fi
mr -c "$MR_CONFIG" config "$(pwd)" checkout="svn co $url $basedir"
elif [ -d .git ]; then
url=$(LANG=C git-config --get remote.origin.url)
if [ -z "$url" ]; then
error "cannot determine git url"
fi
- echo "Registering git url: $url"
+ echo "Registering git url: $url in $MR_CONFIG"
mr -c "$MR_CONFIG" config "$(pwd)" checkout="git clone $url $basedir"
elif [ -d .bzr ]; then
url=$(cat .bzr/branch/parent)
if [ -z "$url" ]; then
error "cannot determine bzr url"
fi
mr -c "$MR_CONFIG" config "$(pwd)" checkout="git clone $url $basedir"
elif [ -d .bzr ]; then
url=$(cat .bzr/branch/parent)
if [ -z "$url" ]; then
error "cannot determine bzr url"
fi
- echo "Registering bzr url: $url"
+ echo "Registering bzr url: $url in $MR_CONFIG"
mr -c "$MR_CONFIG" config "$(pwd)" checkout="bzr clone $url $basedir"
else
error "unable to register this repo type"
mr -c "$MR_CONFIG" config "$(pwd)" checkout="bzr clone $url $basedir"
else
error "unable to register this repo type"