]> git.madduck.net Git - code/myrepos.git/commitdiff

madduck's git repository

Every one of the projects in this repository is available at the canonical URL git://git.madduck.net/madduck/pub/<projectpath> — see each project's metadata for the exact URL.

All patches and comments are welcome. Please squash your changes to logical commits before using git-format-patch and git-send-email to patches@git.madduck.net. If you'd read over the Git project's submission guidelines and adhered to them, I'd be especially grateful.

SSH access, as well as push access can be individually arranged.

If you use my repositories frequently, consider adding the following snippet to ~/.gitconfig and using the third clone URL listed for each project:

[url "git://git.madduck.net/madduck/"]
  insteadOf = madduck:

run skip test before chdir
authorJoey Hess <joey@kodama.kitenet.net>
Thu, 11 Oct 2007 20:14:57 +0000 (16:14 -0400)
committerJoey Hess <joey@kodama.kitenet.net>
Thu, 11 Oct 2007 20:14:57 +0000 (16:14 -0400)
To avoid ugly "can't chdir" failures for repos that will be skipped.
The $MR_REPO variable can still be used by skip tests.

mr

diff --git a/mr b/mr
index 470927afa04094d00d1a5a61f64db4bc11906f20..5c9d6a3a969640c8c73110f610ec61400bb04063 100755 (executable)
--- a/mr
+++ b/mr
@@ -298,10 +298,6 @@ sub action {
        }
        
        $ENV{MR_REPO}=$dir;
-       if (! $nochdir && ! chdir($dir)) {
-               print STDERR "mr $action: failed to chdir to $dir: $!\n";
-               push @skipped, $dir;
-       }
 
        if (exists $config{$topdir}{$subdir}{skip}) {
                my $test="set -e;".$lib.$config{$topdir}{$subdir}{skip};
@@ -313,8 +309,12 @@ sub action {
                        return;
                }
        }
-
-       if (! exists $config{$topdir}{$subdir}{$action}) {
+       
+       if (! $nochdir && ! chdir($dir)) {
+               print STDERR "mr $action: failed to chdir to $dir: $!\n";
+               push @failed, $dir;
+       }
+       elsif (! exists $config{$topdir}{$subdir}{$action}) {
                print STDERR "mr $action: no defined $action command for $topdir$subdir, skipping\n";
                push @skipped, $dir;
        }