]> git.madduck.net Git - code/myrepos.git/commitdiff

madduck's git repository

Every one of the projects in this repository is available at the canonical URL git://git.madduck.net/madduck/pub/<projectpath> — see each project's metadata for the exact URL.

All patches and comments are welcome. Please squash your changes to logical commits before using git-format-patch and git-send-email to patches@git.madduck.net. If you'd read over the Git project's submission guidelines and adhered to them, I'd be especially grateful.

SSH access, as well as push access can be individually arranged.

If you use my repositories frequently, consider adding the following snippet to ~/.gitconfig and using the third clone URL listed for each project:

[url "git://git.madduck.net/madduck/"]
  insteadOf = madduck:

chdir() to config directory before including chdir-for-chain
authormartin f. krafft <madduck@madduck.net>
Tue, 9 Sep 2014 04:39:54 +0000 (06:39 +0200)
committermartin f. krafft <madduck@madduck.net>
Tue, 9 Sep 2014 04:50:10 +0000 (06:50 +0200)
Make mr try to chdir() to the dirname() of any .mrconfig files it's
supposed to load. If the chdir() is successful, then the filename is
truncated to basename(). If the chdir() is unsuccessful, then processing
happens as before.

Signed-off-by: martin f. krafft <madduck@madduck.net>
mr

diff --git a/mr b/mr
index 18e87616423e7d94ab3686733c137e094f84420b..b7cd3cb61c16b7a46bd116c868121597d2743cd0 100755 (executable)
--- a/mr
+++ b/mr
@@ -563,6 +563,7 @@ use warnings;
 use strict;
 use Getopt::Long;
 use Cwd qw(getcwd abs_path);
+use File::Basename;
 
 # things that can happen when mr runs a command
 use constant {
@@ -1278,6 +1279,7 @@ sub loadconfig {
        my @toload;
 
        my $in;
+       my $absf=abs_path($f);
        my $trusted;
        if (ref $f eq 'GLOB') {
                $dir="";
@@ -1285,7 +1287,6 @@ sub loadconfig {
                $trusted=1;
        }
        else {
-               my $absf=abs_path($f);
                if ($loaded{$absf}) {
                        return;
                }
@@ -1301,7 +1302,11 @@ sub loadconfig {
                }
 
                $dir=abs_path($dir)."/";
-               
+
+               if (chdir($dir)) {
+                       $f=basename($f);
+               }
+
                if (! exists $configfiles{$dir}) {
                        $configfiles{$dir}=$f;
                }
@@ -1323,7 +1328,12 @@ sub loadconfig {
                        return;
                }
 
-               print "mr: loading config $f\n" if $verbose;
+               if ($f =~ /\//) {
+                       print "mr: loading config $f\n" if $verbose;
+               } else {
+                       print "mr: loading config $f (from ".getcwd().")\n" if $verbose;
+               }
+
                open($in, "<", $f) || die "mr: open $f: $!\n";
        }
        my @lines=<$in>;
@@ -1367,7 +1377,7 @@ sub loadconfig {
                                "this can allow arbitrary code execution!)\n";
                }
                else {
-                       die "mr: $msg in untrusted $f line $lineno\n".
+                       die "mr: $msg in untrusted $absf line $lineno\n".
                                "(To trust this file, list it in ~/.mrtrust.)\n";
                }
        };