Merge remote-tracking branch 'Dieter_be/master'

Conflicts:
	doc/error_codes.md

diff --git a/Makefile b/Makefile
index 2d63d1fd8d4aac77d4dd470c5052231b4508cec6..00619864a5e0f70235f00fe05571510f4dd562d9 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,7 @@
 PREFIX=/usr
 
 manpages=vcsh.1
-all=manpages
+all=test manpages
 
 all: $(all)
 
@@ -37,5 +37,8 @@ purge: uninstall
        rmdir -p --ignore-fail-on-non-empty $(DESTDIR)$(PREFIX)/share/doc/
        rmdir -p --ignore-fail-on-non-empty $(DESTDIR)$(PREFIX)/share/zsh/vendor-completions/
 
+test:
+       if which git > /dev/null ; then :; else echo "'git' not found, exiting..."; exit 1; fi
+
 moo:
        if [ -x /usr/games/cowsay ]; then /usr/games/cowsay "I hope you're happy now..."; fi

diff --git a/_vcsh b/_vcsh
index d6850ce36004ab7432bc19cf93d7ef1dae85aff1..c6efe6fdc4b41fd25ce4feb8a678297f4f329149 100644 (file)
--- a/_vcsh
+++ b/_vcsh
@@ -8,6 +8,7 @@ _arguments \
                enter\:"Enter repo; spawn new \$SHELL"
                init\:"init & clone from repo"
                list\:"list all repos"
+               rename\:"rename repo"
                run\:"run command on repo"
                seed-gitignore\:"seed .gitignore.d/foo from git ls-files"
                setup\:"set up repo with recommended settings"

diff --git a/doc/error_codes.md b/doc/error_codes.md
index a6cc903b8c32341797bed5a9b2885e1ccbe6acd2..e127e7d6e7d85f9ffa9bd7207446dfd8b22add99 100644 (file)
--- a/doc/error_codes.md
+++ b/doc/error_codes.md
@@ -4,8 +4,6 @@
 * 11: Could not enter $GIT_WORK_TREE
 * 12: No repository found
 * 13: Required directory exists but is not a directory
-* 14: Could not create directory
-* 15: Could not create file
 * 16: Potentially harmful operation aborted
 * 17: Files that would be overwritten exist; fix manually
 
@@ -13,3 +11,9 @@
 * 51: Could not create file
 * 52: Could not move directory
 * 53: Could not move file
+* 54: Directory exists
+* 55: File exists
+* 56: 
+* 57: Could not write to file
+* 57: Could not delete directory
+* 59: Could not delete file

diff --git a/doc/vcsh.1.ronn b/doc/vcsh.1.ronn
index b348f923d918a208f6f80ff4d6f1ae314089416a..21ded83e85117c8752fee7fb22b22c586133f745 100644 (file)
--- a/doc/vcsh.1.ronn
+++ b/doc/vcsh.1.ronn
@@ -15,6 +15,8 @@ vcsh(1) - manage and sync config files via git
 
 `vcsh` list
 
+`vcsh` rename <repo> <newname>
+
 `vcsh` run <repo> <command>
 
 `vcsh` seed-gitignore <repo>
@@ -62,6 +64,9 @@ A sample configuration for `vcsh` and `mr` can be found at
 * list:
   List all local vcsh repositories.
 
+* rename:
+  Rename a repository.
+
 * run:
   Run command with <$GIT_DIR> and <$GIT_WORK_TREE> set. Allows you to run any
   and all commands without any restrictions. Use with care.

diff --git a/vcsh b/vcsh
index a6d0106cd7fac58429cf7070c08e26ba66bdbf2f..3c8d0830af97c235dc1ca4cfd0f77968612cc229 100755 (executable)
--- a/vcsh
+++ b/vcsh
@@ -16,6 +16,8 @@ help() {
    enter                Enter repository; spawn new $SHELL
    init <repo>          Initialize a new repository
    list                 List all repositories
+   rename <repo> \\
+          <newname>     Rename repository
    run <repo> \\
        <command>        Use this repository
 
@@ -66,8 +68,7 @@ clone() {
 }
 
 delete() {
-       old_dir="$PWD"
-       cd "$HOME"
+       cd "$HOME" || fatal "could not enter '$HOME'" 11
        use
        info "This operation WILL DETROY DATA!"
        files=$(git ls-files)
@@ -82,8 +83,7 @@ To continue, type \"Yes, do as I say\""
        for file in $files; do
                rm -f $file || info "could not delete '$file', continuing with deletion"
        done
-       rm -rf "$GIT_DIR" || info "could not delete '$GIT_DIR'"
-       cd "$old_dir"
+       rmdir "$GIT_DIR" || error "could not delete '$GIT_DIR'"
 }
 
 enter() {
@@ -91,12 +91,15 @@ enter() {
        $SHELL
 }
 
+git_dir_exists() {
+       [ -d "$GIT_DIR" ] || fatal "no repository found for '$VCSH_REPO_NAME'" 12
+}
+
 init() {
        [ ! -e "$GIT_DIR" ] || fatal "'$GIT_DIR' exists" 10
        export GIT_WORK_TREE="$HOME"
-       mkdir -p "$GIT_WORK_TREE"
+       mkdir -p "$GIT_WORK_TREE" || fatal "could not create '$GIT_WORK_TREE'" 50
        cd "$GIT_WORK_TREE" || fatal "could not enter '$GIT_WORK_TREE'" 11
-       cd "$GIT_WORK_TREE"
        git init
        setup
 }
@@ -107,6 +110,13 @@ list() {
        done
 }
 
+rename() {
+       git_dir_exists
+       [ -d "$GIT_DIR_NEW" ] && fatal "'$GIT_DIR_NEW' exists" 54
+       mv -f "$GIT_DIR" "$GIT_DIR_NEW" || fatal "Could not mv '$GIT_DIR' '$GIT_DIR_NEW'" 52
+
+}
+
 run() {
        use
        $VCSH_EXTERNAL_COMMAND
@@ -114,10 +124,7 @@ run() {
 
 seed_gitignore() {
        use
-       # Switching directory as this has to be executed from $HOME to be of any use.
-       # Going back into old directory at the end in case `vcsh use` is reactivated.
-       old_dir="$PWD"
-       cd "$HOME"
+       cd "$HOME" || fatal "could not enter '$HOME'" 11
        gitignores=$(for file in $(git ls-files); do
                while true; do
                        echo $file; new="${file%/*}"
@@ -126,14 +133,15 @@ seed_gitignore() {
                done;
        done | sort -u)
        tempfile=$(mktemp) || fatal "could not create tempfile" 51
-       echo '*' > "$tempfile"
+       echo '*' > "$tempfile" || fatal "could not write to '$tempfile'" 57
        for gitignore in $gitignores; do
-               echo "$gitignore" | sed 's/^/!/' >> "$tempfile"
-               [ -d "$gitignore" ] && echo "$gitignore/*" | sed 's/^/!/'>> "$tempfile"
+               echo "$gitignore" | sed 's/^/!/' >> "$tempfile" || fatal "could not write to '$tempfile'" 57
+               [ -d "$gitignore" ] && echo "$gitignore/*" | sed 's/^/!/'>> "$tempfile" || fatal "could not write to '$tempfile'" 57
        done
-       diff -N "$tempfile" "$HOME/.gitignore.d/$VCSH_REPO_NAME" > /dev/null &&
-               rm -f "$tempfile" &&
+       if [ diff -N "$tempfile" "$HOME/.gitignore.d/$VCSH_REPO_NAME" > /dev/null ]; then
+               rm -f "$tempfile" || error "could not delete '$tempfile'"
                exit
+       fi
        if [ -e "$HOME/.gitignore.d/$VCSH_REPO_NAME" ]; then
                info "'$HOME/.gitignore.d/$VCSH_REPO_NAME' differs from new data, moving it to '$HOME/.gitignore.d/$VCSH_REPO_NAME.bak'"
                mv -f "$HOME/.gitignore.d/$VCSH_REPO_NAME" "$HOME/.gitignore.d/$VCSH_REPO_NAME.bak" ||
@@ -141,7 +149,6 @@ seed_gitignore() {
        fi
        mv -f "$tempfile" "$HOME/.gitignore.d/$VCSH_REPO_NAME" ||
                fatal "could not move '$tempfile' to '$HOME/.gitignore.d/$VCSH_REPO_NAME'" 53
-       cd "$old_dir"
 }
 
 setup() {
@@ -149,14 +156,12 @@ setup() {
        git config core.worktree     "$GIT_WORK_TREE"
        git config core.excludesfile ".gitignore.d/$VCSH_REPO_NAME"
        git config vcsh.vcsh         'true'
-       touch   "$HOME/.gitignore.d/$VCSH_REPO_NAME"
+       touch   "$HOME/.gitignore.d/$VCSH_REPO_NAME" || error "could not touch '$HOME/.gitignore.d/$VCSH_REPO_NAME'"
        git add "$HOME/.gitignore.d/$VCSH_REPO_NAME"
 }
 
 use() {
-       if [ ! -d "$GIT_DIR" ]; then
-               fatal "no repository found for '$VCSH_REPO_NAME'" 12
-       fi
+       git_dir_exists
        export GIT_WORK_TREE="$(git config --get core.worktree)"
        export VCSH_DIRECTORY="$VCSH_REPO_NAME"
 }
@@ -171,16 +176,19 @@ if [ "$1" = 'clone' ]; then
 elif [ "$1" = 'delete' ] ||
      [ "$1" = 'enter' ] ||
      [ "$1" = 'init' ] ||
+     [ "$1" = 'rename' ] ||
      [ "$1" = 'run' ] ||
      [ "$1" = 'seed-gitignore' ] ||
      [ "$1" = 'setup' ]; then
-       [ -z $2 ] && fatal "$1: please specify repository to work on" 1
-       [ "$1" = 'run' -a -z "$3" ] && fatal "$1: please specify a command" 1
+       [ -z $2 ]                      && fatal "$1: please specify repository to work on" 1
+       [ "$1" = 'rename' -a -z "$3" ] && fatal "$1: please specify a target name" 1
+       [ "$1" = 'run' -a -z "$3" ]    && fatal "$1: please specify a command" 1
        export VCSH_COMMAND="$1"
        export VCSH_REPO_NAME="$2"
        export GIT_DIR="$VCSH_BASE/$VCSH_REPO_NAME.git"
-       [ "$1" = 'run' ] && shift 2 && export VCSH_EXTERNAL_COMMAND="$@"
-       [ "$1" = 'seed-gitignore' ] && export VCSH_COMMAND=seed_gitignore
+       [ "$VCSH_COMMAND" = 'rename' ]         && export GIT_DIR_NEW="$VCSH_BASE/$3.git"
+       [ "$VCSH_COMMAND" = 'run' ] && shift 2 && export VCSH_EXTERNAL_COMMAND="$@"
+       [ "$VCSH_COMMAND" = 'seed-gitignore' ] && export VCSH_COMMAND='seed_gitignore'
 elif [ "$1" = 'list' ]; then
        export VCSH_COMMAND="$1"
 elif [ -n "$1" ]; then