Fixes for the silly case where a client's borders are bigger than its allotted space

[etc/awesome.git] / widgets / net.lua

diff --git a/widgets/net.lua b/widgets/net.lua
index 2bfd375c337deb3f7b97fb211425ad07a8b32ab8..a578ae4ca9cc405454c4cc57a6b23cd5a9be2a0e 100644 (file)
--- a/widgets/net.lua
+++ b/widgets/net.lua
@@ -13,10 +13,9 @@ local notify_fg    = require("beautiful").fg_focus
 local naughty      = require("naughty")
 local wibox        = require("wibox")
 
 local naughty      = require("naughty")
 local wibox        = require("wibox")
 

-local io           = { popen  = io.popen }
-local tostring     = tostring

 local string       = { format = string.format,
 local string       = { format = string.format,

-                       gsub   = string.gsub }
+                       gsub   = string.gsub,
+                       match  = string.match }

 
 local setmetatable = setmetatable
 
 
 local setmetatable = setmetatable
 


@@ -28,12 +27,10 @@ local net = {
 }
 
 function net.get_device()
 }
 
 function net.get_device()

-    f = io.popen("ip link show | cut -d' ' -f2,9")
-    ws = f:read("*a")
-    f:close()
-    ws = ws:match("%w+: UP")
+    local ws = helpers.read_pipe("ip link show | cut -d' ' -f2,9")
+    ws = ws:match("%w+: UP") or ws:match("ppp%w+: UNKNOWN")

     if ws ~= nil then
     if ws ~= nil then

-        return ws:gsub(": UP", "")
+        return ws:match("(%w+):")

     else
         return "network off"
     end
     else
         return "network off"
     end


@@ -42,11 +39,13 @@ end
 local function worker(args)
     local args = args or {}
     local timeout = args.timeout or 2
 local function worker(args)
     local args = args or {}
     local timeout = args.timeout or 2

-    local iface = args.iface or net.get_device()

     local units = args.units or 1024 --kb
     local notify = args.notify or "on"
     local units = args.units or 1024 --kb
     local notify = args.notify or "on"

+    local screen = args.screen or 1

     local settings = args.settings or function() end
 
     local settings = args.settings or function() end
 

+    iface = args.iface or net.get_device()
+

     net.widget = wibox.widget.textbox('')
 
     helpers.set_map(iface, true)
     net.widget = wibox.widget.textbox('')
 
     helpers.set_map(iface, true)


@@ -54,7 +53,10 @@ local function worker(args)
     function update()
         net_now = {}
 
     function update()
         net_now = {}
 

-        if iface == "" then iface = net.get_device() end
+        if iface == "" or string.match(iface, "network off")
+        then
+            iface = net.get_device()
+        end

 
         net_now.carrier = helpers.first_line('/sys/class/net/' .. iface ..
                                            '/carrier') or "0"
 
         net_now.carrier = helpers.first_line('/sys/class/net/' .. iface ..
                                            '/carrier') or "0"


@@ -65,10 +67,10 @@ local function worker(args)
         local now_r = helpers.first_line('/sys/class/net/' .. iface ..
                                            '/statistics/rx_bytes') or 0
 
         local now_r = helpers.first_line('/sys/class/net/' .. iface ..
                                            '/statistics/rx_bytes') or 0
 

-        net_now.sent = tostring((now_t - net.last_t) / timeout / units)
+        net_now.sent = (now_t - net.last_t) / timeout / units

         net_now.sent = string.gsub(string.format('%.1f', net_now.sent), ",", ".")
 
         net_now.sent = string.gsub(string.format('%.1f', net_now.sent), ",", ".")
 

-        net_now.received = tostring((now_r - net.last_r) / timeout / units)
+        net_now.received = (now_r - net.last_r) / timeout / units

         net_now.received = string.gsub(string.format('%.1f', net_now.received), ",", ".")
 
         widget = net.widget
         net_now.received = string.gsub(string.format('%.1f', net_now.received), ",", ".")
 
         widget = net.widget


@@ -88,6 +90,7 @@ local function worker(args)
                     position = "top_left",
                     icon     = helpers.icons_dir .. "no_net.png",
                     fg       = notify_fg or "#FFFFFF",
                     position = "top_left",
                     icon     = helpers.icons_dir .. "no_net.png",
                     fg       = notify_fg or "#FFFFFF",

+                    screen   = screen

                 })
                 helpers.set_map(iface, false)
             end
                 })
                 helpers.set_map(iface, false)
             end