Task: Move TW-specific start/stop logic into TW backend

[etc/taskwarrior.git] / tasklib / backends.py

diff --git a/tasklib/backends.py b/tasklib/backends.py
index f817d4f31d1cef32987cdaae2074aa8664960b63..12a923446d6a5eb20402e01e8fc6cae0c614c0f6 100644 (file)
--- a/tasklib/backends.py
+++ b/tasklib/backends.py
@@ -144,6 +144,17 @@ class TaskWarrior(object):
         if self.version < VERSION_2_4_2:
             self.execute_command(['next'], allow_failure=False)
 
         if self.version < VERSION_2_4_2:
             self.execute_command(['next'], allow_failure=False)
 

+    def merge_with(self, path, push=False):
+        path = path.rstrip('/') + '/'
+        self.execute_command(['merge', path], config_override={
+            'merge.autopush': 'yes' if push else 'no',
+        })
+
+    def undo(self):
+        self.execute_command(['undo'])
+
+    # Backend interface implementation
+

     def filter_tasks(self, filter_obj):
         self.enforce_recurrence()
         args = ['export', '--'] + filter_obj.get_filter_params()
     def filter_tasks(self, filter_obj):
         self.enforce_recurrence()
         args = ['export', '--'] + filter_obj.get_filter_params()


@@ -159,11 +170,42 @@ class TaskWarrior(object):
                     raise TaskWarriorException('Invalid JSON: %s' % data)
         return tasks
 
                     raise TaskWarriorException('Invalid JSON: %s' % data)
         return tasks
 

-    def merge_with(self, path, push=False):
-        path = path.rstrip('/') + '/'
-        self.execute_command(['merge', path], config_override={
-            'merge.autopush': 'yes' if push else 'no',
-        })
+    def save_task(self, task):
+        """Save a task into TaskWarrior database using add/modify call"""

 
 

-    def undo(self):
-        self.execute_command(['undo'])
+        args = [task['uuid'], 'modify'] if task.saved else ['add']
+        args.extend(task._get_modified_fields_as_args())
+        output = self.execute_command(args)
+
+        # Parse out the new ID, if the task is being added for the first time
+        if not task.saved:
+            id_lines = [l for l in output if l.startswith('Created task ')]
+
+            # Complain loudly if it seems that more tasks were created
+            # Should not happen
+            if len(id_lines) != 1 or len(id_lines[0].split(' ')) != 3:
+                raise TaskWarriorException("Unexpected output when creating "
+                                           "task: %s" % '\n'.join(id_lines))
+
+            # Circumvent the ID storage, since ID is considered read-only
+            identifier = id_lines[0].split(' ')[2].rstrip('.')
+
+            # Identifier can be either ID or UUID for completed tasks
+            try:
+                task._data['id'] = int(identifier)
+            except ValueError:
+                task._data['uuid'] = identifier
+
+        # Refreshing is very important here, as not only modification time
+        # is updated, but arbitrary attribute may have changed due hooks
+        # altering the data before saving
+        task.refresh(after_save=True)
+
+    def delete_task(self, task):
+        self.execute_command([task['uuid'], 'delete'])
+
+    def start_task(self, task):
+        self.execute_command([task['uuid'], 'start'])
+
+    def stop_task(self, task):
+        self.execute_command([task['uuid'], 'stop'])