Set missing attributes back to Task._data on access

[etc/taskwarrior.git] / tasklib / tests.py

diff --git a/tasklib/tests.py b/tasklib/tests.py
index 6d67a12d4fb7ae0098080bf5762bee7d1e54c701..a608cf802a6969850cc277c12c48ddc5d3293d05 100644 (file)
--- a/tasklib/tests.py
+++ b/tasklib/tests.py
@@ -181,9 +181,9 @@ class TaskTest(TasklibTest):
 
         # We only save the parent task, dependency task is unsaved
         t.save()
 
         # We only save the parent task, dependency task is unsaved
         t.save()

+        t['depends'] = set([dependency])

 
 

-        self.assertRaises(Task.NotSaved,
-                          t.__setitem__, 'depends', set([dependency]))
+        self.assertRaises(Task.NotSaved, t.save)

 
     def test_set_simple_dependency_set(self):
         # Adds only one dependency to task with no dependencies
 
     def test_set_simple_dependency_set(self):
         # Adds only one dependency to task with no dependencies


@@ -223,7 +223,7 @@ class TaskTest(TasklibTest):
         t['depends'] = set([dependency1, dependency2])
         t.save()
 
         t['depends'] = set([dependency1, dependency2])
         t.save()
 

-        t['depends'] = t['depends'] - set([dependency2])
+        t['depends'].remove(dependency2)

         t.save()
 
         self.assertEqual(t['depends'], set([dependency1]))
         t.save()
 
         self.assertEqual(t['depends'], set([dependency1]))


@@ -240,11 +240,23 @@ class TaskTest(TasklibTest):
         t['depends'] = set([dependency1])
         t.save()
 
         t['depends'] = set([dependency1])
         t.save()
 

-        t['depends'] = t['depends'] | set([dependency2])
+        t['depends'].add(dependency2)

         t.save()
 
         self.assertEqual(t['depends'], set([dependency1, dependency2]))
 
         t.save()
 
         self.assertEqual(t['depends'], set([dependency1, dependency2]))
 

+    def test_add_to_empty_dependency_set(self):
+        # Adds dependency to task with one dependencies
+        t = Task(self.tw, description="test task")
+        dependency = Task(self.tw, description="needs to be done first")
+
+        dependency.save()
+
+        t['depends'].add(dependency)
+        t.save()
+
+        self.assertEqual(t['depends'], set([dependency]))
+

     def test_simple_dependency_set_save_repeatedly(self):
         # Adds only one dependency to task with no dependencies
         t = Task(self.tw, description="test task")
     def test_simple_dependency_set_save_repeatedly(self):
         # Adds only one dependency to task with no dependencies
         t = Task(self.tw, description="test task")


@@ -413,6 +425,25 @@ class TaskTest(TasklibTest):
             self.assertRaises(RuntimeError,
                               lambda: t.__setitem__(readonly_key, 'value'))
 
             self.assertRaises(RuntimeError,
                               lambda: t.__setitem__(readonly_key, 'value'))
 

+    def test_saving_unmodified_task(self):
+        t = Task(self.tw, description="test task")
+        t.save()
+        t.save()
+
+    def test_adding_tag_by_appending(self):
+        t = Task(self.tw, description="test task", tags=['test1'])
+        t.save()
+        t['tags'].append('test2')
+        t.save()
+        self.assertEqual(t['tags'], ['test1', 'test2'])
+
+    def test_adding_tag_by_appending_empty(self):
+        t = Task(self.tw, description="test task")
+        t.save()
+        t['tags'].append('test')
+        t.save()
+        self.assertEqual(t['tags'], ['test'])
+

 
 class AnnotationTest(TasklibTest):
 
 
 class AnnotationTest(TasklibTest):