Task: Update _original_data with data dict too when creating Task object

[etc/taskwarrior.git] / tasklib / task.py

diff --git a/tasklib/task.py b/tasklib/task.py
index 64c13acc87a0cc9c96b569c50791ecb40e686974..d9b2678e084b89fb3e7a75867b0fa0f07bbf02e7 100644 (file)
--- a/tasklib/task.py
+++ b/tasklib/task.py
@@ -92,7 +92,7 @@ class TaskAnnotation(TaskResource):
 
 
 class Task(TaskResource):
 
 
 class Task(TaskResource):

-    read_only_fields = ['id', 'entry', 'urgency', 'uuid']
+    read_only_fields = ['id', 'entry', 'urgency', 'uuid', 'modified']

 
     class DoesNotExist(Exception):
         pass
 
     class DoesNotExist(Exception):
         pass


@@ -130,6 +130,7 @@ class Task(TaskResource):
         # We keep data for backwards compatibility
         # TODO: Should we keep this using unserialized access to _data dict?
         self._data.update(data)
         # We keep data for backwards compatibility
         # TODO: Should we keep this using unserialized access to _data dict?
         self._data.update(data)

+        self._original_data.update(data)

 
     def __unicode__(self):
         return self['description']
 
     def __unicode__(self):
         return self['description']


@@ -153,7 +154,8 @@ class Task(TaskResource):
 
     @property
     def _modified_fields(self):
 
     @property
     def _modified_fields(self):

-        for key in self._data.keys():
+        writable_fields = set(self._data.keys()) - set(self.read_only_fields)
+        for key in writable_fields:

             if self._data.get(key) != self._original_data.get(key):
                 yield key
 
             if self._data.get(key) != self._original_data.get(key):
                 yield key