TaskWarrior: Return ReadOnlyDictView of config instead of passing a copy of a mutable...

[etc/taskwarrior.git] / tasklib / backends.py

diff --git a/tasklib/backends.py b/tasklib/backends.py
index b2038be70624d254c2d64a4347c8b20b04f42254..fa5ce866a97f8d3f00964ac817aa68f9e1613e9f 100644 (file)
--- a/tasklib/backends.py
+++ b/tasklib/backends.py
@@ -9,7 +9,7 @@ import six
 import subprocess
 import copy
 
 import subprocess
 import copy
 

-from .task import Task, TaskQuerySet
+from .task import Task, TaskQuerySet, ReadOnlyDictView

 from .filters import TaskWarriorFilter
 from .serializing import local_zone
 
 from .filters import TaskWarriorFilter
 from .serializing import local_zone
 


@@ -234,7 +234,7 @@ class TaskWarrior(Backend):
     def config(self):
         # First, check if memoized information is available
         if self._config:
     def config(self):
         # First, check if memoized information is available
         if self._config:

-            return copy.deepcopy(self._config)
+            return self._config

 
         # If not, fetch the config using the 'show' command
         raw_output = self.execute_command(
 
         # If not, fetch the config using the 'show' command
         raw_output = self.execute_command(


@@ -251,9 +251,9 @@ class TaskWarrior(Backend):
                 config[match.group('key')] = match.group('value').strip()
 
         # Memoize the config dict
                 config[match.group('key')] = match.group('value').strip()
 
         # Memoize the config dict

-        self._config = config
+        self._config = ReadOnlyDictView(config)

 
 

-        return copy.deepcopy(config)
+        return self._config

 
     def execute_command(self, args, config_override=None, allow_failure=True,
                         return_all=False):
 
     def execute_command(self, args, config_override=None, allow_failure=True,
                         return_all=False):