Task: List all non-readable fields as modified when creating new task

[etc/taskwarrior.git] / tasklib / task.py

diff --git a/tasklib/task.py b/tasklib/task.py
index c72a9b307ec9769d73081d92b4ae221c07a5a881..36f3c3b13054e4bdab5870ec8e663c89535c5489 100644 (file)
--- a/tasklib/task.py
+++ b/tasklib/task.py
@@ -71,7 +71,7 @@ class TaskAnnotation(TaskResource):
 
 
 class Task(TaskResource):
 
 
 class Task(TaskResource):

-    read_only_fields = ['id', 'entry', 'urgency']
+    read_only_fields = ['id', 'entry', 'urgency', 'uuid']

 
     class DoesNotExist(Exception):
         pass
 
     class DoesNotExist(Exception):
         pass


@@ -112,6 +112,10 @@ class Task(TaskResource):
     def pending(self):
         return self['status'] == six.text_type('pending')
 
     def pending(self):
         return self['status'] == six.text_type('pending')
 

+    @property
+    def saved(self):
+        return self['uuid'] is not None or self['id'] is not None
+

     def serialize_due(self, date):
         return date.strftime(DATE_FORMAT)
 
     def serialize_due(self, date):
         return date.strftime(DATE_FORMAT)
 


@@ -138,7 +142,7 @@ class Task(TaskResource):
         if self.deleted:
             raise self.DeletedTask("Task was already deleted")
 
         if self.deleted:
             raise self.DeletedTask("Task was already deleted")
 

-        self.warrior.execute_command([self['id'], 'delete'], config_override={
+        self.warrior.execute_command([self['uuid'], 'delete'], config_override={

             'confirmation': 'no',
         })
 
             'confirmation': 'no',
         })
 


@@ -155,37 +159,71 @@ class Task(TaskResource):
         elif self.deleted:
             raise self.DeletedTask("Deleted task cannot be completed")
 
         elif self.deleted:
             raise self.DeletedTask("Deleted task cannot be completed")
 

-        self.warrior.execute_command([self['id'], 'done'])
+        self.warrior.execute_command([self['uuid'], 'done'])

 
         # Refresh the status again, so that we have updated info stored
         self.refresh(only_fields=['status'])
 
     def save(self):
 
         # Refresh the status again, so that we have updated info stored
         self.refresh(only_fields=['status'])
 
     def save(self):

-        args = [self['id'], 'modify'] if self['id'] else ['add']
+        args = [self['uuid'], 'modify'] if self.saved else ['add']

         args.extend(self._get_modified_fields_as_args())
         args.extend(self._get_modified_fields_as_args())

-        self.warrior.execute_command(args)
+        output = self.warrior.execute_command(args)
+
+        # Parse out the new ID, if the task is being added for the first time
+        if not self.saved:
+            id_lines = [l for l in output if l.startswith('Created task ')]
+
+            # Complain loudly if it seems that more tasks were created
+            # Should not happen
+            if len(id_lines) != 1 or len(id_lines[0].split(' ')) != 3:
+                raise TaskWarriorException("Unexpected output when creating "
+                                           "task: %s" % '\n'.join(id_lines))
+
+            # Circumvent the ID storage, since ID is considered read-only
+            self._data['id'] = int(id_lines[0].split(' ')[2].rstrip('.'))
+

         self._modified_fields.clear()
         self._modified_fields.clear()

+        self.refresh()

 
     def add_annotation(self, annotation):
 
     def add_annotation(self, annotation):

-        args = [self['id'], 'annotate', annotation]
+        args = [self['uuid'], 'annotate', annotation]

         self.warrior.execute_command(args)
         self.warrior.execute_command(args)

+        # TODO: This will not work with the tasks that are not yet saved

         self.refresh(only_fields=['annotations'])
 
     def remove_annotation(self, annotation):
         if isinstance(annotation, TaskAnnotation):
             annotation = annotation['description']
         self.refresh(only_fields=['annotations'])
 
     def remove_annotation(self, annotation):
         if isinstance(annotation, TaskAnnotation):
             annotation = annotation['description']

-        args = [self['id'], 'denotate', annotation]
+        args = [self['uuid'], 'denotate', annotation]

         self.warrior.execute_command(args)
         self.warrior.execute_command(args)

+        # TODO: This will not work with the tasks that are not yet saved

         self.refresh(only_fields=['annotations'])
 
     def _get_modified_fields_as_args(self):
         args = []
         self.refresh(only_fields=['annotations'])
 
     def _get_modified_fields_as_args(self):
         args = []

-        for field in self._modified_fields:
-            args.append('{}:{}'.format(field, self._data[field]))
+
+        # If we're modifying saved task, simply pass on all modified fields
+        if self.saved:
+            for field in self._modified_fields:
+                args.append('{0}:{1}'.format(field, self._data[field]))
+        # For new tasks, pass all fields that make sense
+        else:
+            for field in self._data.keys():
+                if field in self.read_only_fields:
+                    continue
+                args.append('{0}:{1}'.format(field, self._data[field]))
+

         return args
 
     def refresh(self, only_fields=[]):
         return args
 
     def refresh(self, only_fields=[]):

-        args = [self['uuid'], 'export']
+        # Do not refresh for tasks that are not yet saved in the TW
+        if not self.saved:
+            return
+
+        # We need to use ID as backup for uuid here for the refreshes
+        # of newly saved tasks. Any other place in the code is fine
+        # with using UUID only.
+        args = [self['uuid'] or self['id'], 'export']

         new_data = json.loads(self.warrior.execute_command(args)[0])
         if only_fields:
             to_update = dict(
         new_data = json.loads(self.warrior.execute_command(args)[0])
         if only_fields:
             to_update = dict(