TaskWarrior: Use config propery instead of get_config call

[etc/taskwarrior.git] / tasklib / backends.py

diff --git a/tasklib/backends.py b/tasklib/backends.py
index 825db822b8110abb273e6caa95836525a294c90b..fbe3ba336e53b50f92a08874c0d1a9b9cec5e7c9 100644 (file)
--- a/tasklib/backends.py
+++ b/tasklib/backends.py
@@ -1,4 +1,5 @@
 import abc
 import abc

+import copy

 import datetime
 import json
 import logging
 import datetime
 import json
 import logging


@@ -6,6 +7,7 @@ import os
 import re
 import six
 import subprocess
 import re
 import six
 import subprocess

+import copy

 
 from .task import Task, TaskQuerySet
 from .filters import TaskWarriorFilter
 
 from .task import Task, TaskQuerySet
 from .filters import TaskWarriorFilter


@@ -15,6 +17,7 @@ DATE_FORMAT_CALC = '%Y-%m-%dT%H:%M:%S'
 
 logger = logging.getLogger(__name__)
 
 
 logger = logging.getLogger(__name__)
 

+

 class Backend(object):
 
     @abc.abstractproperty
 class Backend(object):
 
     @abc.abstractproperty


@@ -80,7 +83,7 @@ class TaskWarriorException(Exception):
     pass
 
 
     pass
 
 

-class TaskWarrior(object):
+class TaskWarrior(Backend):

 
     VERSION_2_1_0 = six.u('2.1.0')
     VERSION_2_2_0 = six.u('2.2.0')
 
     VERSION_2_1_0 = six.u('2.1.0')
     VERSION_2_2_0 = six.u('2.2.0')


@@ -100,6 +103,7 @@ class TaskWarrior(object):
         if not os.path.exists(self.taskrc_location):
             self.taskrc_location = '/'
 
         if not os.path.exists(self.taskrc_location):
             self.taskrc_location = '/'
 

+        self._config = None

         self.version = self._get_version()
         self.config = {
             'confirmation': 'no',
         self.version = self._get_version()
         self.config = {
             'confirmation': 'no',


@@ -134,9 +138,9 @@ class TaskWarrior(object):
 
     def _get_version(self):
         p = subprocess.Popen(
 
     def _get_version(self):
         p = subprocess.Popen(

-                ['task', '--version'],
-                stdout=subprocess.PIPE,
-                stderr=subprocess.PIPE)
+            ['task', '--version'],
+            stdout=subprocess.PIPE,
+            stderr=subprocess.PIPE)

         stdout, stderr = [x.decode('utf-8') for x in p.communicate()]
         return stdout.strip('\n')
 
         stdout, stderr = [x.decode('utf-8') for x in p.communicate()]
         return stdout.strip('\n')
 


@@ -153,10 +157,11 @@ class TaskWarrior(object):
             if serialized_value is '':
                 escaped_serialized_value = ''
             else:
             if serialized_value is '':
                 escaped_serialized_value = ''
             else:

-                escaped_serialized_value = six.u("'{0}'").format(serialized_value)
+                escaped_serialized_value = six.u("'{0}'").format(
+                    serialized_value)

 
 

-            format_default = lambda task: six.u("{0}:{1}").format(field,
-                                                      escaped_serialized_value)
+            format_default = lambda task: six.u("{0}:{1}").format(
+                field, escaped_serialized_value)

 
             format_func = getattr(self, 'format_{0}'.format(field),
                                   format_default)
 
             format_func = getattr(self, 'format_{0}'.format(field),
                                   format_default)


@@ -191,9 +196,9 @@ class TaskWarrior(object):
 
         # Removed dependencies need to be prefixed with '-'
         return 'depends:' + ','.join(
 
         # Removed dependencies need to be prefixed with '-'
         return 'depends:' + ','.join(

-                [t['uuid'] for t in added] +
-                ['-' + t['uuid'] for t in removed]
-            )
+            [t['uuid'] for t in added] +
+            ['-' + t['uuid'] for t in removed]
+        )

 
     def format_description(self, task):
         # Task version older than 2.4.0 ignores first word of the
 
     def format_description(self, task):
         # Task version older than 2.4.0 ignores first word of the


@@ -225,11 +230,17 @@ class TaskWarrior(object):
 
     # Public interface
 
 
     # Public interface
 

-    def get_config(self):
+    @property
+    def config(self):
+        # First, check if memoized information is available
+        if self._config:
+            return copy.deepcopy(self._config)
+
+        # If not, fetch the config using the 'show' command

         raw_output = self.execute_command(
         raw_output = self.execute_command(

-                ['show'],
-                config_override={'verbose': 'nothing'}
-            )
+            ['show'],
+            config_override={'verbose': 'nothing'}
+        )

 
         config = dict()
         config_regex = re.compile(r'^(?P<key>[^\s]+)\s+(?P<value>[^\s].+$)')
 
         config = dict()
         config_regex = re.compile(r'^(?P<key>[^\s]+)\s+(?P<value>[^\s].+$)')


@@ -239,7 +250,10 @@ class TaskWarrior(object):
             if match:
                 config[match.group('key')] = match.group('value').strip()
 
             if match:
                 config[match.group('key')] = match.group('value').strip()
 

-        return config
+        # Memoize the config dict
+        self._config = config
+
+        return copy.deepcopy(config)

 
     def execute_command(self, args, config_override=None, allow_failure=True,
                         return_all=False):
 
     def execute_command(self, args, config_override=None, allow_failure=True,
                         return_all=False):


@@ -380,14 +394,14 @@ class TaskWarrior(object):
                 taskfilter.add_filter_param(key, value)
 
             output = self.execute_command(['export', '--'] +
                 taskfilter.add_filter_param(key, value)
 
             output = self.execute_command(['export', '--'] +

-                taskfilter.get_filter_params())
+                                          taskfilter.get_filter_params())

 
         # If more than 1 task has been matched still, raise an exception
         if not valid(output):
             raise TaskWarriorException(
                 "Unique identifiers {0} with description: {1} matches "
                 "multiple tasks: {2}".format(
 
         # If more than 1 task has been matched still, raise an exception
         if not valid(output):
             raise TaskWarriorException(
                 "Unique identifiers {0} with description: {1} matches "
                 "multiple tasks: {2}".format(

-                task['uuid'] or task['id'], task['description'], output)
+                    task['uuid'] or task['id'], task['description'], output)

             )
 
         return json.loads(output[0])
             )
 
         return json.loads(output[0])