Restore _update_data and only_fields, and add a test for race conditions

[etc/taskwarrior.git] / tasklib / tests.py

diff --git a/tasklib/tests.py b/tasklib/tests.py
index f3edd61c56422fd1f53c2c39db36ec1cecdc7780..8fc5753219fd1ee224d758b82f83d1a6d29df4b0 100644 (file)
--- a/tasklib/tests.py
+++ b/tasklib/tests.py
@@ -245,6 +245,18 @@ class TaskTest(TasklibTest):
 
         self.assertEqual(t['depends'], set([dependency1, dependency2]))
 
 
         self.assertEqual(t['depends'], set([dependency1, dependency2]))
 

+    def test_add_to_empty_dependency_set(self):
+        # Adds dependency to task with one dependencies
+        t = Task(self.tw, description="test task")
+        dependency = Task(self.tw, description="needs to be done first")
+
+        dependency.save()
+
+        t['depends'].add(dependency)
+        t.save()
+
+        self.assertEqual(t['depends'], set([dependency]))
+

     def test_simple_dependency_set_save_repeatedly(self):
         # Adds only one dependency to task with no dependencies
         t = Task(self.tw, description="test task")
     def test_simple_dependency_set_save_repeatedly(self):
         # Adds only one dependency to task with no dependencies
         t = Task(self.tw, description="test task")


@@ -416,7 +428,6 @@ class TaskTest(TasklibTest):
     def test_saving_unmodified_task(self):
         t = Task(self.tw, description="test task")
         t.save()
     def test_saving_unmodified_task(self):
         t = Task(self.tw, description="test task")
         t.save()

-        t.refresh()

         t.save()
 
     def test_adding_tag_by_appending(self):
         t.save()
 
     def test_adding_tag_by_appending(self):


@@ -424,9 +435,15 @@ class TaskTest(TasklibTest):
         t.save()
         t['tags'].append('test2')
         t.save()
         t.save()
         t['tags'].append('test2')
         t.save()

-        t.refresh()

         self.assertEqual(t['tags'], ['test1', 'test2'])
 
         self.assertEqual(t['tags'], ['test1', 'test2'])
 

+    def test_adding_tag_by_appending_empty(self):
+        t = Task(self.tw, description="test task")
+        t.save()
+        t['tags'].append('test')
+        t.save()
+        self.assertEqual(t['tags'], ['test'])
+

 
 class AnnotationTest(TasklibTest):
 
 
 class AnnotationTest(TasklibTest):
 


@@ -461,6 +478,14 @@ class AnnotationTest(TasklibTest):
         task.remove_annotation(ann)
         self.assertEqual(len(task['annotations']), 0)
 
         task.remove_annotation(ann)
         self.assertEqual(len(task['annotations']), 0)
 

+    def test_annotation_after_modification(self):
+         task = self.tw.tasks.get()
+         task['project'] = 'test'
+         task.add_annotation('I should really do this task')
+         self.assertEqual(task['project'], 'test')
+         task.save()
+         self.assertEqual(task['project'], 'test')
+

 
 class UnicodeTest(TasklibTest):
 
 
 class UnicodeTest(TasklibTest):