]> git.madduck.net Git - etc/taskwarrior.git/commitdiff

madduck's git repository

Every one of the projects in this repository is available at the canonical URL git://git.madduck.net/madduck/pub/<projectpath> — see each project's metadata for the exact URL.

All patches and comments are welcome. Please squash your changes to logical commits before using git-format-patch and git-send-email to patches@git.madduck.net. If you'd read over the Git project's submission guidelines and adhered to them, I'd be especially grateful.

SSH access, as well as push access can be individually arranged.

If you use my repositories frequently, consider adding the following snippet to ~/.gitconfig and using the third clone URL listed for each project:

[url "git://git.madduck.net/madduck/"]
  insteadOf = madduck:

Task: Move TW-specific completion logic into TW backend
authorTomas Babej <tomasbabej@gmail.com>
Sat, 8 Aug 2015 18:06:03 +0000 (20:06 +0200)
committerTomas Babej <tomasbabej@gmail.com>
Sat, 8 Aug 2015 18:08:42 +0000 (20:08 +0200)
tasklib/backends.py
tasklib/task.py

index c99d63fa1dd984ee0bd1bc080837b3a784823489..e7b9a74f4adf2c5d6627e21aba2eeb6f4b77ad5f 100644 (file)
@@ -213,3 +213,11 @@ class TaskWarrior(object):
 
     def stop_task(self, task):
         self.execute_command([task['uuid'], 'stop'])
+
+    def complete_task(self, task):
+        # Older versions of TW do not stop active task at completion
+        if self.version < VERSION_2_4_0 and task.active:
+            task.stop()
+
+        self.execute_command([task['uuid'], 'done'])
+
index b7bba4bd541df0ef12acd63c9548af8fab6add93..3f53511416da4ec670689ecb34f3f4cfc0e646a4 100644 (file)
@@ -637,11 +637,7 @@ class Task(TaskResource):
         elif self.deleted:
             raise Task.DeletedTask("Deleted task cannot be completed")
 
-        # Older versions of TW do not stop active task at completion
-        if self.warrior.version < VERSION_2_4_0 and self.active:
-            self.stop()
-
-        self.warrior.execute_command([self['uuid'], 'done'])
+        self.backend.complete_task(self)
 
         # Refresh the status again, so that we have updated info stored
         self.refresh(only_fields=['status', 'start', 'end'])