Task: Move TW-specific completion logic into TW backend

diff --git a/tasklib/backends.py b/tasklib/backends.py
index c99d63fa1dd984ee0bd1bc080837b3a784823489..e7b9a74f4adf2c5d6627e21aba2eeb6f4b77ad5f 100644 (file)
--- a/tasklib/backends.py
+++ b/tasklib/backends.py
@@ -213,3 +213,11 @@ class TaskWarrior(object):
 
     def stop_task(self, task):
         self.execute_command([task['uuid'], 'stop'])
+
+    def complete_task(self, task):
+        # Older versions of TW do not stop active task at completion
+        if self.version < VERSION_2_4_0 and task.active:
+            task.stop()
+
+        self.execute_command([task['uuid'], 'done'])
+

diff --git a/tasklib/task.py b/tasklib/task.py
index b7bba4bd541df0ef12acd63c9548af8fab6add93..3f53511416da4ec670689ecb34f3f4cfc0e646a4 100644 (file)
--- a/tasklib/task.py
+++ b/tasklib/task.py
@@ -637,11 +637,7 @@ class Task(TaskResource):
         elif self.deleted:
             raise Task.DeletedTask("Deleted task cannot be completed")
 
-        # Older versions of TW do not stop active task at completion
-        if self.warrior.version < VERSION_2_4_0 and self.active:
-            self.stop()
-
-        self.warrior.execute_command([self['uuid'], 'done'])
+        self.backend.complete_task(self)
 
         # Refresh the status again, so that we have updated info stored
         self.refresh(only_fields=['status', 'start', 'end'])