]> git.madduck.net Git - etc/taskwarrior.git/commitdiff

madduck's git repository

Every one of the projects in this repository is available at the canonical URL git://git.madduck.net/madduck/pub/<projectpath> — see each project's metadata for the exact URL.

All patches and comments are welcome. Please squash your changes to logical commits before using git-format-patch and git-send-email to patches@git.madduck.net. If you'd read over the Git project's submission guidelines and adhered to them, I'd be especially grateful.

SSH access, as well as push access can be individually arranged.

If you use my repositories frequently, consider adding the following snippet to ~/.gitconfig and using the third clone URL listed for each project:

[url "git://git.madduck.net/madduck/"]
  insteadOf = madduck:

tests: Make tests Python 2.6 compatible, avoid using assertRaises as context manager
authorTomas Babej <tomasbabej@gmail.com>
Thu, 25 Dec 2014 17:51:04 +0000 (18:51 +0100)
committerTomas Babej <tomasbabej@gmail.com>
Thu, 25 Dec 2014 22:51:11 +0000 (23:51 +0100)
tasklib/tests.py

index 2af697ff5f585737b4557005470c447f84691c4b..2103c0625d19c3bd6abf69c0847c79230a3fecc5 100644 (file)
@@ -77,44 +77,41 @@ class TaskTest(TasklibTest):
         t = Task(self.tw, description="test task")
         self.assertEqual(len(self.tw.tasks.all()), 0)
 
         t = Task(self.tw, description="test task")
         self.assertEqual(len(self.tw.tasks.all()), 0)
 
+    # TODO: once python 2.6 compatiblity is over, use context managers here
+    #       and in all subsequent tests for assertRaises
+
     def test_delete_unsaved_task(self):
     def test_delete_unsaved_task(self):
-        with self.assertRaises(Task.NotSaved):
-            t = Task(self.tw, description="test task")
-            t.delete()
+        t = Task(self.tw, description="test task")
+        self.assertRaises(Task.NotSaved, t.delete)
 
     def test_complete_unsaved_task(self):
 
     def test_complete_unsaved_task(self):
-        with self.assertRaises(Task.NotSaved):
-            t = Task(self.tw, description="test task")
-            t.done()
+        t = Task(self.tw, description="test task")
+        self.assertRaises(Task.NotSaved, t.done)
 
     def test_refresh_unsaved_task(self):
 
     def test_refresh_unsaved_task(self):
-        with self.assertRaises(Task.NotSaved):
-            t = Task(self.tw, description="test task")
-            t.refresh()
+        t = Task(self.tw, description="test task")
+        self.assertRaises(Task.NotSaved, t.refresh)
 
     def test_delete_deleted_task(self):
         t = Task(self.tw, description="test task")
         t.save()
         t.delete()
 
 
     def test_delete_deleted_task(self):
         t = Task(self.tw, description="test task")
         t.save()
         t.delete()
 
-        with self.assertRaises(Task.DeletedTask):
-            t.delete()
+        self.assertRaises(Task.DeletedTask, t.delete)
 
     def test_complete_completed_task(self):
         t = Task(self.tw, description="test task")
         t.save()
         t.done()
 
 
     def test_complete_completed_task(self):
         t = Task(self.tw, description="test task")
         t.save()
         t.done()
 
-        with self.assertRaises(Task.CompletedTask):
-            t.done()
+        self.assertRaises(Task.CompletedTask, t.done)
 
     def test_complete_deleted_task(self):
         t = Task(self.tw, description="test task")
         t.save()
         t.delete()
 
 
     def test_complete_deleted_task(self):
         t = Task(self.tw, description="test task")
         t.save()
         t.delete()
 
-        with self.assertRaises(Task.DeletedTask):
-            t.done()
+        self.assertRaises(Task.DeletedTask, t.done)
 
 
 class AnnotationTest(TasklibTest):
 
 
 class AnnotationTest(TasklibTest):