]> git.madduck.net Git - etc/taskwarrior.git/commitdiff

madduck's git repository

Every one of the projects in this repository is available at the canonical URL git://git.madduck.net/madduck/pub/<projectpath> — see each project's metadata for the exact URL.

All patches and comments are welcome. Please squash your changes to logical commits before using git-format-patch and git-send-email to patches@git.madduck.net. If you'd read over the Git project's submission guidelines and adhered to them, I'd be especially grateful.

SSH access, as well as push access can be individually arranged.

If you use my repositories frequently, consider adding the following snippet to ~/.gitconfig and using the third clone URL listed for each project:

[url "git://git.madduck.net/madduck/"]
  insteadOf = madduck:

Tests: Add test for filtering with empty UUID
authorTomas Babej <tomasbabej@gmail.com>
Sat, 7 Feb 2015 11:35:47 +0000 (12:35 +0100)
committerTomas Babej <tomasbabej@gmail.com>
Sat, 7 Feb 2015 11:35:47 +0000 (12:35 +0100)
tasklib/tests.py

index 3ff1ebf0ec908c7f5d4b959eef0adc3e7a6413e9..2aebdcb18864698e0ada4dc1a68e0287fbd1b205 100644 (file)
@@ -125,6 +125,8 @@ class TaskFilterTest(TasklibTest):
         filtered_task = self.tw.tasks.get(project="random")
         self.assertEqual(filtered_task['project'], "random")
 
+    def test_filter_with_empty_uuid(self):
+        self.assertRaises(ValueError, lambda: self.tw.tasks.get(uuid=''))
 
 class TaskTest(TasklibTest):
 
@@ -495,11 +497,17 @@ class TaskTest(TasklibTest):
         for deserializer in deserializers:
             self.assertTrue(deserializer('') in (None, [], set()))
 
-    def test_normalizers_returning_empty_string_for_none(self):
+    def test_normalizers_handling_none(self):
         # Test that any normalizer can handle None as a valid value
         t = Task(self.tw)
+
+        # These normalizers are not supposed to handle None
+        exempt_normalizers = ('normalize_uuid', )
+
         normalizers = [getattr(t, normalizer_name) for normalizer_name in
-                       filter(lambda x: x.startswith('normalize_'), dir(t))]
+                       filter(lambda x: x.startswith('normalize_'), dir(t))
+                       if normalizer_name not in exempt_normalizers]
+
         for normalizer in normalizers:
             normalizer(None)