18.4a4 hotfix: don't populate the cache on --check

Fixes #175

diff --git a/README.md b/README.md
index 6cb50ebdb12ced6c9d9fee669cdc948d5b3cb7dc..bc8977b7a9acff4b8a2a1de39b7abb49f3183fb2 100644 (file)
--- a/README.md
+++ b/README.md
@@ -522,6 +522,11 @@ More details can be found in [CONTRIBUTING](CONTRIBUTING.md).
 
 ## Change Log
 
+### 18.4a4
+
+* don't populate the cache on `--check` (#175)
+
+
 ### 18.4a3
 
 * added a "cache"; files already reformatted that haven't changed on disk

diff --git a/black.py b/black.py
index 5458198b17560621545fdcb0d15a4c32fcdb6522..4c5f0f0c2590d476e53fdb3f5d19ed3152928a06 100644 (file)
--- a/black.py
+++ b/black.py
@@ -43,7 +43,7 @@ from blib2to3 import pygram, pytree
 from blib2to3.pgen2 import driver, token
 from blib2to3.pgen2.parse import ParseError
 
-__version__ = "18.4a3"
+__version__ = "18.4a4"
 DEFAULT_LINE_LENGTH = 88
 
 # types
@@ -245,7 +245,7 @@ def reformat_one(
                 )
             ):
                 changed = Changed.YES
-            if write_back != WriteBack.DIFF and changed is not Changed.NO:
+            if write_back == WriteBack.YES and changed is not Changed.NO:
                 write_cache(cache, [src], line_length)
         report.done(src, changed)
     except Exception as exc:
@@ -312,7 +312,7 @@ async def schedule_formatting(
 
     if cancelled:
         await asyncio.gather(*cancelled, loop=loop, return_exceptions=True)
-    if write_back != WriteBack.DIFF and formatted:
+    if write_back == WriteBack.YES and formatted:
         write_cache(cache, formatted, line_length)