Strip trailing commas in subscripts with -C (#3209)

Fixes #2296, #3204

diff --git a/CHANGES.md b/CHANGES.md
index 79f4ce591872ff2802302a56f775efb4afdd6b3f..fb7a2723b67f569fe6801b5d030fb1d3b4ebb613 100644 (file)
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -24,6 +24,8 @@
   this is invalid. This was a bug introduced in version 22.6.0. (#3166)
 - `--skip-string-normalization` / `-S` now prevents docstring prefixes from being
   normalized as expected (#3168)
   this is invalid. This was a bug introduced in version 22.6.0. (#3166)
 - `--skip-string-normalization` / `-S` now prevents docstring prefixes from being
   normalized as expected (#3168)

+- When using `--skip-magic-trailing-comma` or `-C`, trailing commas are stripped from
+  subscript expressions with more than 1 element (#3209)

 
 ### _Blackd_
 
 
 ### _Blackd_
 

diff --git a/src/black/lines.py b/src/black/lines.py
index 1ebc7808901d03335b48bf8d5e8fe0bb12d729a3..30622650d53cd631cdcb800ce8e2a546b0de6840 100644 (file)
--- a/src/black/lines.py
+++ b/src/black/lines.py
@@ -273,6 +273,8 @@ class Line:
         - it's not a single-element subscript
         Additionally, if ensure_removable:
         - it's not from square bracket indexing
         - it's not a single-element subscript
         Additionally, if ensure_removable:
         - it's not from square bracket indexing

+        (specifically, single-element square bracket indexing with
+        Preview.skip_magic_trailing_comma_in_subscript)

         """
         if not (
             closing.type in CLOSING_BRACKETS
         """
         if not (
             closing.type in CLOSING_BRACKETS


@@ -301,8 +303,22 @@ class Line:
 
             if not ensure_removable:
                 return True
 
             if not ensure_removable:
                 return True

+

             comma = self.leaves[-1]
             comma = self.leaves[-1]

-            return bool(comma.parent and comma.parent.type == syms.listmaker)
+            if comma.parent is None:
+                return False
+            if Preview.skip_magic_trailing_comma_in_subscript in self.mode:
+                return (
+                    comma.parent.type != syms.subscriptlist
+                    or closing.opening_bracket is None
+                    or not is_one_sequence_between(
+                        closing.opening_bracket,
+                        closing,
+                        self.leaves,
+                        brackets=(token.LSQB, token.RSQB),
+                    )
+                )
+            return comma.parent.type == syms.listmaker

 
         if self.is_import:
             return True
 
         if self.is_import:
             return True

diff --git a/src/black/mode.py b/src/black/mode.py
index f6d0cbf62bd46b579fec3520618e6c1c8b117ceb..6c0847e8bccc50f9305c2c12083d616a45d4434a 100644 (file)
--- a/src/black/mode.py
+++ b/src/black/mode.py
@@ -156,6 +156,7 @@ class Preview(Enum):
     remove_block_trailing_newline = auto()
     remove_redundant_parens = auto()
     string_processing = auto()
     remove_block_trailing_newline = auto()
     remove_redundant_parens = auto()
     string_processing = auto()

+    skip_magic_trailing_comma_in_subscript = auto()

 
 
 class Deprecated(UserWarning):
 
 
 class Deprecated(UserWarning):

diff --git a/tests/data/preview/skip_magic_trailing_comma.py b/tests/data/preview/skip_magic_trailing_comma.py
new file mode 100644 (file)
index 0000000..e98174a
--- /dev/null
+++ b/tests/data/preview/skip_magic_trailing_comma.py
@@ -0,0 +1,34 @@
+# We should not remove the trailing comma in a single-element subscript.
+a: tuple[int,]
+b = tuple[int,]
+
+# But commas in multiple element subscripts should be removed.
+c: tuple[int, int,]
+d = tuple[int, int,]
+
+# Remove commas for non-subscripts.
+small_list = [1,]
+list_of_types = [tuple[int,],]
+small_set = {1,}
+set_of_types = {tuple[int,],}
+
+# Except single element tuples
+small_tuple = (1,)
+
+# output
+# We should not remove the trailing comma in a single-element subscript.
+a: tuple[int,]
+b = tuple[int,]
+
+# But commas in multiple element subscripts should be removed.
+c: tuple[int, int]
+d = tuple[int, int]
+
+# Remove commas for non-subscripts.
+small_list = [1]
+list_of_types = [tuple[int,]]
+small_set = {1}
+set_of_types = {tuple[int,]}
+
+# Except single element tuples
+small_tuple = (1,)

diff --git a/tests/test_format.py b/tests/test_format.py
index 3645934721f0248278d08e14c6386cbd2bcde86d..01cd61eef63dee3272e156d5e5700ad9f4152eda 100644 (file)
--- a/tests/test_format.py
+++ b/tests/test_format.py
@@ -36,7 +36,12 @@ def test_simple_format(filename: str) -> None:
 
 @pytest.mark.parametrize("filename", all_data_cases("preview"))
 def test_preview_format(filename: str) -> None:
 
 @pytest.mark.parametrize("filename", all_data_cases("preview"))
 def test_preview_format(filename: str) -> None:

-    check_file("preview", filename, black.Mode(preview=True))
+    magic_trailing_comma = filename != "skip_magic_trailing_comma"
+    check_file(
+        "preview",
+        filename,
+        black.Mode(preview=True, magic_trailing_comma=magic_trailing_comma),
+    )

 
 
 @pytest.mark.parametrize("filename", all_data_cases("preview_39"))
 
 
 @pytest.mark.parametrize("filename", all_data_cases("preview_39"))